Your message dated Wed, 03 Feb 2021 13:51:41 +0000
with message-id <[email protected]>
and subject line Bug#921700: fixed in xpra 3.0.9+dfsg1-1.1
has caused the Debian Bug report #921700,
regarding [xpra] FTBFS: xvfb path patch
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
921700: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=921700
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: xpra
Version: 2.4.3+dfsg1-1
Severity: serious
Tags: patch

--- Please enter the report below this line. ---

At least on my setup,  detect_xorg_setup(install_dir)  in setup.py already
produces

xvfb_command[0] == '/usr/lib/xorg/Xorg'

(around line 822 in setup.py).

The assertion installed by our Debian specific patch does not consider
that as a possibility. The attached updated patch relaxes the assertion,
resolving the FTBFS.

--- System information. ---
Architecture: Kernel:       Linux 4.19.0-2-amd64

Debian Release: buster/sid

--- Package information. ---
Depends                              (Version) | Installed
==============================================-+-==================
init-system-helpers                  (>= 1.51) | 1.56+nmu1
python                                (<< 2.8) | 2.7.15-4
python                               (>= 2.7~) | 2.7.15-4
python:any                            (<< 2.8) | python:any                     
      (>= 2.7~) | libavcodec58                        (>= 7:4.0)
| libavformat58                       (>= 7:4.1) | 7:4.1-1
libavutil56                         (>= 7:4.0) | libc6                          
      (>= 2.14) | libglib2.0-0                       (>= 2.12.0)
| libgtk2.0-0                        (>= 2.24.0) | libpam0g                     
    (>= 0.99.7.1) | libswscale5                         (>=
7:4.0) | libsystemd0                                    | libturbojpeg0         
              (>= 1.4.0) | libvpx5
(>= 1.6.0) | libwebp6                            (>= 0.5.1) | libx11-6          
           (>= 2:1.2.99.901) | libx264-155
              | libx265-165                           (>= 2.9) | libxcomposite1 
                   (>= 1:0.3-1) | libxdamage1
      (>= 1:1.1) | libxext6                                       | libxfixes3  
                                   | libxi6
    (>= 2:1.2.99.4) | libxkbfile1                                    | 
libxrandr2                     (>= 2:1.2.99.2) | libxtst6
                       | adduser                                        | 
python-gi-cairo                                | python-gtk2
                          | x11-xserver-utils                              | 
xserver-xorg-input-void                        |
xserver-xorg-video-dummy                       | python-rencode                 
                |

Recommends                  (Version) | Installed
=====================================-+-===========
keyboard-configuration                | 1.188
python-paramiko                       | 2.4.2-0.1
openssh-client                        | 1:7.9p1-5
ssh-askpass                           | 1:1.2.4.1-10
python-lz4                            | 1.1.0+dfsg-1
python-lzo                            | 1.12-2
python-pil                            | 5.4.1-1
 OR python-imaging                    | python-gtkglext1                      | 
1.1.0-9.1
python-dbus                           | 1.2.8-3
python-uritools                       | 2.1.0-1


Suggests                       (Version) | Installed
========================================-+-===========
openssh-server                           | 1:7.9p1-5
python-pyopencl                          | gstreamer1.0-plugins-base            
    | gstreamer1.0-plugins-good                |  OR
gstreamer1.0-plugins-ugly            |  OR gstreamer1.0-plugins-bad             
| python-gst-1.0                           | pulseaudio
                      | pulseaudio-utils                         | python-avahi 
                            | python-netifaces
       | cups-client                              | cups-common                 
             | cups-filters                             |
cups-pdf                                 | python-cups                          
    | python-opencv                            |
v4l2loopback-dkms                        | python-yaml                          
    | python-uinput                            |
Description: Fix path to Xorg binary in /etc/xpra/conf.d/55_server_x11.conf
 We need the (absolute) path to the non-setuid binary and not to a possibly
 installed setuid-wrapper (which requires root or login on a tty).
 Auto-dection fails as Xorg is not installed in the build environment.
 .
 As the Xorg setuid wrapper is Debian specific (and might be removed in the
 future) there's no need to upstream this change.
Author: Simon Ruderich <[email protected]>
Bug-Debian: https://bugs.debian.org/863891
Forwarded: not-needed
Last-Update: 2019-02-07

Index: xpra-2.4.3+dfsg1/setup.py
===================================================================
--- xpra-2.4.3+dfsg1.orig/setup.py
+++ xpra-2.4.3+dfsg1/setup.py
@@ -819,6 +819,12 @@ def detect_xorg_setup(install_dir=None):
 def build_xpra_conf(install_dir):
     #generates an actual config file from the template
     xvfb_command = detect_xorg_setup(install_dir)
+    xorg_call = '/usr/lib/xorg/Xorg'
+    if xvfb_command[0] != xorg_call:
+        assert xvfb_command[0] == 'Xorg'
+        xvfb_command[0] = xorg_call
+
+    xvfb_command[0] = '/usr/lib/xorg/Xorg'
     from xpra.platform.features import DEFAULT_ENV
     def bstr(b):
         if b is None:

--- End Message ---
--- Begin Message ---
Source: xpra
Source-Version: 3.0.9+dfsg1-1.1
Done: Antonio Russo <[email protected]>

We believe that the bug you reported is fixed in the latest version of
xpra, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Antonio Russo <[email protected]> (supplier of updated xpra package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 02 Feb 2021 23:22:38 -0700
Source: xpra
Architecture: source
Version: 3.0.9+dfsg1-1.1
Distribution: unstable
Urgency: medium
Maintainer: Dmitry Smirnov <[email protected]>
Changed-By: Antonio Russo <[email protected]>
Closes: 921700 956822
Changes:
 xpra (3.0.9+dfsg1-1.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Tweak fix-xvfb-patch.patch (Closes: #921700, #956822).
Checksums-Sha1:
 6ed43b95a0576b593398ae7c00f2ab1ccd8884d8 2459 xpra_3.0.9+dfsg1-1.1.dsc
 40c1e747fb00ff1e52c84418b535b1ea40afa43c 36480 
xpra_3.0.9+dfsg1-1.1.debian.tar.xz
 e9e421b8fdf04ab1e2894820d10bcfc24fff5e27 15939 
xpra_3.0.9+dfsg1-1.1_armhf.buildinfo
Checksums-Sha256:
 0e73bf9c18b633415d3098b7c71172e9c915eaaed1d49aaef8f33785f34c3762 2459 
xpra_3.0.9+dfsg1-1.1.dsc
 92a2712f02b7c456053b7e496aaad94f4cd09679cde0bec40a535dbab2de81fb 36480 
xpra_3.0.9+dfsg1-1.1.debian.tar.xz
 2091359a2293958d4feeb35453fd498e47599d9a2ee9e31e4611185df17c4b6c 15939 
xpra_3.0.9+dfsg1-1.1_armhf.buildinfo
Files:
 1c19791c7dc857779e480e95f6ec67be 2459 x11 optional xpra_3.0.9+dfsg1-1.1.dsc
 b7ab448ae9c5f24dc02aaf4fb9f02b06 36480 x11 optional 
xpra_3.0.9+dfsg1-1.1.debian.tar.xz
 3ef5ecc5b55d829477ad486306256622 15939 x11 optional 
xpra_3.0.9+dfsg1-1.1_armhf.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEER4nvI8Pe/wVWh5yq+4YyUahvnkcFAmAapw0ACgkQ+4YyUahv
nkf64xAAu+s+8C7zyq5DZWdWudDKdGrIxPp7f4ZnHsqxKmHZYi5Up7TdMrcZkQdf
4Pjhdz0z86fpIiimNgnDlNTAYsKIge0E4UDC1C+JCE+fSLxKebRYRcjdHKiLm3hD
60+TLoYmpIk6w8tyTC3sbqPlxJofDixpPjiVMKc2NprTc1xKIOXKj+JY16iDCw0t
1UDPixRcl2AeGDCpqAZ5QSVKTQ3FkVcGstQx7ZZfJevdMP2nQryMfCGBZaeT0lGq
G3nNklNa6o5G9ljqCnzG0tCydEDuDlFrk6U1lYJ2fuCVurCR9i3Yd9r0MbVQOPD9
58JUO5z/2etpPJ535WMtqlJ5Sr236fUgw51ZyjdP/IU6MVrqwJrSlsFMv1WfD4fp
8Py+62tqBWz+dZKW9sYB3G3MgclvovA+CxtWTZrkz/c1RdHf4JOl1+VY66NhjT8x
ToVjt2MEhgVTX+2qa4nrAnwssvN9ANlZWE60EL0Jbc/vxYvIvfHPrrgeRQ/9DeSF
3WPOc/ukXhmISV1y9tw8RqXnFWLR/Ik1jaKFkmsQPTRwMu1nvvHUdsPA7Dzsbg1D
iARi5Y9kql1mSkzEPygBJFIXYkmWxp5MTgAm0agkPmAtTnDpu/ZiqECIzb+PQv9c
YUhgNUzCz6LODGh45+3ZJS8g9pNr+dYGPlMZJ7LGTSaAAOpTIZE=
=aNgC
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to