Your message dated Sun, 14 Feb 2021 04:18:23 +0000
with message-id <[email protected]>
and subject line Bug#982575: fixed in ncmpc 0.45-1
has caused the Debian Bug report #982575,
regarding ncmpc: fails with "unknown tag type" when talking to older mpd servers
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
982575: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982575
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ncmpc
Version: 0.43-1
Tags: patch
Severity: important
Control: forwarded -1 https://github.com/MusicPlayerDaemon/ncmpc/issues/93
After upgrading to 0.43-1 on debian testing/unstable, ncmpc no longer
offers a useful connection to my mpd server, instead showing Unknown tag
type in red.
This makes ncmpc completely unusable for me, as I cannot reach the
playlist, the file browser, or even adjust the volume.
the server in question is running mpd version 0.21.5-3 (from debian stable)
Other mpd clients (like mpc version 0.33-1, and an Android mpd client)
continue to work fine with the same server.
Upstream offered the attached patch, which I've tested locally; it
resolves the problem for me. It (or an even better fix) will probably
be part of 0.45 whenever upstream gets around to releasing that version.
Regards,
--dkg
From: Max Kellermann <[email protected]>
Date: Thu, 11 Feb 2021 21:44:15 +0100
Subject: mpdclient: make "tagtypes" errors non-fatal
This makes ncmpc usable even if applying the tag mask fails (for
whatever reason).
This fixes https://github.com/MusicPlayerDaemon/ncmpc/issues/93 (but a
better fix will follow).
(cherry picked from commit 7ce348cd21862e1f6b8228acbbff1a7df4df90d7)
---
src/mpdclient.cxx | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/mpdclient.cxx b/src/mpdclient.cxx
index cc04743..b6e6ba2 100644
--- a/src/mpdclient.cxx
+++ b/src/mpdclient.cxx
@@ -331,9 +331,12 @@ mpdclient::OnConnected(struct mpd_connection *_connection) noexcept
mpd_connection_cmp_server_version(connection, 0, 21, 0) >= 0 &&
!SendTagWhitelist(connection, tag_whitelist)) {
InvokeErrorCallback();
- Disconnect();
- mpdclient_failed_callback();
- return false;
+
+ if (!mpd_connection_clear_error(connection)) {
+ Disconnect();
+ mpdclient_failed_callback();
+ return false;
+ }
}
#endif
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: ncmpc
Source-Version: 0.45-1
Done: Geoffroy Youri Berret <[email protected]>
We believe that the bug you reported is fixed in the latest version of
ncmpc, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Geoffroy Youri Berret <[email protected]> (supplier of updated ncmpc package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 12 Feb 2021 12:39:11 +0100
Source: ncmpc
Architecture: source
Version: 0.45-1
Distribution: unstable
Urgency: medium
Maintainer: mpd maintainers <[email protected]>
Changed-By: Geoffroy Youri Berret <[email protected]>
Closes: 982575
Changes:
ncmpc (0.45-1) unstable; urgency=medium
.
* New upstream release (Closes: #982575)
* Add dependency on python3-unidecode in ncmpc-lyrics
* Update copyright
Checksums-Sha1:
8c456b4cc74222cea026f3a2bcd0b8f3b87c2a74 2098 ncmpc_0.45-1.dsc
e83ddb8f33f57ccff9261e05a5b1e66712bf8196 281860 ncmpc_0.45.orig.tar.xz
d0713af21036771865f1c9bf58ca63f485afb134 16816 ncmpc_0.45-1.debian.tar.xz
a77be0bbf183e81221d0e7b6299c880fe12f9b32 8507 ncmpc_0.45-1_amd64.buildinfo
Checksums-Sha256:
858550e0a27e3b8e803ca70074f29908f5ac9b1b688eb350214cfcb7bd3a3bcd 2098
ncmpc_0.45-1.dsc
17ff446447e002f2ed4342b7324263a830df7d76bcf177dce928f7d3a6f1f785 281860
ncmpc_0.45.orig.tar.xz
60cc9823b97405f1f1e361d0f17a574f7bb70fc8182f974c2ebb9f59bb0bd315 16816
ncmpc_0.45-1.debian.tar.xz
8b5e74278b8b59715ff607ddcb244daa658a4a2ee6eb33e72fb81dc3be040aca 8507
ncmpc_0.45-1_amd64.buildinfo
Files:
10f0ae2fa574cf36231b3cc8229c9eb1 2098 sound optional ncmpc_0.45-1.dsc
f0bdd820ff0c6c72ae220dd23accae1d 281860 sound optional ncmpc_0.45.orig.tar.xz
3ef1ecf8ced187631079ba523d352817 16816 sound optional
ncmpc_0.45-1.debian.tar.xz
3f1cdb25ece1830d4f9047a02c8633f4 8507 sound optional
ncmpc_0.45-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEMLI8i05qOwnqprZSEpc7bnLcB7UFAmAooCkACgkQEpc7bnLc
B7WVOBAAglmrHAQpDT8g+reegQbSlyBs6yk+aGEmCadTVzhnfJdYBnDWjbx+jwCl
SwdQj+4XJ8uPsvHz3bqSOXyBwXrB6Fd1C2gCvVWXPZxYwnCmgX7ejg1l5z212Y6x
fphqCS0hNUJuMz/KOUtPNe0D2H8pO2yFRF8xa60jVcSgDnUw3LbCul09Ew/yVsyS
AAn5Rs9Jg9OyZlvGMQipcENLBiKIkqenjdPJMINDy7RVyFzy1FvO3BGIRE/e4IpY
nQfpVGPPVJk6VZxYjnEC1DV8oajZhgGgzpvtH/7uSEgA9fA1w+kg8HUG3lGvkuJw
cbjc+KwXD+rF+2aUHx4Xl8Tqjdl3HtHPrLTXhxnxABQFDiofifRNoRzHRS/IELGv
I7UPzXab6dRpUnPjDDGTAjM/R2uvcnlYKLMYt6Y8O1ePP1alo70570OCECdaihS3
PvG/rn+om0YFrPZl6DLTE87YafLfn3ctUGVzDPHOyk1KLi2kkH7Snyww+o/Oiob9
530XeHkOaHDHmQPiHsjKDEPLERmVM66SJtC3nTwZaln5Q8F6c1UGMoRhvpBfu51H
QF+geFwmgqd5MZuOIMxASdtZY0YXfrK3T4yKDNO7hUhR8afsyiE78iDU+xA8d/lp
jY5bwrwPy6br8DAbzJQS6L8GJiuu1UDL1TDs5mvi3ONVuFDnEns=
=d7Fc
-----END PGP SIGNATURE-----
--- End Message ---
