Your message dated Sun, 21 Feb 2021 16:48:28 +0000
with message-id <[email protected]>
and subject line Bug#947616: fixed in bible-kjv 4.32
has caused the Debian Bug report #947616,
regarding bible-kjv FTCBFS: builds for the build architecture
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
947616: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=947616
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: bible-kjv
Version: 4.30
Tags: patch
User: [email protected]
Usertags: ftcbfs
bible-kjv fails to cross build from source, because it builds for the
build architecture. Getting it to cross build properly is not entirely
trivial:
* A simple way to cross build makefile based packages is using
dh_auto_build.
* However dh_auto_build does not pass LD (as that variable doesn't have
a uniform meaning). It should be $(CC) here for example and needs to
be passed explicitly.
* Then bible-kjv has a number of build tools that need to be built for
the build architecture. In this case, we can split the build into two
parts: One for the build architecture and another for the host
architecture.
* The randverse build hard codes the build architecture compiler. We
can see the compiler variable from dpkg's buildtools.mk.
* bible-kjv is stripped using install -s and thus uses the wrong strip.
The easiest solution here is dh_strip.
Please consider applying the attached patch. Also consider converting
the package to a dh based packaging style. Doing so simplifies a lot of
things.
Helmut
diff --minimal -Nru bible-kjv-4.30/debian/changelog
bible-kjv-4.30+nmu1/debian/changelog
--- bible-kjv-4.30/debian/changelog 2018-05-12 11:03:54.000000000 +0200
+++ bible-kjv-4.30+nmu1/debian/changelog 2019-12-28 16:18:02.000000000
+0100
@@ -1,3 +1,15 @@
+bible-kjv (4.30+nmu1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: (Closes: #-1)
+ + Let dh_auto_build pass cross tools to make.
+ + Additionally override LD.
+ + Keep building the build tools for the build architecture.
+ + Seed the compiler used for randverse from dpkg's buildtools.mk.
+ + Use dh_strip as it uses the correct cross tool.
+
+ -- Helmut Grohne <[email protected]> Sat, 28 Dec 2019 16:18:02 +0100
+
bible-kjv (4.30) unstable; urgency=medium
* Fix string overflow bug found by gcc-8 (Closes: #897712)
diff --minimal -Nru bible-kjv-4.30/debian/control
bible-kjv-4.30+nmu1/debian/control
--- bible-kjv-4.30/debian/control 2018-05-12 11:03:54.000000000 +0200
+++ bible-kjv-4.30+nmu1/debian/control 2019-12-28 16:18:02.000000000 +0100
@@ -2,7 +2,7 @@
Section: doc
Priority: optional
Maintainer: Matthew Vernon <[email protected]>
-Build-Depends: libreadline-dev
+Build-Depends: libreadline-dev, debhelper-compat (= 9)
Standards-Version: 3.5.6
Package: bible-kjv
diff --minimal -Nru bible-kjv-4.30/debian/rules bible-kjv-4.30+nmu1/debian/rules
--- bible-kjv-4.30/debian/rules 2018-05-12 11:03:54.000000000 +0200
+++ bible-kjv-4.30+nmu1/debian/rules 2019-12-28 16:18:02.000000000 +0100
@@ -13,12 +13,17 @@
# dpkg-buildpackage in a package-independent way, and so these targets
# are obsolete.
+include /usr/share/dpkg/architecture.mk
+-include /usr/share/dpkg/buildtools.mk
+
package=bible-kjv
build:
$(checkdir)
- $(MAKE) all
- cd debian && gcc -g -O2 -o randverse randverse.c
+ dpkg-architecture -a$(DEB_BUILD_ARCH) -f -c dh_auto_build --
bible-index.c bible.data bible.data.conc 'LD=$$(CC)'
+ rm -f *.o
+ dh_auto_build -- bible 'LD=$$(CC)'
+ cd debian && $(CC) -g -O2 -o randverse randverse.c
touch build
build-arch: build
@@ -65,19 +70,10 @@
install -d debian/tmp/usr/share/man/man1
install -d debian/tmp/usr/bin debian/tmp/usr/lib
make install DEST=debian/tmp/usr
- #Is nostrip set in DEB_BUILD_OPTIONS?
- case "$$DEB_BUILD_OPTIONS" in \
- *nostrip*)\
- install -m 755 debian/randverse debian/tmp/usr/bin && \
- install -m 755 bible debian/tmp/usr/bin && \
- install -m 644 debian/randverse.1 debian/tmp/usr/share/man/man1 \
- ;; \
- *) \
- install -s -m 755 debian/randverse debian/tmp/usr/bin && \
- install -s -m 755 bible debian/tmp/usr/bin && \
- install -m 644 debian/randverse.1 debian/tmp/usr/share/man/man1 \
- ;; \
- esac
+ install -m 755 debian/randverse debian/tmp/usr/bin
+ install -m 755 bible debian/tmp/usr/bin
+ install -m 644 debian/randverse.1 debian/tmp/usr/share/man/man1
+ dh_strip -p$(package) --tmpdir=debian/tmp
cp debian/notes debian/copyright debian/tmp/usr/share/doc/$(package)/.
cp debian/changelog debian/tmp/usr/share/doc/$(package)/changelog
cp README* debian/README* debian/tmp/usr/share/doc/$(package)
--- End Message ---
--- Begin Message ---
Source: bible-kjv
Source-Version: 4.32
Done: Matthew Vernon <[email protected]>
We believe that the bug you reported is fixed in the latest version of
bible-kjv, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Matthew Vernon <[email protected]> (supplier of updated bible-kjv package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 21 Feb 2021 16:05:00 +0000
Source: bible-kjv
Binary: bible-kjv bible-kjv-text
Architecture: source
Version: 4.32
Distribution: unstable
Urgency: medium
Maintainer: Matthew Vernon <[email protected]>
Changed-By: Matthew Vernon <[email protected]>
Description:
bible-kjv - King James Version of the Bible: user interface program.
bible-kjv-text - King James Version of the Bible - text and concordance
Closes: 947616
Changes:
bible-kjv (4.32) unstable; urgency=medium
.
* Patch from Helmut Grohne to fix FTCBFS: (Closes: #947616)
+ Let dh_auto_build pass cross tools to make.
+ Additionally override LD.
+ Keep building the build tools for the build architecture.
+ Seed the compiler used for randverse from dpkg's buildtools.mk.
+ Use dh_strip as it uses the correct cross tool.
Checksums-Sha1:
9d826e1a6869b321448b3a6aebc6e51ef2ed4d53 1619 bible-kjv_4.32.dsc
79ce48b2f96107f091bee2dd57952dbdaa2a5706 1412640 bible-kjv_4.32.tar.gz
Checksums-Sha256:
a573336f7bad13ee14e03df1d4e4baff06584163f19cdbca4c354d2055b6ff55 1619
bible-kjv_4.32.dsc
2d7dc093467d58daf34a0159a060011eae5c074c18d36ecc8f2ee102f4023b8c 1412640
bible-kjv_4.32.tar.gz
Files:
541363c5232f0bce0543e4dad9d5ab90 1619 doc optional bible-kjv_4.32.dsc
9f9810fdccf0183f524561b867c22e21 1412640 doc optional bible-kjv_4.32.tar.gz
-----BEGIN PGP SIGNATURE-----
iQJHBAEBCgAxFiEEuk75yE35bTfYoeLUEvTSHI9qY8gFAmAyiKwTHG1hdHRoZXdA
ZGViaWFuLm9yZwAKCRAS9NIcj2pjyA+mEACOUwQH7ixLAnkDOTS2AoMINJUXh/dv
cpQb2dk/YrsHoJYfSY4YX9b8LY2E4CqrZ97T8mTImkWNN4hAp48vsLXb/7tWVliu
9FxlB1BEqtD4IY+p/xwIatH7ijSF+oHd6MXeFbhgcgnKME3jqyz4PGwp0cYbxnhB
WOzqSPhCIYIa+ovc8eyksBuDPm5MHTdn/Ug5E1UuuOQH9KZdXe72ve9pT6tqWFxL
gJVFq6Sn0OxLk0FwNpUdfgVsZiFvMMfzuzLFnefJ9GCl8xjmDJh6OjZLTKK5b2Sc
6fdVtrBo4mKzTTPhoyq/kCmc8DGly9ygBSziP/i7R91b0+C+It+oXVz3SNTOZVWg
gWt++a1NNh8Jm+sUWa/GVuN9qgktQplZSKSAzrRiuTP7E3J+IX5NWAS/2UrFvM12
b3HqxoRw/A7aFniUMR4JZicE/OeFDjC4UmCTMq+nvnrlJEOiAWE2ZDeeEh1Bp7uh
lZG6hnfqNbItIdqh2ymjg8bXaMuUvYcsqxL122oOqY6XGjFaNSirrVltRMpf4buz
uSE2wdvChFN5Mm2Nm7n5Lj3vBrMEhMe9pnurLyBZpHuTymoflyCWDSK8lNU6x9I/
7lH+dbYcwHImI9AIyBxzW8Qf2YqKAn6M++FDDYXSmphWUJlEO1AD+XL5F960DjjL
hwtJX8x68jX3mw==
=Wi6v
-----END PGP SIGNATURE-----
--- End Message ---
