Your message dated Thu, 04 Mar 2021 20:33:35 +0000
with message-id <[email protected]>
and subject line Bug#918187: fixed in fai 5.10
has caused the Debian Bug report #918187,
regarding fai - hook error handling completely broken
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
918187: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918187
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: fai
Version: 5.7.2
Severity: grave

There seems to be no way to make hooks abort the run.  I explicitely
made a hook always fail and it always continued:

| partition.GRUB_CLOUD_AMD64 FAILED with exit code 1.
| Skipping task_partition
| Calling hook: mountdisks.CLOUD
| No fstab file /var/log/fai/debian/install-20190104_050000/fstab found.
| mountdisks.CLOUD     FAILED with exit code 117.
| Skipping task_mountdisks
| Calling task_extrbase
| ftar: No matching class found in /var/tmp//

The exit value is reported via lib/check_status, but never saved.

Another problem: fai-do-scripts wants to do "RC+100".  As exit values
are a value from 0 to 255, this can overflow.

Bastian

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), 
LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

--- End Message ---
--- Begin Message ---
Source: fai
Source-Version: 5.10
Done: Thomas Lange <[email protected]>

We believe that the bug you reported is fixed in the latest version of
fai, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Lange <[email protected]> (supplier of updated fai package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 04 Mar 2021 20:50:20 +0100
Source: fai
Architecture: source
Version: 5.10
Distribution: unstable
Urgency: low
Maintainer: Thomas Lange <[email protected]>
Changed-By: Thomas Lange <[email protected]>
Closes: 918187 960245 961127 965262 970064
Changes:
 fai (5.10) unstable; urgency=low
 .
   [ Eldon Koyle ]
   * fai-chboot: Add NFSROOT_SERVER to explicitly set NFS server
 .
   [ Vagrant Cascadian ]
   * rules: improve reproducible builds
 .
   [ Sébastien Gross ]
   * setup-storage: Add a list of all bootable devices to log file
 .
   [ dpoon ]
   * fetch-basefile: Allow . characters in the name of base images
 .
   [ Florian Schmaus ]
   * 10-rootpw: use here document to protect root password
   * Remove duplicated unattended-upgrades entry in package_config
 .
   [ Carsten Aulbert ]
   * 10-setup: strip last p from nvme device names
   * GRUB_PC/10-setup: provide code for get_stable_devname
 .
   [ Thomas Lange ]
   * GRUB_PC/10-setup: fix for #982182, add devices to debconf, do not use
     grub-probe any more
   * fai-disk-info: detect more nvme device names, Closes: #960245
   * fai-class: exit with correct exit code, allow early abort after each
     script, Closes: #961127
   * subroutines: do not show USERPW,
     add third parameter to task_error(), delay abortion in case of an
     error, recheck task error after calling fai-class,
     task_error now writes into two files instead of setting a shell
     variable, Closes: #918187
   * add $secsuite for supporting $release/updates and $release-security,
     Closes: #970064
   * fai-sed: change exit value if file was changed, add options -n -E
     simplify code
   * fai-make-nfsroot: add option -c, fix syntax error,
     use lpxelinux.0 as default which supports http, omit virtfs
     copy log file also into $nfsroot/var/tmp
   * nfsroot.conf: no need to exclude wget any more
   * fai: use unshare when calling chroot
   * mount2dir: ignore nfs mounts
   * several shellcheck fixes
   * fcopy: print file mode in octal
   * get-boot-info: use ip --brief, remove variables NETMASK,BROADCAST
   * NEWS: add change of fai-sed
   * mkramdisk: set tmpfs size to 80%
   * fai-chboot: move comment in config written to end of file
   * install_packages: do not write install_packages.list if dry-run
   * prcopyleft: new year, use my new email address
   * setup-storage: print which command failed
   * fai-kvm: add option -O, update options for network devices
   * subroutines: call udevadm trigger to get more infos about network
   * package_config/DEBIAN: add non-free wireless packages
   * 30-interface: remove obsolete test, use CIDR
   * mk-basefile: add bookworm,trixie releases
   * LAST/50-misc: add trixie release
   * 20-hwdetect.sh: use ip --brief
   * rc.local/FAISERVER: check /etc/network/interfaces.d/$IFACE for nic
     devices, Closes: #965262
   * 40-parse-profiles.sh: use mktemp instead of tempfile
   * fai-debconf: add test if subdir exists
   * fai-guide.txt: remove apt-key usage, prefer .gpg over .asc
   * fai-setup: fix setting $myip
   * NFSROOT: remove moreutils
Checksums-Sha1:
 871872c3e04353f03c5e9b18e273bbcd2cbbf9c6 1935 fai_5.10.dsc
 2b7cae3b5be1c8d1a98d2b477172febf95ee5fd8 288616 fai_5.10.tar.xz
 409f4f3395067bd82787ec64c5b19b07280e4cdb 13080 fai_5.10_amd64.buildinfo
Checksums-Sha256:
 eca21305af1834dc798ef463e797f05de0691474c5db456270ed5cfea4ac26d0 1935 
fai_5.10.dsc
 7d2455cae5454569657d908a81934977ca48f16bcf240bbf9aefd7be31fbc90b 288616 
fai_5.10.tar.xz
 0c68b58139207fc3bb35eef08713b2201cc30f81db8cbe2534c22b157ea48d56 13080 
fai_5.10_amd64.buildinfo
Files:
 bb2ca3df0cbcc4367c7018d5673cb228 1935 admin optional fai_5.10.dsc
 6222cbae26a235cf57151ea4179347eb 288616 admin optional fai_5.10.tar.xz
 ee5f2366a5ea0c5fd20af1f2adac724e 13080 admin optional fai_5.10_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCAAvFiEEsR7jJz9rLetSjJPaK/jZ/gdLzeQFAmBBOy4RHGxhbmdlQGRl
Ymlhbi5vcmcACgkQK/jZ/gdLzeRk0g//f51MunCQCxLWxQolKl4aRx7xQjX3JTHj
st4AmeaKO/ugsyEYSoX6ZkXe8UIhyPYshuQi6oXr4HmECW25/J1UWRrb1ufy3fKR
ZPa1Y7eVcwfO2BTWk+N/ALkDfJ3gEtcE3r/3PyimVGZ1pMGgiulzRHEZi55/eohx
qsc61LG3zkqUYmRqSkdWO5J6q9KAowhUMNLHQH6ShPXg405+V4ItAgjIv/h5a6Er
Ylh4or3GnA/JQz1ZO+xJm78zhi7u9H+Iir7GC8iKqggc7Hsi4Uh4InMo6THs4h24
K1jVRgR67mnJXJD+69byCvPlYIiCAH1eubAx+CEtjXdWXmXJCXttY+pbT3pObmYT
I2spc5UFCM6s9b6aNV4ecjtC/3CY0HVqWO8CyRzDn7rj/pksiDhGmKIgEirydrhe
T9QkmasHvr/F0vELhzzwb5COzGM3MhjLU2MyGXhSiEtsDm9cexx7DErj/jm4MV6C
e3i/kK/hu3AUIeaylNkYWNrWZHfBcaS2z2Ef74iAsmVULr43pNG9ihrPk8PCb9DM
gfX50jyxqCiiEcMx8ktu2+F3mvidGwuRMDfeLd+irXGJmLMbjuILXQF8pYYfxrgL
9AzyWN9tp340+BjRT1+iGi/BmCb3FHowjSvNB1rQ5ciETCzWrjiTW5JMFg3brNEA
eCpADqy83VA=
=JtFb
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to