Your message dated Sat, 15 May 2021 14:49:09 +0000
with message-id <[email protected]>
and subject line Bug#983198: fixed in torbrowser-launcher 0.3.3-4
has caused the Debian Bug report #983198,
regarding torbrowser-launcher: launcher does not detect torbrowser as installed 
on non-EN user session
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
983198: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983198
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: torbrowser-launcher
Version: 0.3.3-3
Severity: normal
Tags: patch
X-Debbugs-Cc: [email protected]

Package: torbrowser-launcher
Version: 0.3.3-3
Severity: normal
Tags: patch

Dear Maintainer,

I believe i found an issue with the launcher (somehow related with #842021) 

It happens that though the launcher works it doesn't detect torbrowser
as installed. It causes two issues:
  - The 'Settings' window points status as Not Installed;
  - The 'Browser launcher' keeps running the routines to download and
verify the 'first installation'.

I realized that reload the settings after rebuilding paths makes the
launcher works as expected.

Plus, load_settings() is not checking changes at 'installed' directive
to rewrite the settings file ('settings.json').


Regards,

Marcelo S Mota
Description: fix failure in detect installed torbrowser
Author: Marcelo Soares Mota <[email protected]>
Last-Update: 2021-02-20

--- torbrowser-launcher-0.3.3.orig/torbrowser_launcher/common.py
+++ torbrowser-launcher-0.3.3/torbrowser_launcher/common.py
@@ -64,6 +64,7 @@ class Common(object):
         self.load_mirrors()
         self.load_settings()
         self.build_paths()
+        self.load_settings()
         self.mkdir(self.paths["download_dir"])
         self.mkdir(self.paths["tbb"]["dir"])
         self.init_gnupg()
@@ -371,7 +372,10 @@ class Common(object):
             resave = False
 
             # detect installed
-            settings["installed"] = os.path.isfile(self.paths["tbb"]["start"])
+            installed = os.path.isfile(self.paths["tbb"]["start"])
+            if settings["installed"] != installed:
+                settings["installed"] = installed
+                resave = True
 
             # make sure settings file is up-to-date
             for setting in default_settings:

--- End Message ---
--- Begin Message ---
Source: torbrowser-launcher
Source-Version: 0.3.3-4
Done: Roger Shimizu <[email protected]>

We believe that the bug you reported is fixed in the latest version of
torbrowser-launcher, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Roger Shimizu <[email protected]> (supplier of updated torbrowser-launcher 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 15 May 2021 23:32:12 +0900
Source: torbrowser-launcher
Architecture: source
Version: 0.3.3-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Privacy Tools Maintainers 
<[email protected]>
Changed-By: Roger Shimizu <[email protected]>
Closes: 976084 980155 983198
Changes:
 torbrowser-launcher (0.3.3-4) unstable; urgency=medium
 .
   * debian/control:
     - Update homepage.
   * debian/patches:
     - Update patch 03 to adapt python >= 3.8
     - Add patch 08 to update apparmor profile (Closes: #980155).
     - Add patch 09 to fix failure in detect installed torbrowser.
       (Closes: #983198)
     - Add patch 10 to enable keyboard input to communicate with ibus.
       (Closes: #976084)
Checksums-Sha1:
 4cf5ac18aa2b578af6d83e2739d4120c82d257b4 2281 torbrowser-launcher_0.3.3-4.dsc
 fdc497ee56341384659c61621cdc9e52e8bf9ea0 28048 
torbrowser-launcher_0.3.3-4.debian.tar.xz
 a2c4154002250c494890b574ba89e45202c62c61 13322 
torbrowser-launcher_0.3.3-4_source.buildinfo
Checksums-Sha256:
 5cc2e520bdb7b8bcabb70b5882f04eee8d1a875f24cea30b4de478de5a043eaa 2281 
torbrowser-launcher_0.3.3-4.dsc
 dbda636ac55eda5f0f670a168fc76ba9eae65066c312a77074c2c29050a7e2a0 28048 
torbrowser-launcher_0.3.3-4.debian.tar.xz
 785e6051c033d7b158310f3c6dc1cce802aad2e14db150a79848b15b86cf42f5 13322 
torbrowser-launcher_0.3.3-4_source.buildinfo
Files:
 2ba505c5afbe9c0d534f1eb2a6bbf527 2281 contrib/web optional 
torbrowser-launcher_0.3.3-4.dsc
 d90aace489fb5397577d9bcbd7d5a826 28048 contrib/web optional 
torbrowser-launcher_0.3.3-4.debian.tar.xz
 70575a7db1d050110b975298c5c8d846 13322 contrib/web optional 
torbrowser-launcher_0.3.3-4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEECjKtvoA5m+cWOFnspHhrDacDNKgFAmCf24sQHHJvc2hAZGVi
aWFuLm9yZwAKCRCkeGsNpwM0qLu1D/9HrLW8ykFs68V+GsP1vrn1+tsJZ+dNusi1
btPb3uR+J27HiaAZ0WaVLmP7YMmkiebttNXGS1cxiYvIrhuA2plNYKUyY4/2xAJI
fTDrRy/40pSbJ53zwbscVMr+ZLk0g/nJ4sCvmWybA64eJT6SClUVKCskg5FidfxG
Dd+qqymPZW8QVAo2s0B4YZ0Xet6l2ukqZ2O6emc577SYD9z/6obsETEGQULXCmzJ
1hU2kkDAEV8IWE3nxW2zTHK0SE8Lhx/uNOSpXHk42xnwQrgZIvfeN6ZioQ5qErpH
i5EMh3+lfyg1PJTwtk8MdWae6EeCvSUZhR2XtaMXsnHqb8wJIag592LEdtFyamok
Gvl/IbUAXMEbVvLDORqGZ/jtvAj9WzI4MOdSbYbGIBbjCkSlsl+YzM8nWd+tqaEe
icu8M7ROBsnvtygEyuolCKwSWujo/opX4A8K42UtShZo4RDx7aarJ5iZh2LkOnb5
ODBOCOSYIpM73xYsJudVGwsUIanCe3nrR4uSfymwCJGC3Xd0OGWRWzNBZeDN+tMR
CKerePllm7hg3y3mjWScbBnHcKy/0ErcoetAUfe+uURJvVEclUO156/RuHJEmvgu
k7aQdVsw7Kd+45OZmNrwVMvSY03DgxaiuAMPnJnJdJaq380zEvQ2AtKqgm+sz0U5
SLu824iuuA==
=mZS8
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to