Your message dated Mon, 19 Jul 2021 18:18:29 +0000
with message-id <[email protected]>
and subject line Bug#991227: fixed in runit 2.1.2-41exp1
has caused the Debian Bug report #991227,
regarding runit: Broken switch from SysVinit - needs hardreset
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
991227: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991227
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: runit
Version: 2.1.2-40
Severity: important
Tags: patch
X-Debbugs-Cc: [email protected]
The fix for #919699 introduced a regression described in #990774: when shutdown,
halt or reboot is called with parameters it does nothing. This includes the -f
flag.
A consequence is that the switch Sysvinit --> runit-init can be broken.
When plain shutdown or reboot are called (for instance by a graphical desktop
env),
SysVinit is told to enter runlevel 0 or 6, but then it expects halt -f or
reboot -f
to finish the job (but they are noop, so the system is left in a wierd state).
When reboot is called the system initate the shutdown process, then stops and
the user can login into emergency shell: from there, only if the user call
again reboot,
the system will complete the shutdown process (after about 15 seconds of
waiting).
If shutdown is called the system initate the shutdown process but then stops:
all
tty's are down, no way to login, and init does not complete the shutdown. From
there
one can only press the reset button.
Runit-init users are not affected only because, when stage3 returns (because
halt -f is a noop)
runit uses it's own internal code to poweroff or reboot.
The switch from systemd is not affected because systemd uses it's own internal
code
to perform the shutdown.
I've already tested that the patch for #990774, attached below,
fix this issue too
patch: (the last two lines with the -r flag are not strictly needed here )
--- ./shutdown.c 2020-01-13 01:07:09.185373016 +0100
+++ ./shutdown-new.c 2021-07-15 14:51:04.482088733 +0200
@@ -134,14 +134,16 @@
}
for (i = 1; i != argc; ++i) {
- if (strcmp(argv[i], "-f"))
+ if (strcmp(argv[i], "-f") == 0)
cfg->force = true;
- if (strcmp(argv[i], "--force"))
+ if (strcmp(argv[i], "--force") == 0)
cfg->force = true;
- if (strcmp(argv[i], "-w"))
+ if (strcmp(argv[i], "-w") == 0)
cfg->wtmp_only = true;
- if (strcmp(argv[i], "--wtmp-only"))
+ if (strcmp(argv[i], "--wtmp-only") == 0)
cfg->wtmp_only = true;
+ if (strcmp(argv[i], "-r") == 0)
+ cfg->action = ACTION_REBOOT;
}
}
-- System Information:
Debian Release: 11.0
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 5.7.0-1-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_FIRMWARE_WORKAROUND, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en
Shell: /bin/sh linked to /bin/dash
Init: runit (via /run/runit.stopit)
Versions of packages runit depends on:
ii libc6 2.31-12
ii sysuser-helper 1.3.5.1
Versions of packages runit recommends:
ii runit-init 2.1.2-41exp1
Versions of packages runit suggests:
ii socklog 2.1.0+repack-4+b1
-- Configuration Files:
/etc/default/runit changed [not included]
/etc/runit/ctrlaltdel changed [not included]
/etc/runit/runsvdir/single/sulogin/run [Errno 2] No such file or directory:
'/etc/runit/runsvdir/single/sulogin/run'
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: runit
Source-Version: 2.1.2-41exp1
Done: Lorenzo Puliti <[email protected]>
We believe that the bug you reported is fixed in the latest version of
runit, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Lorenzo Puliti <[email protected]> (supplier of updated runit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 16 Jul 2021 20:35:34 +0200
Source: runit
Architecture: source
Version: 2.1.2-41exp1
Distribution: experimental
Urgency: medium
Maintainer: Lorenzo Puliti <[email protected]>
Changed-By: Lorenzo Puliti <[email protected]>
Closes: 990774 991227
Changes:
runit (2.1.2-41exp1) experimental; urgency=medium
.
* Set rules-requires-root to no
* Runit-run: drop dependency on runit-systemd | sysvinit-core
* Runit: get rid of ancient transition code in prerm
* Add upstream metadata
* Add support for policy-rc.d hack in invoke-run
* Update invoke-run manpage for policy-rc.d
* Update News files
* Shutdown.c:
- fix wrong command line parsing logic that always
caused a No-Op when any option was given, breaking,
among other things, the init switch from Sysvinit
(Closes: #991227)
- reboot the system with -r flag (Closes: #990774)
* Update shutdown(8) manpage
* Update license and copyright years
Checksums-Sha1:
e52290feea0fe396ce74be74483de65d5d4542fc 2279 runit_2.1.2-41exp1.dsc
e98459ac22e25c51be070f49db09169314815fb0 45748 runit_2.1.2-41exp1.debian.tar.xz
d7f01009ae6cb47e70881c89c59ee03fca4ca1eb 5827
runit_2.1.2-41exp1_source.buildinfo
Checksums-Sha256:
bd40db2fa4a4c4f20305909d5b69885d4b105e532eb3e7a2c7dbbdbee8177a87 2279
runit_2.1.2-41exp1.dsc
44430dc69d5f5da1b6adb1074e5b7a5fda0c30bc252eb86ce18d1f5dca2d7a7a 45748
runit_2.1.2-41exp1.debian.tar.xz
dbd0ffe9fbcf96653dac228a388edde060a1feb79176b69512e0a6b35e7d5908 5827
runit_2.1.2-41exp1_source.buildinfo
Files:
5f2d5b2fa939229c5014ac0bdf843637 2279 admin optional runit_2.1.2-41exp1.dsc
554abfa0fa7981113e75722c2be55664 45748 admin optional
runit_2.1.2-41exp1.debian.tar.xz
6f3a4dae82342f8a3c276fd7757f2f52 5827 admin optional
runit_2.1.2-41exp1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAmD1v5UACgkQweDZLphv
fH7nkBAAwOznMVXykm/k4p3w18VayMmbpH1u35YaBn2LYaeUscg08Xw2tGoGWVSf
XnnjqIUbMMwrzoUw76aHJaEtqqssmRvs12unHnb2BVEw0xHAIMVdnEVvdY+IJ4I7
11vLYNmKgZUx2Hz+78P8KHj3/o766lCJkXvV0ELCUT3GmVr37q2aaXrVk58NgWB5
Ik0eMaxPEkiV6bB63rufYPqkf3BD+kIPcGtRMwAZlYO+LoUnbenIfll+6Fv29WRa
f0eGV0Fu0UzFfUzbb2faqsV1aos+ekqn5n2LL6I7x+bZwnnaVa8ZSckQtV6s42wg
eHdyvJwiDql7eJ6GU/ew4T8iD/pI6SOcNs15m6KRlfVC9k7v5dX+z4OGKUCZKIb7
HemuSVeiAu+AkHmtjMyZe5EAix7/rahReMWmIuXsZqrr+UWwPabSsu9wkXBlBiW+
Otb7lueaOmsiXB07HNV1NAQ0nrY2B1zJ0lcrQzgJpgOfMnJbnXfe4dB4J+sw4SCJ
bBxWSc8yGHqPrq46cXeBdagCKapBXSHvLj3VS/zMuIpzdBWLOS0bULhb7o+2BuPa
P+/8gpdmKExj80k7C5lNAZDFtrA8A4sbYS1hIXuUBLdNwbc27fXzhAifCj8QxHpz
xCth3Bq10lnDjsIxlW1VzOeefNkxQpf9mQGd0RJuF3zGFOx9NJ8=
=lbGu
-----END PGP SIGNATURE-----
--- End Message ---
