Your message dated Sun, 25 Jul 2021 08:48:30 +0000
with message-id <[email protected]>
and subject line Bug#946378: fixed in squashfs-tools 1:4.5-1
has caused the Debian Bug report #946378,
regarding squashfs-tools: xattr-related non-determinism ⇒ non-reproducible
SquashFS
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
946378: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946378
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: squashfs-tools
Version: 1:4.4-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: reproducible-builds
Hi,
as reported on https://github.com/plougher/squashfs-tools/issues/78,
mksquashfs sometimes produces non-reproducible SquashFS when xattrs
are used in the input directory. This causes trouble for Tails.
Unfortunately I did not manage to create a minimal reproducer for the
problem, but the attached patch fixes the problem for me in my
real-world scenario. This patch has been submitted upstream 2 years
ago¹; I'm trying to encourage upstream to review it but I don't know
how long it will take, so it would be sweet if we could have this
trivial fix in Debian earlier :)
[1] https://github.com/plougher/squashfs-tools/pull/39
Cheers,
--
intrigeri
commit ad4b8f0aad4c659c1e437ed94897230cbdb9800d
Author: Henrik Grindal Bakken <[email protected]>
Origin: https://github.com/plougher/squashfs-tools/pull/39/commits/ad4b8f0aad4c659c1e437ed94897230cbdb9800d
Date: Wed Dec 6 13:18:51 2017 +0100
xattr: Initialize header to avoid valgrind warning
The 'unused' field was written uninitialized to disk. This introduces
a randomness into the file system, and it also ends up as a valgrind
warning.
--- a/squashfs-tools/xattr.c
+++ b/squashfs-tools/xattr.c
@@ -425,7 +425,7 @@
int i, avail_bytes;
char *datap = data_cache;
long long start_bytes = bytes;
- struct squashfs_xattr_table header;
+ struct squashfs_xattr_table header = {};
if(xattr_ids == 0)
return SQUASHFS_INVALID_BLK;
--- End Message ---
--- Begin Message ---
Source: squashfs-tools
Source-Version: 1:4.5-1
Done: Laszlo Boszormenyi (GCS) <[email protected]>
We believe that the bug you reported is fixed in the latest version of
squashfs-tools, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Laszlo Boszormenyi (GCS) <[email protected]> (supplier of updated squashfs-tools
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 25 Jul 2021 09:53:24 +0200
Source: squashfs-tools
Architecture: source
Version: 1:4.5-1
Distribution: experimental
Urgency: medium
Maintainer: Laszlo Boszormenyi (GCS) <[email protected]>
Changed-By: Laszlo Boszormenyi (GCS) <[email protected]>
Closes: 946378 991473
Changes:
squashfs-tools (1:4.5-1) experimental; urgency=medium
.
* New upstream release (closes: #991473):
- fix xattr-related non-determinism (closes: #946378).
* Update 0001-kfreebsd.patch .
* Update debhelper level to 13 .
* Update Standards-Version to 4.5.1 .
Checksums-Sha1:
68b5130aa00e5554eeaeff9863f69fdd6b6eb8c7 1891 squashfs-tools_4.5-1.dsc
19d10fcb77f09c4615ecb2fcf6b005c2d6b8469d 250471 squashfs-tools_4.5.orig.tar.gz
0b5759abdf2934341e0b6dab0397371db7a46482 12032
squashfs-tools_4.5-1.debian.tar.xz
Checksums-Sha256:
156183b6c8942d20751e446a044766ad47621a658c5c24a7d1811706e08a2f5d 1891
squashfs-tools_4.5-1.dsc
b9e16188e6dc1857fe312633920f7d71cc36b0162eb50f3ecb1f0040f02edddd 250471
squashfs-tools_4.5.orig.tar.gz
3544139b7247ed0e5ea48312aa1190d928b2d5c0cca18747b047a1a8dd49d786 12032
squashfs-tools_4.5-1.debian.tar.xz
Files:
e153150e272c13af293744db77317094 1891 kernel optional squashfs-tools_4.5-1.dsc
ef7093fe887112443b8d18af5eb77cf2 250471 kernel optional
squashfs-tools_4.5.orig.tar.gz
adcecf679e961eb5e8b7959526c8baf5 12032 kernel optional
squashfs-tools_4.5-1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEfYh9yLp7u6e4NeO63OMQ54ZMyL8FAmD9IRIACgkQ3OMQ54ZM
yL85DxAAiIhJYtdnxe1gZ3ojjJ961CoCpdgzUAgSZ3e3peleSge/ELbmDEQyRLz/
Srdd8AT8g1RAk1RkACoQAw37ZQj6onn51u6TIIoU6ylM+J+US4VywJ/4IIUc9uUG
260KMSUWMyu9dOU07c0u+clDtiDYtDy9pyVIXZMDH9o1PxPwQxO2mbRUB4j6VlIG
4D4087rOqbs8pWC1HEQX3z7lVuv6wvnk2xGPbCgziPQByTCcp+Oe5H2xVL8TAvjI
VZxLL6EpxIDMPGLmVDhDYbEbUWHue02BKRWSbWZX6+eCzGAgSC5IOQhL6R3qiX+e
tYmDRALNDVWF+SHlPtAveXgCrEupEdmi6UKlXNe9l1rbfkyaaLkO3iJDjwf7/i0z
bH8yVPtPXeGXV7Jq0ZuGFpQOKnJSeq9PwVC4e8lkStcZaJW5pxrvCwk21rtiJjRO
aO6TQcygai3C1lksQYQuvk9M2YB4Zyv1vBZiPoNjp9/P2xOszehyapRBLPOTSzbG
XBk0gu+l2jdAmFb8xBQ4Yx2Xi5/VkVzUfLhZEcTlN/T6WDhyCz+YGMcEon+S2uac
enpSOEloWNnkpIxqQaN7FEJQoz6UaInIqdQKxth6N+VK4NsfHHblBH09iKZ9w5Gl
TNZwBiAR1YAuiaj8RQkyj7MLoAXecb+DtWkvpySTll37y0SXh54=
=IUp3
-----END PGP SIGNATURE-----
--- End Message ---
