Your message dated Sat, 07 Aug 2021 16:03:28 +0000
with message-id <[email protected]>
and subject line Bug#984629: fixed in grc 1.13-1
has caused the Debian Bug report #984629,
regarding grc added colourify aliases
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
984629: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=984629
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: grc
Version: 1.12-1

The grc package has suddenly added aliases to colourify several commands.
Worse, it creates some truly awful (e.g. white on green) and completely
useless and unreadable colour combinations (e.g. blue on black for several
commands, and black on black for docker container and image IDs).

I don't know exactly what version of the grc package started this (I only
noticed last night after rebooting my machines for a kernel upgrade), but this
should:

1. Be optional/configurable - e.g. with a "GRC_ALIASES=[true | false]" setting
in /etc/default/grc

IMO the default should be 'false' (for the principle of least surprise) but
that doesn't really matter as long as there is a way for the user to choose.

I have grc installed to colourise logs and other output when I want to. I wasn't
expecting to have common commands suddenly have garish and hard-to-read colours.

BTW, depending on order of execution, these aliases may also over-ride aliases
already set by the user/system-admin.


2. Not assume a white terminal background.  Either choose colours that work
on both white and black backgrounds, or have a "light" and a "dark" set of
colours.

A "light" and "dark" set could be implemented by having a /usr/share/grc/light
and /usr/share/grc/dark subdirectories (which should all be conffiles as
noted below).

The /etc/profile.d/grc.sh script could read a setting in /etc/default/grc
(e.g. GRC_ALIASES=[light|dark|none]), and symlink the appropriate colour set
into /usr/share/grc/ - e.g 

    if [ -n "$GRC_ALIASES" ] && [ "$GRC_ALIASES" != "none" ] ; then
        ln -sf "/usr/share/$GRC_ALIASES"/conf.* /usr/share/grc/
    fi

A setting of "none" should delete all symlinks in /usr/share/grc.  e.g.

    if [ -z "$GRC_ALIASES" ] || [ "$GRC_ALIASES" = "none" ] ; then
        find /usr/share/grc/ -maxdepth 1 -type l -delete
    fi


3. List /usr/share/grc/conf.* as conffiles.  None of them are currently
conffiles in the package - this means that any local customisations (like
fixing black on black) will be reset every time grc is upgraded.


craig

PS: I had to undo this on all my systems by running (in every terminal and
tmux window...dozens of shells after rebooting them for a new kernel and
re-starting my usual terminal windows and tmux sessions, so this was very
tedious):

    unalias as blkid colourify configure df diff dig docker docker-compose 
docker-machine du env fdisk findmnt free g++ gas gcc getsebool head id ifconfig 
ip iptables journalctl kubectl ld lsblk lsof lspci make mount netstat ping ps 
semanage sockstat ss tail traceroute traceroute6

I also had to edit /etc/profile.d/grc.sh on all machines to prevent it from
happening again:

- if [ "$TERM" != dumb ] && [ -n "$GRC" ]; then
+ if [ 0 -eq 1 ] ; then

--- End Message ---
--- Begin Message ---
Source: grc
Source-Version: 1.13-1
Done: Radovan Garabík <[email protected]>

We believe that the bug you reported is fixed in the latest version of
grc, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Radovan Garabík <[email protected]> (supplier of updated grc 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 07 Aug 2021 17:37:55 +0200
Source: grc
Binary: grc
Architecture: source all
Version: 1.13-1
Distribution: unstable
Urgency: low
Maintainer: Radovan Garabík <[email protected]>
Changed-By: Radovan Garabík <[email protected]>
Description:
 grc        - generic colouriser for everything
Closes: 984629
Changes:
 grc (1.13-1) unstable; urgency=low
 .
   * do not add sh aliases unless explicitly allowed in /etc/default/grc
     (closes: #984629)
   * several minor improvements
Checksums-Sha1:
 8a5dda812a497cfb03f70e1fd078b5985e247598 1644 grc_1.13-1.dsc
 e058814e396e9829ac6fda591a4c9c6f68cfc472 49224 grc_1.13.orig.tar.gz
 3606d464cc23a28b62330db0efd5ea25f355ec48 4736 grc_1.13-1.debian.tar.xz
 f3a8f67e5989df0ee72836cd26d814a9f9b471c3 47168 grc_1.13-1_all.deb
 c3a2206828dad5f0fd2d80b2dc58f0c4bdff5bf7 6760 grc_1.13-1_amd64.buildinfo
Checksums-Sha256:
 eb8720e8c26f48d714679cf8fb8ce0eb6538c33f257eeb5eb9139ebd4ba7d399 1644 
grc_1.13-1.dsc
 a7b10d4316b59ca50f6b749f1d080cea0b41cb3b7258099c3eb195659d1f144f 49224 
grc_1.13.orig.tar.gz
 cd479f596f1130660877933917898455788b71eff33d7397ff0952e01ce9a0fb 4736 
grc_1.13-1.debian.tar.xz
 ff384d2bdf05cd2681bb0c4fc23b551bbc19e32942a3b71de6925fa79fab2300 47168 
grc_1.13-1_all.deb
 e0e1c77bad7abcadd1c4002327562654231d6175094800819d376f1993e9acb8 6760 
grc_1.13-1_amd64.buildinfo
Files:
 50f9597b6ff20c4e5ecf0df896488965 1644 text optional grc_1.13-1.dsc
 9800a42aa081dd64dbaaf928bb5796fe 49224 text optional grc_1.13.orig.tar.gz
 d531d7a3e7e2f1c5073bd19445f690dc 4736 text optional grc_1.13-1.debian.tar.xz
 95eb9faf336bb6b58322c38893ee07ed 47168 text optional grc_1.13-1_all.deb
 739686f2688a64ef0d8791773e57dc25 6760 text optional grc_1.13-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwbjRPT3132UMRk7uaFakpkCvP9MFAmEOqq4ACgkQaFakpkCv
P9N38A/8DKbmvgMrwIaIBAfIB84qIr2uMP6pekI8N5FRPIMKTZyZ+0cdxvPW9mCt
E6J8JV/ZBZP4geu+Yaqj+2+eKs83vJrmVPcgmAYEgMm+IGHTWWLf5pBDoDhFTJDJ
tsaDSC4BEfmrzcPfnC4fhhxQmxQKhUfyQ4q9e5gW0Qf2n2RhReM3+O6v5y4FzPH3
+GtaRe2aVWRcXfhPA5Ra7yciKXWtuBPcD8gR3f1fGD1r7/bHC1gv8fv8KwzKA3og
8gtuyGZfCRtoMa+OfhFnhGcE37NDefz8po/TLeh7bzBvyApItOwE/CsMcV9UOHJd
Hg6BYZsI5G+Cnm5kkJuA2uZL+LU3Us4MmiwayACX5CjXpfdxaiUHRe/YG73nGF4y
t8wc0u2t71AWkMyZTYWAM8hEQbMe6hmCk+JjkxPwVxqsSC7BAoVOQC2dOI1MokNU
qN2ALI7ZRR6SiDiYF2ggBItUPJVyWF8UdoKx2CYQ5L3qDlzGLaZIPnBD68a95Gl0
bJ/lMkfvsJB9+eHKgAZv5iaYm7CsmXzx+942LvDwjJbmJLo17006t5922DYk0dWt
RoS5v3sZfQZV1jKLOUEEnzsy/rbaADeYCC7wVWCQVQDfmo6oBVEzz3ZDFvcACYSx
mJSGVfIPCFKB3enx4iY1/NFnOuXV2U+RLceqrmVRXIowTSnNp/A=
=aqM3
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to