Your message dated Sun, 15 Aug 2021 08:16:29 +0000 with message-id <[email protected]> and subject line Bug#992032: fixed in weechat-matrix 0.3.0-1 has caused the Debian Bug report #992032, regarding weechat-matrix: wrapper cannot 'disable' to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 992032: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=992032 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: weechat-matrix Severity: normal Hi, The command 'weechat-matrix-wrapper enable' sets symbolic links as expected, but the corresponding weechat-matrix-wrapper disable does not remove them. IInstead, it produces this error message: $ weechat-matrix-wrapper disable Disabling Weechat-matrix Weechat-matrix installed into /home/lechner/.weechat/python/matrix, unable to continue Upon inspection, the issue seems to relate to those lines in the wrapper: if [ -d $DESTINATION/matrix ]; then echo "Weechat-matrix installed into $DESTINATION/matrix, unable to continue" exit 1 fi For the linked directory created by 'enable' the removal should proceed, but the condition returns true and aborts. Below is a patch that checks instead that both paths are links (which is what 'enable' installed). The patch was tested locally. Thank you! Kind regards Felix Lechner * * * --- weechat-matrix-wrapper 2021-08-09 06:13:05.820766987 -0700 +++ /usr/bin/weechat-matrix-wrapper 2021-08-09 06:35:44.739926938 -0700 @@ -20,24 +20,26 @@ if [ "$ACTION" = "enable" ]; then echo "Enabling Weechat-matrix" if [ -L $DESTINATION/matrix ]; then - echo "Weechat-matrix already enabled" + echo "Weechat-matrix was already enabled" exit 0 fi if [ -d $DESTINATION/matrix ]; then - echo "Weechat-matrix installed into $DESTINATION/matrix, unable to continue" + echo "$DESTINATION/matrix exists, unable to continue" exit 1 fi ln -s $SOURCE/matrix $DESTINATION/matrix ln -s $SOURCE/matrix.py $DESTINATION/autoload/matrix.py elif [ "$ACTION" = "disable" ]; then echo "Disabling Weechat-matrix" - if [ -d $DESTINATION/matrix ]; then - echo "Weechat-matrix installed into $DESTINATION/matrix, unable to continue" + if [ ! -L $DESTINATION/matrix ]; then + echo "$DESTINATION/matrix is not a link, unable to continue" exit 1 fi - if [ -L $DESTINATION/matrix ]; then - rm $DESTINATION/matrix $DESTINATION/autoload/matrix.py + if [ ! -L $DESTINATION/autoload/matrix.py ]; then + echo "$DESTINATION/autoload/matrix.py is not a link, unable to continue" + exit 1 fi + rm -f $DESTINATION/matrix $DESTINATION/autoload/matrix.py else showhelp fi
--- End Message ---
--- Begin Message ---Source: weechat-matrix Source-Version: 0.3.0-1 Done: Kyle Robbertze <[email protected]> We believe that the bug you reported is fixed in the latest version of weechat-matrix, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Kyle Robbertze <[email protected]> (supplier of updated weechat-matrix package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Sun, 15 Aug 2021 09:14:25 +0200 Source: weechat-matrix Architecture: source Version: 0.3.0-1 Distribution: unstable Urgency: medium Maintainer: Kyle Robbertze <[email protected]> Changed-By: Kyle Robbertze <[email protected]> Closes: 992032 Changes: weechat-matrix (0.3.0-1) unstable; urgency=medium . * Fix disable call for wrapper script (Closes: #992032) * New upstream version 0.3.0 * Bump standards-version to 4.5.1 (no change) Checksums-Sha1: e2312b4d1463bd93d1341bbcb9acf7e591f415ac 2070 weechat-matrix_0.3.0-1.dsc 5a1e4e05d09670a473d76a34870bbd1b70ce321c 87706 weechat-matrix_0.3.0.orig.tar.gz f888cb5213a283758ff0b8dc6cb845deebbbe8e2 3328 weechat-matrix_0.3.0-1.debian.tar.xz 55ecf342978e8859e43fd1cc14b0e7cdd7b01515 7690 weechat-matrix_0.3.0-1_amd64.buildinfo Checksums-Sha256: 79fb523ffc9fccc04f91bc011e18fe33dd3077dd6adcd84d4007b23c1e4debf6 2070 weechat-matrix_0.3.0-1.dsc 4a7942ec976dc6081ebb689cb0dc0f02f8ab9d24121f98c6dcb7f39478251329 87706 weechat-matrix_0.3.0.orig.tar.gz 90f62d76ab3e4d5965f18ca93755fdc2cbde7270efb0a286e4e42ffebea4cdb9 3328 weechat-matrix_0.3.0-1.debian.tar.xz fe2b605c92cc3ef4e1e1ce5b8c7ab3dc8ca3105bc50ae94ccca24899fd5fe766 7690 weechat-matrix_0.3.0-1_amd64.buildinfo Files: dadedf00de87a5635f5ba699a14c7ad6 2070 python optional weechat-matrix_0.3.0-1.dsc 777e4d26560459f5d38136a13e4f470b 87706 python optional weechat-matrix_0.3.0.orig.tar.gz 371b87d2bc60e1f31ca32bd50f76a11c 3328 python optional weechat-matrix_0.3.0-1.debian.tar.xz 3673f69acbad87ad17fb59d5de4fc672 7690 python optional weechat-matrix_0.3.0-1_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEElqWPGCu4+bgcXyczhU8Hvggt8U8FAmEYv64ACgkQhU8Hvggt 8U+SzQ//dmaLsLiMG19WkbXZ7g2KmYUoZx8mS8/edIunqZvBXLF0Y7wxcSez90f8 i+aGGwgJOa5O8841ViYdOcGjdD2D+3s1/SnYMKDi34WaWQU0Q2rV64+vS8adYaPu 81wAaoqyTiMUzv1dbZMuYj12osFcVtQ+RZaEaXqqJadFzJRrsQHbLV9FpO2bKxDf I4r7uKTv9hKTzTF+3QVAk9YOnZrm1A+ZiPsBsep60VomxlP7k9gYTTMXs5Zhvy63 RjVlO4BBiEb+xMrbOOoOSb4NSNh0RTHBysIi69OZJig6eYxq7Qj/EMKTZGZx/vRa piWxJ4Z/BRYQi2ggJl4wlCZn/Xf+TU08EMV2vHtEyecawoL4pMEQqiP8JoqSbL6K 0g5MFRa9xXgGUbALOdtgLUzREb6m59nWtiS6nNVBn9SHtH3CoDmb3v767Z6Is7ua micUQ9zbdYBqg9rm59XO7liyNnxNwIh2so2lK9Jlj5/uxL4t0QI09AeGf99PRDut WEMeClR8+zhtOvBUmOWcNC9XSmsmDJyXtRrzPdHSClUA6CVWoaWLu/KbGPHeCXVR ozJziW4RxnC7tdW5iu//8bVXkx9NndQgOVfp21OhSGGbyB5C0p9brrp1Sfcri7Hp 88lbQQBqcViD0t2Wwo3900iOF1WD89qk7OEyQ394F/1DTSnEHi0= =ISxB -----END PGP SIGNATURE-----
--- End Message ---
