Your message dated Sun, 28 May 2006 14:04:41 -0700 with message-id <[EMAIL PROTECTED]> and subject line Bug#364024: fixed in libgd2 2.0.33-4 has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---Package: libgd2-xpm Version: 2.0.33-3 Severity: important I found an off-by-one bug that repeatedly causes segfaults: $ cat test_segfault.c #include <gd.h> int main() { gdImagePtr im = gdImageCreateTrueColor(100,100); int colour = gdTrueColorAlpha(100,100,100,100); gdImageSetAntiAliased(im,colour); gdImageLine(im, 95, 100, 100, 98, gdAntiAliased); return 0; } $ gcc -o test_segfault test_segfault.c -lgd $ ./test_segfault Segmentation fault $ I made a patch that solves the problem. Its attached. thanks, Paul -- System Information: Debian Release: testing/unstable APT prefers testing APT policy: (650, 'testing'), (600, 'unstable') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.15.20060419 Locale: LANG=en_AU, LC_CTYPE=en_AU (charmap=ISO-8859-1) Versions of packages libgd2-xpm depends on: ii libc6 2.3.6-7 GNU C Library: Shared libraries ii libfontconfig1 2.3.2-5.1 generic font configuration library ii libfreetype6 2.1.10-1 FreeType 2 font engine, shared lib ii libjpeg62 6b-12 The Independent JPEG Group's JPEG ii libpng12-0 1.2.8rel-5 PNG library - runtime ii libx11-6 6.9.0.dfsg.1-6 X Window System protocol client li ii libxpm4 6.9.0.dfsg.1-6 X pixmap library ii zlib1g 1:1.2.3-11 compression library - runtime libgd2-xpm recommends no packages. -- no debconf information--- gd.c 2006-04-21 10:58:02.000000000 +0800 +++ gd.c 2006-04-21 10:58:18.000000000 +0800 @@ -3095,7 +3095,9 @@ /* TBB: set the last pixel for consistency (<=) */ while ((x >> 16) <= x2) { gdImageSetAAPixelColor(im, x >> 16, y >> 16, col, (y >> 8) & 0xFF); - gdImageSetAAPixelColor(im, x >> 16, (y >> 16) + 1,col, (~y >> 8) & 0xFF); + // the +1 can push it past the image bounds + if ((y >> 16) + 1 <= im->cy2) + gdImageSetAAPixelColor(im, x >> 16, (y >> 16) + 1,col, (~y >> 8) & 0xFF); x += (1 << 16); y += inc; } @@ -3116,6 +3118,9 @@ /* TBB: set the last pixel for consistency (<=) */ while ((y>>16) <= y2) { gdImageSetAAPixelColor(im, x >> 16, y >> 16, col, (x >> 8) & 0xFF); + // the +1 can push it past the image bounds + if ((x >> 16) + 1 <= im->cx2) + gdImageSetAAPixelColor(im, x >> 16, (y >> 16) + 1,col, (~y >> 8) & 0xFF); gdImageSetAAPixelColor(im, (x >> 16) + 1, (y >> 16),col, (~x >> 8) & 0xFF); x += inc; y += (1<<16);
--- End Message ---
--- Begin Message ---Source: libgd2 Source-Version: 2.0.33-4 We believe that the bug you reported is fixed in the latest version of libgd2, which is due to be installed in the Debian FTP archive: libgd-tools_2.0.33-4_powerpc.deb to pool/main/libg/libgd2/libgd-tools_2.0.33-4_powerpc.deb libgd2-noxpm-dev_2.0.33-4_powerpc.deb to pool/main/libg/libgd2/libgd2-noxpm-dev_2.0.33-4_powerpc.deb libgd2-noxpm_2.0.33-4_powerpc.deb to pool/main/libg/libgd2/libgd2-noxpm_2.0.33-4_powerpc.deb libgd2-xpm-dev_2.0.33-4_powerpc.deb to pool/main/libg/libgd2/libgd2-xpm-dev_2.0.33-4_powerpc.deb libgd2-xpm_2.0.33-4_powerpc.deb to pool/main/libg/libgd2/libgd2-xpm_2.0.33-4_powerpc.deb libgd2_2.0.33-4.diff.gz to pool/main/libg/libgd2/libgd2_2.0.33-4.diff.gz libgd2_2.0.33-4.dsc to pool/main/libg/libgd2/libgd2_2.0.33-4.dsc A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Jonas Smedegaard <[EMAIL PROTECTED]> (supplier of updated libgd2 package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Sun, 21 May 2006 09:51:07 +0200 Source: libgd2 Binary: libgd2-noxpm-dev libgd2-noxpm libgd2-xpm libgd2-xpm-dev libgd-tools Architecture: source powerpc Version: 2.0.33-4 Distribution: unstable Urgency: low Maintainer: Jonas Smedegaard <[EMAIL PROTECTED]> Changed-By: Jonas Smedegaard <[EMAIL PROTECTED]> Description: libgd-tools - GD command line tools and example code libgd2-noxpm - GD Graphics Library version 2 (without XPM support) libgd2-noxpm-dev - GD Graphics Library version 2 (development version) libgd2-xpm - GD Graphics Library version 2 libgd2-xpm-dev - GD Graphics Library version 2 (development version) Closes: 350704 358306 360966 364024 Changes: libgd2 (2.0.33-4) unstable; urgency=low . * Have libgd-noxpm-dev provide libgd2-dev (a virtual package since woody). libgd-xpm-dev does not provide it, as the two packages does not provide same shlibdeps info: Both provide same ABI but not same package dependencies, so those requiring XPM support will want to explicitly (build-)depend on that variant. Closes: bug#350704, #358306 (thanks to Daniel Schepler <[EMAIL PROTECTED]> and Martin Michlmayr <[EMAIL PROTECTED]> for reporting, and to Junichi Uekawa <[EMAIL PROTECTED]> for patience and helpful input). * Use quilt (instead of CDBS builtin patch routines). * Use local cdbs snippet to enable debian-control (semi-)auto-update. * Update local cdbs snippet buildinfo.mk: + Correct namespace. * Update local cdbs snippet copyright-check.mk: + Correct namespace. + Treat all found files as non-binary. + Broaden scan to also look for "(c)" by default. + Make egrep options configurable. * Semi-auto-update debian/control (nothing remarkable). * Semi-auto-update debian/copyright_hints (nothing remarkable). * Renumber and unfuzz patches, and add debian/patches/README documenting the new numbering scheme. * Add patch 1003 fixing an antialiasing segfault. Closes: bug#364024 (thanks to Paul <[EMAIL PROTECTED]>). * Add patch 1004 improving antialiasing lines at image edges (thanks to Paul <[EMAIL PROTECTED]>). * Add patch 1005 to more sanely bail out on missing or wrong data, and include config.h also for tools and examples. This closes: bug#360966 (thanks to the Graphviz project were these was extracted from, and to Matthias Klose <[EMAIL PROTECTED]> reporting it). Files: f2916ba86d6c70fb0ccbc60d09f504c5 965 libs optional libgd2_2.0.33-4.dsc dac82a55da73625fbbfa698f79979e60 263033 libs optional libgd2_2.0.33-4.diff.gz d08b77df1fe1c1bea574555665d19e73 152104 graphics optional libgd-tools_2.0.33-4_powerpc.deb 71317ade20914377346bd98db516942b 344706 libdevel optional libgd2-xpm-dev_2.0.33-4_powerpc.deb 1c563d33ccd73032203ee8fa54a4b230 342818 libdevel optional libgd2-noxpm-dev_2.0.33-4_powerpc.deb 0b53a3a40291225e174c807cde9baf63 202348 libs optional libgd2-xpm_2.0.33-4_powerpc.deb c12efe693cc4b995dc129f4d86cbc1e8 200746 libs optional libgd2-noxpm_2.0.33-4_powerpc.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) iD8DBQFEef/Xn7DbMsAkQLgRAsibAJ4li4iOjLTqZwweHE7BtU6Yfb8NgACbBCMj PYs71ReGqMN+XJ/3cvMf0X4= =lUE3 -----END PGP SIGNATURE-----
--- End Message ---
