Your message dated Fri, 08 Oct 2021 12:52:30 +0000
with message-id <[email protected]>
and subject line Bug#839082: Removed package(s) from unstable
has caused the Debian Bug report #914936,
regarding netcf: reproducible build (usrmerge): Embeds full path to ifup/ifdown 
found via PATH
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
914936: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=914936
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: netcf
Version: 0.2.8-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: usrmerge

Dear Maintainer,

The reproducible build spotted a difference in your package when
built on a usrmerged system vs a non-merged system:
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/netcf.html

It seems a few files contains the full path of 'ifup' and 'ifdown' found
via AC_PROG_PATH during build.

Since PATH defaults to contain /usr/sbin before /sbin the found path will
be /usr/sbin/if{up,down} on a usrmerged system, since both paths are
essentially the same thing there. This is however not desirable on
a non-merged system where it needs to be /sbin/if{up,down}.

The attached patch fixes the problem by explicitly specifying
the default path via IFUP and IFDOWN variable passed to configure
as documented in AC_PROG_PATH documentation.

(This is likely a good idea either way, since otherwise hypothetical
problems could happen for users building on their system with
/usr/local/bin/... or ~/bin/....)

An alternative way to fix this:
You're already explicitly appending :sbin to $PATH in configure.ac.
You could prepend instead of append and that should thus make
the tools be found via the path that's desired here.
This feels a bit like taking a chance to me though, so I still think
explicitly passing the correct path is the better thing to do.

Regards,
Andreas Henriksson
diff -Nru netcf-0.2.8/debian/changelog netcf-0.2.8/debian/changelog
--- netcf-0.2.8/debian/changelog        2015-09-23 22:46:21.000000000 +0200
+++ netcf-0.2.8/debian/changelog        2018-11-28 22:11:09.000000000 +0100
@@ -1,3 +1,11 @@
+netcf (1:0.2.8-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Pass IFUP=/sbin/ifup and IFDOWN=/sbin/ifdown arguments to configure
+    - this fixes reproducible build issue on merged-usr vs non-merged.
+
+ -- Andreas Henriksson <[email protected]>  Wed, 28 Nov 2018 22:11:09 +0100
+
 netcf (1:0.2.8-1) unstable; urgency=medium
 
   * Import new upstream 2.8.0
diff -Nru netcf-0.2.8/debian/rules netcf-0.2.8/debian/rules
--- netcf-0.2.8/debian/rules    2014-08-28 22:21:45.000000000 +0200
+++ netcf-0.2.8/debian/rules    2018-11-28 22:11:06.000000000 +0100
@@ -1,7 +1,7 @@
 #!/usr/bin/make -f
 
 DEB_BUILD_PARALLEL = yes
-DEB_CONFIGURE_EXTRA_FLAGS := --with-driver=debian
+DEB_CONFIGURE_EXTRA_FLAGS := --with-driver=debian IFUP=/sbin/ifup 
IFDOWN=/sbin/ifdown
 
 LDFLAGS += -Wl,--as-needed
 

--- End Message ---
--- Begin Message ---
Version: 1:0.2.8-1.1+rm

Dear submitter,

as the package netcf has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/839082

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
[email protected].

Debian distribution maintenance software
pp.
Bastian Blank (the ftpmaster behind the curtain)

--- End Message ---

Reply via email to