Your message dated Tue, 19 Oct 2021 12:49:43 +0000 with message-id <[email protected]> and subject line Bug#987755: fixed in r-cran-rpf 1.0.9+dfsg-2 has caused the Debian Bug report #987755, regarding r-cran-rpf: FTBFS on mips due to a variable called 'mips' to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 987755: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=987755 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Source: r-cran-rpf Tags: patch Severity: minor Hi, r-cran-rpf FTBFS on mips, since a variable is called 'mips' and on mips 'mips' is expanded to '1'. Lines in question: ba81quad.h:743:31: error: expected ‘,’ or ‘...’ before numeric constant 743 | void setMinItemsPerScore(int mips); | ^~~~ ba81quad.cpp: In member function ‘void ifaGroup::import(const List&)’: ba81quad.cpp:214:6: error: expected unqualified-id before numeric constant 214 | int mips = 1; | ^~~~ ba81quad.cpp:274:4: error: lvalue required as left operand of assignment 274 | mips = as<int>(slotValue); | ^~~~ ba81quad.cpp: At global scope: ba81quad.cpp:426:40: error: expected ‘,’ or ‘...’ before numeric constant 426 | void ifaGroup::setMinItemsPerScore(int mips) | ^~~~ Please consider applying this patch, adding a suffix to the variable 'mips'.diff --git a/src/ba81quad.cpp b/src/ba81quad.cpp index 60d276c..d6419ce 100644 --- a/src/ba81quad.cpp +++ b/src/ba81quad.cpp @@ -211,7 +211,7 @@ void ifaGroup::import(const List &Rlist) paramRows = -1; int pmatCols=-1; - int mips = 1; + int mips_ = 1; int dataRows = 0; NumericVector Rmean; NumericMatrix Rcov; @@ -271,7 +271,7 @@ void ifaGroup::import(const List &Rlist) } else if (strEQ(key, "qpoints")) { qpoints = as<int>(slotValue); } else if (strEQ(key, "minItemsPerScore")) { - mips = as<int>(slotValue); + mips_ = as<int>(slotValue); } else { // ignore } @@ -312,7 +312,7 @@ void ifaGroup::import(const List &Rlist) setLatentDistribution(mean, cov); - setMinItemsPerScore(mips); + setMinItemsPerScore(mips_); if (numItems() != pmatCols) { stop("item matrix implies %d items but spec is length %d", @@ -423,13 +423,13 @@ void ba81NormalQuad::layer::setupOutcomes(ifaGroup &ig) void ba81NormalQuad::setupOutcomes(class ifaGroup &ig) { layers[0].setupOutcomes(ig); } -void ifaGroup::setMinItemsPerScore(int mips) +void ifaGroup::setMinItemsPerScore(int mips_) { - if (numItems() && mips > numItems()) { + if (numItems() && mips_ > numItems()) { stop("minItemsPerScore (=%d) cannot be larger than the number of items (=%d)", - mips, numItems()); + mips_, numItems()); } - minItemsPerScore = mips; + minItemsPerScore = mips_; } void ifaGroup::buildRowMult() diff --git a/src/ba81quad.h b/src/ba81quad.h index 3e60a86..39c5eb1 100644 --- a/src/ba81quad.h +++ b/src/ba81quad.h @@ -740,7 +740,7 @@ private: int minItemsPerScore; double weightSum; public: - void setMinItemsPerScore(int mips); + void setMinItemsPerScore(int mips_); std::vector<bool> rowSkip; // whether to treat the row as NA // workspace
--- End Message ---
--- Begin Message ---Source: r-cran-rpf Source-Version: 1.0.9+dfsg-2 Done: Nilesh Patra <[email protected]> We believe that the bug you reported is fixed in the latest version of r-cran-rpf, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Nilesh Patra <[email protected]> (supplier of updated r-cran-rpf package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Tue, 19 Oct 2021 17:40:16 +0530 Source: r-cran-rpf Architecture: source Version: 1.0.9+dfsg-2 Distribution: unstable Urgency: medium Maintainer: Debian R Packages Maintainers <[email protected]> Changed-By: Nilesh Patra <[email protected]> Closes: 987755 Changes: r-cran-rpf (1.0.9+dfsg-2) unstable; urgency=medium . * Team Upload. * Add patch to fix mips FTBFS (Closes: #987755) Checksums-Sha1: 6136f5e2435f84d9468d7aa4d21e888cf6acfe57 2182 r-cran-rpf_1.0.9+dfsg-2.dsc 4a98f2dc4752b126b55e6a204ba165159edd22c6 4244 r-cran-rpf_1.0.9+dfsg-2.debian.tar.xz a8f23569214d8ad50a7d36db1577faef42e6a714 10827 r-cran-rpf_1.0.9+dfsg-2_amd64.buildinfo Checksums-Sha256: ceb79ff251708c5f5a11c8b65aa3e291791242d90cb1e67a61d1e873c97e0b46 2182 r-cran-rpf_1.0.9+dfsg-2.dsc 923856e8793155202f87b72bf6bf3f7de324fbec068b30322fb951d407b57bf6 4244 r-cran-rpf_1.0.9+dfsg-2.debian.tar.xz df760f370b0dac817c5f94da16e509ee32d5360691dd09f76f4ff8adfac8de4a 10827 r-cran-rpf_1.0.9+dfsg-2_amd64.buildinfo Files: fd38b1350713545a213a1ef952b624ee 2182 gnu-r optional r-cran-rpf_1.0.9+dfsg-2.dsc 351005b5cbb889adf2a1b9d41518d9d6 4244 gnu-r optional r-cran-rpf_1.0.9+dfsg-2.debian.tar.xz 87921872224bfef4414eb165840b1a76 10827 gnu-r optional r-cran-rpf_1.0.9+dfsg-2_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iQJGBAEBCgAwFiEEPpmlJvXcwMu/HO6mALrnSzQzafEFAmFuuqoSHG5pbGVzaEBk ZWJpYW4ub3JnAAoJEAC650s0M2nxuz0P/0EJ6bc7sLrhuAgyLse3zbgNwAV/6zKc ocGoY3gifi5GI8SoSBTSyz+t2ARBZN6Jl4QvUlcT1HQnZVKLCjZk3SsrYOmqeRxJ MGBmWc4C2xYarh8k863pjJ2Fqt7CVkdTURo7Bfn2vN+5YL/LyQU9BgaQE5rUgAx2 C/mvX5lX/IUgcQT1wgAHWUdKM5cIpYMUBzN+UNGyfClSiMlXP0Gs9PPMRGKnfxd8 f+DUElSsFq2XDxHHoDhhqoNDMxtL2LfkpmwIZXx5XvV1sesI4qfJfUVhZRilO/GT ch+uXR1zybMAzFVY9oHrFsMF167v/pTW/bHjE71SyKK4gpZL+z4JyDdFdg6JUiW8 IPJULf+1DoqC+dlYjjBjFzQaUU4e854hT6eOIpPJUGPomKMERuRWYAp0FZKC4ka1 +N2V5Mv7JRqYLxDQziQPtXWGmdcmGjiXJKI2YImvJVAo/Y6ZbbesBuJzTTnZabYp MyF3GM6EZLIJJfWSNOd/6FrnXmvaitbTh/alU+lMwZKnKdXw33GBGZ2IXWMUS2hC jWIxklyF4l7g/72xs0bHJEFY11FK2E8dQvHfC4MSzszdnFBSnAOu41DDtFIs/koL rEszLjzhi39l1LnCERD8FZ1iBpAMNvN6QKeqzh+fYy6crPwXRyTQ5rDkZGw7QFCK cu4Euq1qHExb =j1AI -----END PGP SIGNATURE-----
--- End Message ---
