Your message dated Tue, 02 Nov 2021 11:33:28 +0000
with message-id <[email protected]>
and subject line Bug#903684: fixed in agenda.app 0.46-1
has caused the Debian Bug report #903684,
regarding SimpleAgenda 0.44 - No way to add new task or new appointment
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
903684: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=903684
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: agenda.app
Version: 0.44-1
Severity: important
Tags: patch

Patrick CARDONA wrote:
> When I try to add a new task (#t)  - or a new appointment - within
> SimpleAgenda.app, the OK button is disabled in the "Edit task" panel
> and the Store list is empty. So I cannot save anything.

Thanks for reporting this bug, it is easily reproducible on a fresh
installation (simulated by deleting the app defaults and
~/GNUstep/Library/Simplegenda).

In LocalStore -initWithName:, [[self config] objectForKey: ST_FILE]
returns nil so _globalFile ends up the same as _globalPath.  It then
attempts to save the file which is identical to the newly created
directory and that fails, naturally.  Which in turn sets the store as
non-writable in the -write method so you get the OK button disabled.

Riccardo's workaround actually works because adding a local calendar
file explicitly from the Preferences invokes +registerWithName: which
sets the object for that key.

The attached patch works for me.
--- agenda.app-0.44.orig/LocalStore.m
+++ agenda.app-0.44/LocalStore.m
@@ -27,9 +27,11 @@
 {
   self = [super initWithName:name];
   if (self) {
+    ConfigManager *gc = [ConfigManager globalConfig];
+
     _globalPath = [[[NSSearchPathForDirectoriesInDomains(NSLibraryDirectory, 
NSUserDomainMask, YES) lastObject] 
                     stringByAppendingPathComponent:@"SimpleAgenda"] retain];
-    _globalFile = [[_globalPath stringByAppendingPathComponent:[[self config] 
objectForKey:ST_FILE]] retain];
+    _globalFile = [[_globalPath stringByAppendingPathComponent:[[gc 
objectForKey:name] objectForKey:ST_FILE]] retain];
     _globalTaskFile = [[NSString stringWithFormat:@"%@.tasks", _globalFile] 
retain];
     [self read];
   }

--- End Message ---
--- Begin Message ---
Source: agenda.app
Source-Version: 0.46-1
Done: Yavor Doganov <[email protected]>

We believe that the bug you reported is fixed in the latest version of
agenda.app, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Yavor Doganov <[email protected]> (supplier of updated agenda.app package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 18 Oct 2021 22:11:00 +0300
Source: agenda.app
Architecture: source
Version: 0.46-1
Distribution: unstable
Urgency: medium
Maintainer: Debian GNUstep maintainers 
<[email protected]>
Changed-By: Yavor Doganov <[email protected]>
Closes: 903684
Changes:
 agenda.app (0.46-1) unstable; urgency=medium
 .
   * New upstream release:
     + Fixes creation of new task or appointment on first startup
     (Closes: #903684).
   * debian/patches/spelling-fix.patch: Remove; fixed upstream.
   * debian/patches/series: Delete.
   * debian/control (Build-Depends): Switch to the debhelper-compat
     mechanism; bump compat level to 13.  Remove ancient gnustep-make
     version constraint.
     (Rules-Requires-Root): Set to "no".
     (Standards-Version): Set to 4.6.0; no changes needed.
   * debian/compat: Delete.
   * debian/rules (DEB_LDFLAGS_MAINT_APPEND): Don't set anymore, not needed
     with current toolchain.
     (override_dh_auto_configure): Remove override, as above.
     (override_dh_auto_build): Replace messsages=yes with $(verbose) to
     cater for "terse" in DEB_BUILD_OPTIONS.
   * debian/tests/control:
   * debian/tests/testsuite: New files; run the upstream testsuite as
     autopkgtest: this should be sufficient in case of incompatible changes
     in GNUstep and/or libical.
   * debian/SimpleAgenda.desktop: Set icon to the real file in /usr/share
     rather than the symlink in /usr/lib; should fix an AppStream error.
   * debian/copyright: Update copyright years.
Checksums-Sha1:
 9c2f1ea7c2323ca9bfc3a842c3210e1484bd3eb8 2086 agenda.app_0.46-1.dsc
 c5c2f14c54310460ffb58c4a9bee82d5fe6d690d 156586 agenda.app_0.46.orig.tar.gz
 09c6f2f72f4f72b33faf94bf52cc6c785ba8526d 4948 agenda.app_0.46-1.debian.tar.xz
 e3adf8b9bb533e8052e63617d6e3095a446b737a 9041 agenda.app_0.46-1_amd64.buildinfo
Checksums-Sha256:
 6bcc4398e6a95af45fca1b2dabc99b7d7bab014a5979e5c2cdbbd83fae73e8bb 2086 
agenda.app_0.46-1.dsc
 ca9662d44287e8344324472c2a3d3c9ee34b399f5d8c0f4c52a90e1b6985552e 156586 
agenda.app_0.46.orig.tar.gz
 f18179c93f8962d19a18300e109a5a0a98e65890cc3d97f0a706a1fe3b56ad5a 4948 
agenda.app_0.46-1.debian.tar.xz
 7a55085a5eca9546d0136127fdc12e9ca8df4adac22df86efc58e81f1408b269 9041 
agenda.app_0.46-1_amd64.buildinfo
Files:
 31973f653b940beb5b5656d5646d1ae2 2086 gnustep optional agenda.app_0.46-1.dsc
 318eea1bba388fed251d2872eddcf815 156586 gnustep optional 
agenda.app_0.46.orig.tar.gz
 64e508b7bb95f1c316af8864de64d3cf 4948 gnustep optional 
agenda.app_0.46-1.debian.tar.xz
 e81695664fdbe8bb7d0e783c320983b4 9041 gnustep optional 
agenda.app_0.46-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEELuenpRf8EkzxFcNUZR7vsCUn3xMFAmGBHgwACgkQZR7vsCUn
3xPZZQ//RuHGtthv9H3K5IE62OqPWMLHiTR+gh01XuXOE9PERR6Dt5OLFPbcPjBN
ia5Rte6VMzNL4+9Ft1e+ajrcF20nPVw9H+Z9Pnr+SNJU90FtWFJXZ9c5iSMtdjlj
KgkRqjxPWlklpO7ACH5pPRtmjHGVi7KLSKMWBNmG53GFsoktthPrLRJLypkbGbo7
eUJwt0aVcuTfVPm2O+lReZWDzSLynetPin92qbCTvz5wy7J/LsKcZjVN1oDwdCqB
ISdC5JjByRzch5I7+Xy65cBp1oK6buFLVmok+nKKfkdelZY15mjXCxpHasBiKXN5
F++gA4KleSoW3F7q41Pz27E6nEHpVJh9OsdH+bqON8bytw9FYlLdQh7pM5tj3Mo2
s/fIds7RMAOTwUi+7N4Bq/EWYD0kTgVJW8AE6shKsTcWMCu7UiQMJOq5JZHntSH1
BDHo+CPhagKemOLQCvOUQ2ojTNLU9q8lsd+MDU2HF8qKPufjLUioDPW7mQeKwA4S
iq+oQLdmFovkpb/H7OuX4eR+aLq2DsFQb+FhAP5N/nJ0XvoMVl82p/RWjehY7kSQ
oFiDeGg0pKSankwCZWEFCV15rTj9VsfwzOyPLuVWVAhs9ljQMfYBSryVbgdIf7Ol
+LBfDquNCGt7GrbEIlGLuP9DfzUEbpBTz3fAR9Wn39PBg0UDels=
=rE8K
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to