Your message dated Mon, 29 Nov 2021 13:34:20 +0000
with message-id <[email protected]>
and subject line Bug#990236: fixed in golang-github-nicksnyder-go-i18n.v2
2.1.2-1
has caused the Debian Bug report #990236,
regarding Go 1.16 breaks tests for golang-github-nicksnyder-go-i18n.v2
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
990236: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990236
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: golang-github-nicksnyder-go-i18n.v2
Version: 2.1.1-2
When moving to golang 1.16, this package will be broken. The tests check
for a specific error message that has changed in 1.16. The following patch
should fix this error without breaking the test on older version of go:
diff -Nru golang-github-nicksnyder-go-i18n.v2-2.1.1/debian/patches/series
golang-github-nicksnyder-go-i18n.v2-2.1.1/debian/patches/series
--- golang-github-nicksnyder-go-i18n.v2-2.1.1/debian/patches/series
1970-01-01 00:00:00.000000000 +0000
+++ golang-github-nicksnyder-go-i18n.v2-2.1.1/debian/patches/series
2021-06-23 14:04:22.000000000 +0000
@@ -0,0 +1 @@
+update-expected-error-msg.patch
diff -Nru
golang-github-nicksnyder-go-i18n.v2-2.1.1/debian/patches/update-expected-error-msg.patch
golang-github-nicksnyder-go-i18n.v2-2.1.1/debian/patches/update-expected-error-msg.patch
---
golang-github-nicksnyder-go-i18n.v2-2.1.1/debian/patches/update-expected-error-msg.patch
1970-01-01 00:00:00.000000000 +0000
+++
golang-github-nicksnyder-go-i18n.v2-2.1.1/debian/patches/update-expected-error-msg.patch
2021-06-23 14:50:37.000000000 +0000
@@ -0,0 +1,43 @@
+Description: Update expected error message in test
+ As of golang 1.16, the error message from an unclosed bracket in the
text/template
+ go package has changed slightly. One of the tests in this package checks
that
+ error message, so the test must be updated to expect the new message.
+Author: William 'jawn-smith' Wilson <[email protected]>
+Origin: Ubuntu
+Bug-Ubuntu:
https://bugs.launchpad.net/ubuntu/+source/golang-github-nicksnyder-go-i18n.v2/+bug/1930776
+Forwarded: https://github.com/nicksnyder/go-i18n/pull/260
+Last-Update: 2021-06-23
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+Index:
golang-github-nicksnyder-go-i18n.v2-2.1.1/v2/internal/template_test.go
+===================================================================
+---
golang-github-nicksnyder-go-i18n.v2-2.1.1.orig/v2/internal/template_test.go
++++ golang-github-nicksnyder-go-i18n.v2-2.1.1/v2/internal/template_test.go
+@@ -1,6 +1,7 @@
+ package internal
+
+ import (
++ "strings"
+ "testing"
+ "text/template"
+ )
+@@ -45,7 +46,7 @@ func TestExecute(t *testing.T) {
+ template: &Template{
+ Src: "hello {{",
+ },
+- err: "template: :1: unexpected unclosed action
in command",
++ err: "unclosed action",
+ noallocs: true,
+ },
+ }
+@@ -53,8 +54,8 @@ func TestExecute(t *testing.T) {
+ for _, test := range tests {
+ t.Run(test.template.Src, func(t *testing.T) {
+ result, err := test.template.Execute(test.funcs,
test.data)
+- if actual := str(err); actual != test.err {
+- t.Errorf("expected err %q; got %q",
test.err, actual)
++ if actual := str(err); !strings.Contains(str(err),
test.err) {
++ t.Errorf("expected err %q to contain %q",
actual, test.err)
+ }
+ if result != test.result {
+ t.Errorf("expected result %q; got %q",
test.result, result)
--- End Message ---
--- Begin Message ---
Source: golang-github-nicksnyder-go-i18n.v2
Source-Version: 2.1.2-1
Done: Anthony Fok <[email protected]>
We believe that the bug you reported is fixed in the latest version of
golang-github-nicksnyder-go-i18n.v2, which is due to be installed in the Debian
FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Anthony Fok <[email protected]> (supplier of updated
golang-github-nicksnyder-go-i18n.v2 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 29 Nov 2021 05:54:19 -0700
Source: golang-github-nicksnyder-go-i18n.v2
Architecture: source
Version: 2.1.2-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Go Packaging Team <[email protected]>
Changed-By: Anthony Fok <[email protected]>
Closes: 990236 997571
Changes:
golang-github-nicksnyder-go-i18n.v2 (2.1.2-1) unstable; urgency=medium
.
* New upstream version 2.1.2
* Fix filenamemangle error in debian/watch
* Change Section from devel to golang
* Bump Standards-Version to 4.6.0 (no change)
* Mark library package with "Multi-Arch: foreign"
* Update test to new error message in Go 1.16 and newer.
This fixes test error without breaking the test on Go 1.15 and older.
Thanks to William Wilson (Canonical) for the patch!
(Closes: #990236, #997571)
Checksums-Sha1:
c451fa24e7342986692be49e705989affd8f6e0d 2517
golang-github-nicksnyder-go-i18n.v2_2.1.2-1.dsc
5d8ed27d24f06a2fa05f497754e8794e678c5bca 40661
golang-github-nicksnyder-go-i18n.v2_2.1.2.orig.tar.gz
5e5f4c48415d90bbd5890d0ae2a3e800f1b27570 6640
golang-github-nicksnyder-go-i18n.v2_2.1.2-1.debian.tar.xz
109d70aaf7cbcea446107cd7df7826e38d218323 6394
golang-github-nicksnyder-go-i18n.v2_2.1.2-1_amd64.buildinfo
Checksums-Sha256:
240745a82d323763e45e5ecb580554fe53bcf7142ac217e20749a04a895df413 2517
golang-github-nicksnyder-go-i18n.v2_2.1.2-1.dsc
4c1f8febe1ec7e36e0716c3a06c57a2b74980bfeceb4e898e4fdb8b602d87eba 40661
golang-github-nicksnyder-go-i18n.v2_2.1.2.orig.tar.gz
b1a06f2e17fa8dee24f1ede2533df6c7430842bede2213eb5dbe4bd5cb9e467d 6640
golang-github-nicksnyder-go-i18n.v2_2.1.2-1.debian.tar.xz
d7a9eb6a69582e7d19dc0b3c4c330af82c86b7cef77c71d905f14ce677097d81 6394
golang-github-nicksnyder-go-i18n.v2_2.1.2-1_amd64.buildinfo
Files:
78b43308b63db3dff01bec9a18b583ae 2517 golang optional
golang-github-nicksnyder-go-i18n.v2_2.1.2-1.dsc
1baf07d83eec6ec83e9bbfb3af232516 40661 golang optional
golang-github-nicksnyder-go-i18n.v2_2.1.2.orig.tar.gz
32cca841028979cfe592ab8d342e6279 6640 golang optional
golang-github-nicksnyder-go-i18n.v2_2.1.2-1.debian.tar.xz
637a5646c30611c7f6c26c25583f51fd 6394 golang optional
golang-github-nicksnyder-go-i18n.v2_2.1.2-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJEBAEBCAAuFiEEFCQhsZrUqVmW+VBy6iUAtBLFms8FAmGkzmEQHGZva2FAZGVi
aWFuLm9yZwAKCRDqJQC0EsWazzDAD/0bwceHAsKbt/5TCeEru3knF79/FYOS1jft
fSuxaSwPlJ2dqmH6zUsW+LktzeQHBW85L0g7y2gF/zSy3YMR2ZGo39nsFdJ3PwbV
PA7TIa2zP7hsh3bdfwAm4oDJqBa/Yus3Fm0hjJngruQpVf/r11tYeAuev0sYb1HN
70Nla9YP+dt+9/Y1fxN34cVPISmCNyNPaEZ659oDL63lw9pSsmqRzW+4SMVV3i+e
hrnXFCtpKvb/ZDl+PaZbqGFyCmcj81Oasp902/jhxVLV2KF1z3C5Ny5+5xiu0fuA
CMnnwrMyT1g24L3+mRs20H2OIx56CFLSbNA0TmR3x96hv2n7GnzDQ1B68yEQHf6G
p+3J+eGCpQBL6byexlj/I2Yx0ejw6I3tGxnePtQM29nvP+jNyAe6fhN8gLfoysKl
xlH79c7W+NgQl1e5KNVYHsgxAzHTnX3o5xG729U/pZ6/t+Io9xFO9Nw3zm0wl04c
LryvPfSkPVANDfeUGiTm07NPizvmPO+0OMVuFa2qU7m0iSsgxCSrZV9AB15i0aqw
qk2ZNW0FN7qFurE+EyoQYNqHpnv3o4wnn5rui3M0/Zjle15UiMQPA/t8vDk1red1
wjV/md7oa/KRODkYJdPCv8JCwoDW8ak7qpkLLZKM+cxz17CyKiN6gcGtK45jo8jN
vcAPPKVpmQ==
=PGqJ
-----END PGP SIGNATURE-----
--- End Message ---
