Your message dated Thu, 09 Dec 2021 17:03:57 +0000
with message-id <[email protected]>
and subject line Bug#1001357: fixed in memcached 1.6.12+dfsg-3
has caused the Debian Bug report #1001357,
regarding memcached: FTBFS with -O3: uninitialized variable
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1001357: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1001357
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: memcached
Version: 1.6.12+dfsg-2
Severity: minor
Tags: patch
User: [email protected]
Usertags: origin-ubuntu jammy ubuntu-patch
Hi Chris,
On ppc64el in Ubuntu, memcached is failing to build from source because this
Ubuntu port builds with -O3 by default, and at that optimization level, gcc
detects that a couple of variables may be used without being set. I haven't
traced the code to confirm whether this is a false-positive, because it's
easy enough to fix the failure by initializing the variables instead of
overriding the compiler warning (which can be useful for finding real bugs).
Please find attached the patch I've uploaded to Ubuntu for this issue.
Thanks for considering,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru memcached-1.6.12+dfsg/debian/patches/series
memcached-1.6.12+dfsg/debian/patches/series
--- memcached-1.6.12+dfsg/debian/patches/series 2021-11-23 08:59:31.000000000
-0800
+++ memcached-1.6.12+dfsg/debian/patches/series 2021-12-08 16:28:55.000000000
-0800
@@ -3,3 +3,4 @@
0003-Uses-retry-to-wait-up-to-5-seconds-for-the-killed-pr.patch
0005-Source-etc-default-memcached-in-etc-init.d-memcached.patch
0006-restore-systemd-sandboxing.patch
+uninitialized-variables.patch
diff -Nru memcached-1.6.12+dfsg/debian/patches/uninitialized-variables.patch
memcached-1.6.12+dfsg/debian/patches/uninitialized-variables.patch
--- memcached-1.6.12+dfsg/debian/patches/uninitialized-variables.patch
1969-12-31 16:00:00.000000000 -0800
+++ memcached-1.6.12+dfsg/debian/patches/uninitialized-variables.patch
2021-12-08 16:30:48.000000000 -0800
@@ -0,0 +1,29 @@
+Description: fix an error due to use of a possibly uninitialized variable
+ gcc detects that this variable may be used without being initialized. Just
+ initialize it to fix the error.
+Author: Steve Langasek <[email protected]>
+Last-Update: 2021-12-08
+Forwarded: no
+
+Index: memcached-1.6.12+dfsg/logger.c
+===================================================================
+--- memcached-1.6.12+dfsg.orig/logger.c
++++ memcached-1.6.12+dfsg/logger.c
+@@ -269,7 +269,7 @@
+
+ static int _logger_parse_cne(logentry *e, char *scratch) {
+ int total;
+- unsigned short rport;
++ unsigned short rport = 0;
+ char rip[64];
+ struct logentry_conn_event *le = (struct logentry_conn_event *) e->data;
+ const char * const transport_map[] = { "local", "tcp", "udp" };
+@@ -286,7 +286,7 @@
+
+ static int _logger_parse_cce(logentry *e, char *scratch) {
+ int total;
+- unsigned short rport;
++ unsigned short rport = 0;
+ char rip[64];
+ struct logentry_conn_event *le = (struct logentry_conn_event *) e->data;
+ const char * const transport_map[] = { "local", "tcp", "udp" };
--- End Message ---
--- Begin Message ---
Source: memcached
Source-Version: 1.6.12+dfsg-3
Done: Chris Lamb <[email protected]>
We believe that the bug you reported is fixed in the latest version of
memcached, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Chris Lamb <[email protected]> (supplier of updated memcached package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Thu, 09 Dec 2021 08:50:08 -0800
Source: memcached
Built-For-Profiles: nocheck
Architecture: source
Version: 1.6.12+dfsg-3
Distribution: unstable
Urgency: medium
Maintainer: Chris Lamb <[email protected]>
Changed-By: Chris Lamb <[email protected]>
Closes: 1001357
Changes:
memcached (1.6.12+dfsg-3) unstable; urgency=medium
.
* Fix compilation errors under -O3 due to uninitialised variables.
(Closes: #1001357)
* Don't run the whitespace tests.
Checksums-Sha1:
5a2190d3b5fcd90dc99896b04aeb154dba5bf002 2022 memcached_1.6.12+dfsg-3.dsc
c3ad43776c84756db94a2b8fa66967dfc243f918 16564
memcached_1.6.12+dfsg-3.debian.tar.xz
36a076647069ca7edcec1eb20c994803cc18f11e 6453
memcached_1.6.12+dfsg-3_amd64.buildinfo
Checksums-Sha256:
542dd78fe7c6f2bee725a952839b967c63ffd6d2b1e1767b8e0a43017d3219aa 2022
memcached_1.6.12+dfsg-3.dsc
7d682ed54589bc76f8b229e73a564a68ebc5c0cc92c9ad6720d26c6fe1520bee 16564
memcached_1.6.12+dfsg-3.debian.tar.xz
e667c68caf91f9542333b77b9fedc7d79d7b0475e89d133600e80a0c860cf40c 6453
memcached_1.6.12+dfsg-3_amd64.buildinfo
Files:
140d69191482afc64534226e2a39dfc6 2022 web optional memcached_1.6.12+dfsg-3.dsc
f39941e460144bdb99ea6e468621120b 16564 web optional
memcached_1.6.12+dfsg-3.debian.tar.xz
ea76d047ad43a2a5c9e0332e9f569a09 6453 web optional
memcached_1.6.12+dfsg-3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAmGyNAMACgkQHpU+J9Qx
Hljh4g/8Do6LIHDjTUMF13/eWBNxH2x4MKq8atoc3L5CT1UWmn3Az4cG1z3vwvNZ
dvXkAKcH0gphmhYIY/Mz5x/gAV5LWtuaZQMVesAtxM6VeKB/nxhSE6v3U3Z8QUmI
/VWwda4HX2uwjRrunAE6GgfsHiVPL1s/O8GZhOAxIl6s4Po0pWiyC+PQJPC06O/e
xq7jNXB8w+Pj/I11LdLblkNI8Xjvu4fYyVLF1avrJwA5rcOMuKKmPGOZXcDrKXyx
dACIMOOFqnsT3R73SaAZTwHRS2Es/Pd2H1jP2bV/ZfMGVsMI5keScL29iCUyMcO7
pilD4WX5C6qAue8ukRqSdlmMixce9vNddAobCnecPtYfeHBBM+6FqJFZf/8Dq7qP
5TTVTmVgZivWNZVrgYYlC+q51DhrxaKEED5TdNNWONAgFT0NitweECyiND5VVLxt
h/SGFdJI/o/4ujy0vMOZMjGwAhKNTAbn27UwrRQW3+9KeTn3wcQqg9MwU98GmlWD
kNyl3/cKidGwZ6qKD+4ZcOuod/VVzxu8KDGs9feRvBL2tWLXe3traIGaq5wg7YH4
rQwCkMINEwFNW0bmUlvNRd6WzENToGGAotbDC1qwTzzGlld20PByjNo2Tq+qTcLK
z8qQJkv3Kl3qY08kXDbwzsvBxEEgoPO1POCTzkL0mifjDn4t150=
=K0DI
-----END PGP SIGNATURE-----
--- End Message ---
