Your message dated Mon, 13 Dec 2021 23:48:30 -0800
with message-id <[email protected]>
and subject line Re: Bug#1001475: authres: autopkgtest failure with python3.10
has caused the Debian Bug report #1001475,
regarding authres: autopkgtest failure in Ubuntu with TERM unset
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1001475: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1001475
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: authres
Version: 1.2.0-2
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu jammy ubuntu-patch
Hi Scott,
With python3.10, authres's autopkgtests now fail in some environments
(Ubuntu) because python3.10 complains about TERM being set to an invalid
value:
$ TERM=unknown python3.10 -m authres
No entry for terminal type "unknown";
using dumb terminal settings.
$
This can be fixed by just exporting a sane TERM setting in the autopkgtest
as in the attached patch.
Thanks for considering,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru authres-1.2.0/debian/tests/python authres-1.2.0/debian/tests/python
--- authres-1.2.0/debian/tests/python 2019-10-14 14:03:18.000000000 -0700
+++ authres-1.2.0/debian/tests/python 2021-12-10 10:31:20.000000000 -0800
@@ -2,6 +2,7 @@
set -e
+export TERM=linux
for py in $(py3versions -s); do
$py -m authres
done
--- End Message ---
--- Begin Message ---
Thanks for the feedback, Scott. I've made a change now to the Ubuntu
autopkgtest infrastructure that sets a default TERM variable as discussed.
On Fri, Dec 10, 2021 at 08:21:36PM +0000, Scott Kitterman wrote:
>
>
> On December 10, 2021 7:59:15 PM UTC, Steve Langasek
> <[email protected]> wrote:
> >On Fri, Dec 10, 2021 at 01:52:21PM -0500, Scott Kitterman wrote:
> >> On Friday, December 10, 2021 1:34:14 PM EST Steve Langasek wrote:
> >> > Package: authres
> >> > Version: 1.2.0-2
> >> > Severity: important
> >> > Tags: patch
> >> > User: [email protected]
> >> > Usertags: origin-ubuntu jammy ubuntu-patch
> >> >
> >> > Hi Scott,
> >> >
> >> > With python3.10, authres's autopkgtests now fail in some environments
> >> > (Ubuntu) because python3.10 complains about TERM being set to an invalid
> >> > value:
> >> >
> >> > $ TERM=unknown python3.10 -m authres
> >> > No entry for terminal type "unknown";
> >> > using dumb terminal settings.
> >> > $
> >> >
> >> > This can be fixed by just exporting a sane TERM setting in the
> >> > autopkgtest
> >> > as in the attached patch.
> >
> >> > Thanks for considering,
> >
> >> I guess the patch is fine (harmless), but can you explain why it's needed
> >> for
> >> Ubuntu? In Debian the tests pass with python3.10 as a supported version:
> >
> >> https://ci.debian.net/packages/a/authres/unstable/amd64/
> >
> >> I also ran it locally and it passed.
> >
> >> I have a number of other packages with similar autopkgtests and I haven't
> >> seen
> >> bugs on them yet (maybe because you are filing in alphabetical order).
> >
> >Yes, I'm looking at these alphabetically, this is the first one I've tried
> >to patch for this particular issue.
> >
> >> Where does TERM=unknown come from? Could Ubuntu perhaps just not do that?
> >
> >In fact, I don't know where it comes from. There is code in autopkgtest to
> >re-export a TERM setting from the host into a VM, but I don't know where the
> >TERM=unknown comes from initially.
> >
> >This has been a difference between Ubuntu and Debian autopkgtest
> >infrastructure since Debian first stood up ci.debian.net, I think. It's
> >true we could change the code to force a sane TERM by default, and I can't
> >think of any reason that NOT doing so is improving test fidelity, since
> >users running autopkgtests locally are also not likely to be running with an
> >invalid $TERM.
>
> I think that would be a better solution than patching all the tests. I don't
> think this has anything to do with python3.10.
>
> Scott K
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
signature.asc
Description: PGP signature
--- End Message ---
