Your message dated Tue, 28 Dec 2021 19:19:05 +0000
with message-id <[email protected]>
and subject line Bug#960607: fixed in python-watcherclient 3.3.0-3
has caused the Debian Bug report #960607,
regarding python-watcherclient: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
960607: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=960607
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: python-watcherclient
Version: 3.0.0-2
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: buildpath
X-Debbugs-Cc: [email protected]

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
python-watcherclient could not be built reproducibly.

This is because the documentation generates automatic documentation for the 
"main()" entrypoint method's arguments, one of which is "sys.argv". During 
document generation this results in documentation examples like:

   def main(argv=['-b', 'html', 'doc/source', 
'«ABSOLUTE_BUILD_DIR»/debian/python-watcherclient-doc/usr/share/doc/python-watcherclient-doc/html']):

… etc. Patch attached that sets "None" instead but retains the existing
fallback logic.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-
--- a/debian/patches/reproducible-build.patch   1970-01-01 01:00:00.000000000 
+0100
--- b/debian/patches/reproducible-build.patch   2020-05-14 15:19:04.164095091 
+0100
@@ -0,0 +1,17 @@
+Description: Make the build reproducible
+Author: Chris Lamb <[email protected]>
+Last-Update: 2020-05-14
+
+--- python-watcherclient-3.0.0.orig/watcherclient/shell.py
++++ python-watcherclient-3.0.0/watcherclient/shell.py
+@@ -203,7 +203,9 @@ class WatcherShell(app.App):
+             LOG.info("END return value: %s", ret_val)
+ 
+ 
+-def main(argv=sys.argv[1:]):
++def main(argv=None):
++    if argv is None:
++        argv = sys.argv[1:]
+     watcher_app = WatcherShell()
+     return watcher_app.run(argv)
+ 
--- a/debian/patches/series     1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/series     2020-05-14 15:19:03.204087033 +0100
@@ -0,0 +1 @@
+reproducible-build.patch

--- End Message ---
--- Begin Message ---
Source: python-watcherclient
Source-Version: 3.3.0-3
Done: Thomas Goirand <[email protected]>

We believe that the bug you reported is fixed in the latest version of
python-watcherclient, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Goirand <[email protected]> (supplier of updated python-watcherclient 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 28 Dec 2021 19:37:59 +0100
Source: python-watcherclient
Architecture: source
Version: 3.3.0-3
Distribution: unstable
Urgency: medium
Maintainer: Debian OpenStack <[email protected]>
Changed-By: Thomas Goirand <[email protected]>
Closes: 960607
Changes:
 python-watcherclient (3.3.0-3) unstable; urgency=medium
 .
   * Add reproducible-build.patch (Closes: #960607).
Checksums-Sha1:
 73ed332f091748cdf69f0443fe543098841bbf80 2695 python-watcherclient_3.3.0-3.dsc
 e6fcc71892159502973f0bf2df73d01aa7728361 4640 
python-watcherclient_3.3.0-3.debian.tar.xz
 ee3baef19ccdec46695be02a1bb1dcaa48a5547d 12957 
python-watcherclient_3.3.0-3_amd64.buildinfo
Checksums-Sha256:
 94b9006269060eedb223e1c3d75fb50118d3626d74c66410eba7265bc9dc9cd5 2695 
python-watcherclient_3.3.0-3.dsc
 dce15a9eb63370e29aa29c276739672c352a67016391777e4184cd91430a474c 4640 
python-watcherclient_3.3.0-3.debian.tar.xz
 799a464b92174439119981667767d6c784cbbcfedd6c1c72f040e08d700c8f38 12957 
python-watcherclient_3.3.0-3_amd64.buildinfo
Files:
 e7bc27fc02581c91e8581ef6dcc08445 2695 python optional 
python-watcherclient_3.3.0-3.dsc
 a63a5c065d0cf20f20ba310c64eb8b3c 4640 python optional 
python-watcherclient_3.3.0-3.debian.tar.xz
 82c16b6fe20a6db1e9b6a998ca4e3dba 12957 python optional 
python-watcherclient_3.3.0-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoLGp81CJVhMOekJc1BatFaxrQ/4FAmHLWgsACgkQ1BatFaxr
Q/71bw//Tne8gEaBqqruDJUBPyv7qKci+pWhm8ZH/+GY+Ntg8KQVnnxiFheWjV1S
7bY+Uh6GThgbp8fiHbEaEKHjr1ixC95H0u3qpzbWcUP5psKHmc6+pEC0C3hKz+zF
9aqLJ7caViYfTWGPFmy231xJC/wwo6NS+hcSiXX3pBGdcvUag+TAr/gS8Ds9LaMj
0CJv34CrUqbFlvDd2JARE+PzKf+7tnWnF19G/ox1F+ZbfeERTFMHgcTPeRWfKikE
xIr/Fd2JGYesSD3YNcFmwF+Jzm4RmBF2nbPUvLssryIt7QDtg9XKJkbvZ1KRm06e
9BF5zcKlbp7jl8PVtWkvG7rdAMK7/HYh13f2whHA2Gn+bdPT2m2Fwe8oa2y6VqWU
8akpmKaG+sCaltNZ8MMshxgsvCcmyLfpFJsVyRsnNILGgSKUKwURF18xm8400say
N14BXk+3EFF2vE3raV6epcS0fmoPaM/nTDEUwGu59Cyoot7AWP9VQ7QUSfOhdAFH
Geg7BFYXMUDtJqLr507NojCVM8ScpKFydgZAIaZID5wlqDxHvKQWlYXGtxxeaWg/
/bHl/w2KCMgokP27ksKom4/vvHJ1XoMlfgHw709tNP22Gl7hGMnmzh8D4ikkE4YE
0Pk3Z93qHS4u0VWOW3Z/mXYVEHB3MHG1E8l8QgMvl6BC3Fq32ms=
=m869
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to