Your message dated Fri, 04 Feb 2022 10:33:48 +0000
with message-id <[email protected]>
and subject line Bug#1001153: fixed in acpitool 0.5.1-7
has caused the Debian Bug report #1001153,
regarding acpitool exits with an assertion if moe than 4 power sources in sysfs
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1001153: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1001153
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: acpitool
Version: 0.5.1-6
Severity: important
Tags: patch
X-Debbugs-Cc: [email protected]
IS:
On my system (Lenovo Thinkpad T580), acpitool shows the following output:
dietz@luke:~/tmp/acpitool-0.5.1$ acpitool
acpitool: battery.cpp:816: int Count_Batteries_SysFS(): Assertion `findex < 4'
failed.
Aborted
SET:
Do not crash with an assertion.
Side Notes:
A quick glance at /sys/class/power_supply/ shows, that there are indeed
more than 4 entries in that directory. Changing the assert in question to i.e.
assert (findex < 10) and extending char filename[4][] accordingly (what my
patch does) fixes that quite nicely. At least as long as we do not run into
some device with a really number of power supplies.
-- System Information:
Debian Release: bookworm/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 5.15.5 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages acpitool depends on:
ii libc6 2.32-4
ii libgcc-s1 11.2.0-12
ii libstdc++6 11.2.0-12
Versions of packages acpitool recommends:
ii acpid 1:2.0.33-1
acpitool suggests no packages.
-- no debconf information
Description: support more that 4 entries in /sys/.../power_supply/
Author: Dietz Proepper <[email protected]>
--- acpitool-0.5.1.orig/src/battery.cpp
+++ acpitool-0.5.1/src/battery.cpp
@@ -788,7 +788,7 @@ int Count_Batteries_ProcFS()
int Count_Batteries_SysFS()
{
DIR *battery_dir;
- char filename[4][65], str[100];
+ char filename[10][65], str[100];
char *name, *dirname;
int findex = 0, batcount = 0;
@@ -813,7 +813,7 @@ int Count_Batteries_SysFS()
// skip . and .. //
if (!strcmp (".", name) || !strcmp ("..", name)) continue;
- assert (findex < 4);
+ assert (findex < 10);
sprintf(filename[findex], "/sys/class/power_supply/%s/type",
name);
findex++;
--- End Message ---
--- Begin Message ---
Source: acpitool
Source-Version: 0.5.1-7
Done: Seunghun Han <[email protected]>
We believe that the bug you reported is fixed in the latest version of
acpitool, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Seunghun Han <[email protected]> (supplier of updated acpitool package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 04 Feb 2022 14:05:28 +0900
Source: acpitool
Binary: acpitool acpitool-dbgsym
Architecture: source amd64
Version: 0.5.1-7
Distribution: unstable
Urgency: medium
Maintainer: Seunghun Han <[email protected]>
Changed-By: Seunghun Han <[email protected]>
Description:
acpitool - command line ACPI client
Closes: 1001153
Changes:
acpitool (0.5.1-7) unstable; urgency=medium
.
* Fix a bug to support more than 2 power sources (Closes: #1001153)
Thanks to Dietz Proepper <[email protected]>
* Bumped d/control Standards-Version to 4.6.0
* Change d/control debhelper-compat to 13
Checksums-Sha1:
ffe5c711aa1974d1a41892674835b8a6ec0a089a 1885 acpitool_0.5.1-7.dsc
3233430aeea7950c97cf1d2d659e5216c928b854 11056 acpitool_0.5.1-7.debian.tar.xz
af61ad9215f91c0416dc2358b3e2108595da0944 220124
acpitool-dbgsym_0.5.1-7_amd64.deb
b146cb74956f11eeb7bb60002ded36f7594c35bc 6668 acpitool_0.5.1-7_amd64.buildinfo
c167fe443bdf4fe05c923d0d0c174bd8090c671f 50124 acpitool_0.5.1-7_amd64.deb
Checksums-Sha256:
680ff8f694aedd8b0511f34557604e3620c9d3c2405552b328dff529696eea7a 1885
acpitool_0.5.1-7.dsc
f64a16d1f3a02680d89a92653e8467998a9851a55c4053a91dda6637a5ead45c 11056
acpitool_0.5.1-7.debian.tar.xz
05d25f3e3d3c0fa6491f61f1f548d89fc9bee812e68fdc4d78109599bf792d21 220124
acpitool-dbgsym_0.5.1-7_amd64.deb
dbba9ae3b9ca1760380ea5002b9703ccf880445154895e0d64c5099aa568c749 6668
acpitool_0.5.1-7_amd64.buildinfo
4f0658456941af4e704c65d6e7a88d9c2b8bdc084dd5e8fafa17ac1e220d2192 50124
acpitool_0.5.1-7_amd64.deb
Files:
fe3bd2e4e27c103dff170646f00de88b 1885 utils optional acpitool_0.5.1-7.dsc
883b33d77952c84cbe8dbe6d39c2e54d 11056 utils optional
acpitool_0.5.1-7.debian.tar.xz
5684701819a70c44eb5caac00d8b9f18 220124 debug optional
acpitool-dbgsym_0.5.1-7_amd64.deb
86af02c1c0414d99c8eba6a1fda28654 6668 utils optional
acpitool_0.5.1-7_amd64.buildinfo
b2af392ac3f201737628dc17595ff02d 50124 utils optional
acpitool_0.5.1-7_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQJHBAEBCgAxFiEEJkpgMMG6tOqCw39E4GN2gkrFq6kFAmH8/SoTHGtrYW1hZ3Vp
QGdtYWlsLmNvbQAKCRDgY3aCSsWrqa+eD/9W2CFEoTaJlRQxur80gnPj084cC+Ik
pPPlEPuM2w2B3gcd4qLLxMH8Pkef5lUyKAW1ESpBd7YzOiwPkrtBzkQro4T89mRK
OJQKxSuSuev1LF9J+472ZlSSeh/WQo6eeTlQGPIp/hx2MgZhf8EOLrZnJhzQ+Yyv
SXWuCg8tk8qq9KcSAbdZSVbbiNl9uVSL9rr9c5ltnWT5ZwXGbewNSpS8zcaOCgP9
kpZoLiuZVEx0I1INeN9OhpkrM+YYp/1Ndr6nKPVsyvqH/64Tq0P0bboOEotWpLO+
jyRgiqNZLwTm6uiCGaSF9tg4CF4IK2gQvaW5qeAOwQOjBaDCYAbgx1Zyhkms2u9Y
kRM5V0lz/JevGh7q8ALa8WfTRMg9uQjPC5AlruQhRXtQ4WsbX4uLKZXe3qnarHC4
aCiYvNSTObkLHXSjqdiTHEBFUFzvB/bXjYP87VmFI43m6XsxJv7EhnWrMOOrQ3oD
zwCleUcAOLm5whokIy5DzNQjcSsKtymr0uEfOUs37h+Vq8IWclmWJ0X16boTNYAO
G/lg5HYZt42bqj7pSRXjfbxd5jS/bZ7CCXGFiqrafD72j/HL7ZTeN7jirxZJfDMH
8vdXVLstSLUXLfPctb31Zg23uUNjG6XhCKcaeUOMoaZeDfFzFEcPCYNVcHeJgzIJ
apjkMYd0BbUQeg==
=UC6n
-----END PGP SIGNATURE-----
--- End Message ---
