Your message dated Fri, 04 Feb 2022 15:50:20 +0000 with message-id <[email protected]> and subject line Bug#691643: fixed in man-db 2.10.0-1 has caused the Debian Bug report #691643, regarding man-db -p's mtime check fails and man-db readds man pages needlessly to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 691643: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=691643 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: man-db Version: 2.6.3-1 Severity: normal Tags: upstream patch mandb -p (which is run by the dpkg trigger) takes a lot of time to run. I started looking at it (again) and noticed something peculiar (edited a bit for clarity). # mandb -p | grep "manual pages were added" 0 manual pages were added. # touch /usr/share/man/man3 # mandb -p | grep "manual pages were added" 1101 manual pages were added. # touch /usr/share/man/man3 # mandb -p | grep "manual pages were added" 1101 manual pages were added. As I haven't done anything but update the directory's mtime, I would have expected the subsequent mandb -p runs add no pages. I tested this on a few Debian installs with various uses and saw similar thing happen with their man directories. I looked at the code and saw that mandb stores man pages' mtimes to its database, but there's something off with the code and it gives false positives on differing mtimes. I didn't come up with a fix for that issue, but using man pages' ctimes instead I could do this: Index: man-db-2.6.3/src/check_mandirs.c =================================================================== --- man-db-2.6.3.orig/src/check_mandirs.c 2012-10-27 12:00:13.000000000 +0300 +++ man-db-2.6.3/src/check_mandirs.c 2012-10-28 00:31:35.200950213 +0300 @@ -316,12 +316,14 @@ free (lg.whatis); } -static inline void add_dir_entries (const char *path, char *infile) +static inline void add_dir_entries (const char *path, char *infile, + time_t last) { char *manpage; int len; struct dirent *newdir; DIR *dir; + struct stat filestat; manpage = appendstr (NULL, path, "/", infile, "/", NULL); len = strlen (manpage); @@ -344,7 +346,10 @@ if (!(*newdir->d_name == '.' && strlen (newdir->d_name) < (size_t) 3)) { manpage = appendstr (manpage, newdir->d_name, NULL); - test_manfile (manpage, path); + if (last) + lstat(manpage, &filestat); + if (filestat.st_ctime >= last) + test_manfile (manpage, path); *(manpage + len) = '\0'; } @@ -508,7 +513,7 @@ if (!tty) fprintf (stderr, "\n"); } - add_dir_entries (path, mandir->d_name); + add_dir_entries (path, mandir->d_name, last); MYDBM_CLOSE (dbf); amount++; } Note that test_manfile calls stat on manpage too and those calls could be merged but I left that change out of this, for simplicity's sake. I'm happy to say that this makes the trigger work a lot faster. What do you think of my approach to this? -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 3.2.0-4-amd64 (SMP w/6 CPU cores) Locale: LANG=C, LC_CTYPE=fi_FI.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages man-db depends on: ii bsdmainutils 9.0.3 ii debconf [debconf-2.0] 1.5.46 ii dpkg 1.16.9 ii groff-base 1.21-9 ii libc6 2.13-36 ii libgdbm3 1.8.3-11 ii libpipeline1 1.2.2-1 ii zlib1g 1:1.2.7.dfsg-13 man-db recommends no packages. Versions of packages man-db suggests: ii chromium [www-browser] 22.0.1229.94~r161065-2 ii elinks [www-browser] 0.12~pre5-8 ii groff 1.21-9 ii iceweasel [www-browser] 10.0.10esr-1 ii konqueror [www-browser] 4:4.8.4-2 ii less 451-1 ii w3m [www-browser] 0.5.3-8 -- debconf information excluded
--- End Message ---
--- Begin Message ---Source: man-db Source-Version: 2.10.0-1 Done: Colin Watson <[email protected]> We believe that the bug you reported is fixed in the latest version of man-db, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Colin Watson <[email protected]> (supplier of updated man-db package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Fri, 04 Feb 2022 15:30:35 +0000 Source: man-db Architecture: source Version: 2.10.0-1 Distribution: unstable Urgency: medium Maintainer: Colin Watson <[email protected]> Changed-By: Colin Watson <[email protected]> Closes: 630799 691643 941622 970482 974174 998426 1003089 1004248 1004355 Changes: man-db (2.10.0-1) unstable; urgency=medium . * Simplify some debhelper overrides slightly. * debian/upstream/metadata: Update for upstream move to GitLab. * Add section 0 to default search list (closes: #1004248). * New upstream snapshot: - Document MAN_DISABLE_SECCOMP and PIPELINE_DEBUG environment variables in man(1) (closes: #941622). - Add man-pages(7) reference to man(1) (closes: #974174). - lexgrog now produces output in the user's locale (closes: #970482). - Downgrade "malformed .lf request" warning to a debug message and rephrase it somewhat, since .lf requests can use *roff arithmetic expressions and we can't reasonably parse those (closes: #998426). - Significantly improve mandb(8) and "man -K" performance in the common case where pages are of moderate size and compressed using zlib (closes: #630799, #1003089; LP: #1858777). - Avoid modifying the database without changing its mtime, which had been possible since 2.7.0 if mandb's purge phase found work to do but the main phase didn't, and which confused some backup systems into reporting possible filesystem corruption (closes: #1004355, LP: #1411633). - mandb now stores the mtime of link targets as the mtime of their corresponding database entries, rather than sometimes storing the mtime of the link instead (closes: #691643). Checksums-Sha1: bafe3f80fc81f241084601d2fa86237f1b17bfa0 2418 man-db_2.10.0-1.dsc ee3bf8ae326f3e193722ba11a608097dd694bd1f 1888196 man-db_2.10.0.orig.tar.xz 717137ce1e2319daaab8812b3dc89cb7254055b3 833 man-db_2.10.0.orig.tar.xz.asc e564cd5c5ca3451a143f328ee9c117cd2bed6abc 72972 man-db_2.10.0-1.debian.tar.xz Checksums-Sha256: 23152ae5925ebb3bbeb17b8e5776a6c45c312d3ca215d11601858d59648e5e84 2418 man-db_2.10.0-1.dsc 0a8629022f7117dc7fc6473c6fdb14913b24b106059bb056abee87dbd6070c79 1888196 man-db_2.10.0.orig.tar.xz 01bdd84c2b3f106a31ad9d2c8926ba0ece57241eae0dc6b0cead640eb611543e 833 man-db_2.10.0.orig.tar.xz.asc bec718ecc64bb05fa8d2f63f153768919b012cf1614da8734afa07ec164eb63b 72972 man-db_2.10.0-1.debian.tar.xz Files: b96773d05e3a92a32d6d17341afbfccf 2418 doc important man-db_2.10.0-1.dsc 96009cd422f2e62b01b8c4de0f5691f1 1888196 doc important man-db_2.10.0.orig.tar.xz d5c04220af019a6adef3f49c82964d4b 833 doc important man-db_2.10.0.orig.tar.xz.asc 655c82e59f78ce0d50f3ea781fe871e7 72972 doc important man-db_2.10.0-1.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEErApP8SYRtvzPAcEROTWH2X2GUAsFAmH9Rt4ACgkQOTWH2X2G UAvmKhAAq0gntVMIt7i8RbrUqlJBtpwAvA7TqkQ44464isyoG2TM+yP8yPDlwp/7 oTBbZtmTzE6jK/7SDKHV+P/3Djh6mDSM9cKS62HU1MVKEPmybpqYFcfWFO79T68S 1pCNHHkff4lVMAFM370BmmZlhpLCMZFidbXsqzJQuB3NxutySmtI/MY/wy1wCSUq 0PB0v4YRPA5CKeWjo5LTCbGE9DvlUNVvvSA+HX0p3a1Go2aTfO/7cki4mtpn+P6V e2VmEt9djAjfzEI9K2fMcyiJE6RhzpA+g2ZX4plo7Mm6kmx+XFTC2EV0yMDdVILe ctncWpGFd6oROjAz3X0DH23a22l6UWdHQIsIuqq3bD5tZXKcXrcSPJzSdyO0YeBw +AecHbsMYLtmG9N3KrF+H77EGTSQr1xdqkOimNkx5VdMq/LkDVxjQboRP/T1309Z amYynIEQ+UwWYoGJSQ031RyfyysgLibPvvH0y/bg019zxux5WQNTqRsFLy092MZN d6qdjJFVIb2RkwwYGGnNKXLXrBRVeKSl/Zv/KIrsxDLsSUnwV7Tmb/2z4Tz3ODCH 4cAIpdWz/9dSO8OhSvVMNHKGrGtNzL6+LFQ720P+qpZLaEchEdcEFZgvvt2+/zYw KVCUn8QBkp/p3L3dFMmuvVTTANIQlDPkEqZd/VzPga2x/pTwyo0= =v64e -----END PGP SIGNATURE-----
--- End Message ---
