Your message dated Wed, 13 Apr 2022 07:18:58 +0000
with message-id <[email protected]>
and subject line Bug#1009622: fixed in ck 0.7.1-7
has caused the Debian Bug report #1009622,
regarding ck: FTBFS on armhf due to wrong -march target
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1009622: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1009622
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ck
Version: 0.7.1-6
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu jammy ubuntu-patch

Hi Daniel,

In Ubuntu, ck fails to build on armhf because the upstream build system is
passing an explicit -march option that is no longer correct because it does
not include floating-point support which is implicit in armhf:

[...]
/usr/bin/cc -D_XOPEN_SOURCE=600 -D_BSD_SOURCE -D_DEFAULT_SOURCE -std=gnu99 
-pedantic -Wall -W -Wundef -Wendif-labels -Wshadow -Wpointer-arith -Wcast-align 
-Wcast-qual -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes 
-Wnested-externs -Winline -Wdisabled-optimization -fstrict-aliasing -O2 -pipe 
-Wno-parentheses -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
-fstack-protector-strong -Wformat -Werror=format-security -march=armv7-a -fPIC 
-D_XOPEN_SOURCE=600 -D_BSD_SOURCE -D_DEFAULT_SOURCE -std=gnu99 -pedantic -Wall 
-W -Wundef -Wendif-labels -Wshadow -Wpointer-arith -Wcast-align -Wcast-qual 
-Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs 
-Winline -Wdisabled-optimization -fstrict-aliasing -O2 -pipe -Wno-parentheses 
-g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat 
-Werror=format-security -march=armv7-a -fPIC -I/<<PKGBUILDDIR>>/include 
-I/<<PKGBUILDDIR>>/include -D__arm__ -c -o 
/<<PKGBUILDDIR>>/src/ck_barrier_tournament.o 
/<<PKGBUILDDIR>>/src/ck_barrier_tournament.c
cc1: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU
cc1: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU
[...]

  (https://launchpad.net/ubuntu/+source/ck/0.7.1-6/+build/22357550)

I have not verified whether this build failure exists with the current
toolchain in Debian, therefore I am not marking this as a serious bug;
however, I expect that if this toolchain change has not yet happened in
Debian, it will happen soon.

I have applied the attached patch in Ubuntu to let ck build by choosing an
appropriate cpu target of -march=armv7-a+fp.  Please consider applying it in
Debian as well.  Alternatively, upstream could just not override the -march
at all and trust the compiler defaults.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
[email protected]                                     [email protected]
diff -Nru ck-0.7.1/debian/rules ck-0.7.1/debian/rules
--- ck-0.7.1/debian/rules       2021-10-30 17:45:35.000000000 -0700
+++ ck-0.7.1/debian/rules       2022-04-12 23:30:57.000000000 -0700
@@ -2,6 +2,11 @@
 
 include /usr/share/dpkg/architecture.mk
 
+ifeq ($(DEB_HOST_ARCH),armhf)
+    DEB_CFLAGS_MAINT_APPEND = -march=armv7-a+fp
+endif
+export DEB_CFLAGS_MAINT_APPEND
+
 ifneq (,$(filter $(DEB_HOST_ARCH), armel x32))
        PLATFORM = --platform=unknown
 endif

--- End Message ---
--- Begin Message ---
Source: ck
Source-Version: 0.7.1-7
Done: Daniel Baumann <[email protected]>

We believe that the bug you reported is fixed in the latest version of
ck, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Baumann <[email protected]> (supplier of updated ck 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 13 Apr 2022 08:50:08 +0200
Source: ck
Architecture: source
Version: 0.7.1-7
Distribution: sid
Urgency: medium
Maintainer: Daniel Baumann <[email protected]>
Changed-By: Daniel Baumann <[email protected]>
Closes: 1009622
Changes:
 ck (0.7.1-7) sid; urgency=medium
 .
   * Uploading to sid.
   * Overwriting armhf platform target to fix FTBFS with newer GCC (Closes:
     #1009622).
Checksums-Sha1:
 c7dc6786b977d2a9728ee90de066eff8120d7ca4 1910 ck_0.7.1-7.dsc
 7c6b676b1ccd58fc08073b1a6228ae236a940a5b 4732 ck_0.7.1-7.debian.tar.xz
 f9e2bb208790734a46ee146e8dc2050a1a86d88b 6336 ck_0.7.1-7_amd64.buildinfo
Checksums-Sha256:
 a7d8d7cbcbb2c8d935903a55ad11d8e6dfeaa23889fdad393118e15b6fff2991 1910 
ck_0.7.1-7.dsc
 08232516f83b2c96e837c9fda83aa346d3592e74ced3aa7b15355b31ff1d2cd6 4732 
ck_0.7.1-7.debian.tar.xz
 e872c40d542f1066e70942152803ae5429d791074af5a84361084b568039e6af 6336 
ck_0.7.1-7_amd64.buildinfo
Files:
 d22f0711ccb60af67f2041890c112c1b 1910 libs optional ck_0.7.1-7.dsc
 688977c1fd8a5739a7efc282d162b129 4732 libs optional ck_0.7.1-7.debian.tar.xz
 434cf2db4d8c2326dc7641ff6abebe00 6336 libs optional ck_0.7.1-7_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEgTbtJcfWfpLHSkKSVc8b+YaruccFAmJWc+EACgkQVc8b+Yar
ucfn0A/+MJMLGdKybepD/j7z+lQUyEX/RcFvY5HhJCQNTzz0ZRw0cF+r27Hw44Kr
VupuM6+PRwnI5rtRb/EtPgMDGiqcG1vmTBdB4fCQzhA7LTXtF4tMaSp+JERub1Uz
4oM9cpW+3yFZXb4GmpSoflQcKHFZiUg8VMy1z2hnAlg+X+2aVC+CWG7+L+SleB7a
Ph1XWgG2p1gtW66l8p9D2Vviep43eJJrFQ1xOo32IRHPuud87VSITrMjsIuAzx8v
ay1uV+lMCuY75/hDPz7c61DT75dh+NSvqYRhiX4xc5Evu4+EkKauI2unYLyUd1Z4
iIgQXkSnc13QT4CkXhHAHLVY10WYa8COIus/jmge9pb1IkUFUH55HQwysLPZ/lr5
u3bowQQlha62PlfY0YNl2wJb8xRMKynQtZfB1FNo5AEAsltnostgEpVMUk6EYegM
QjwBw4xrzoAHbkupuk1ig54FdPcD1HnNbYbI5cs0+rrf8m7PeaIKlhwWpmmf/auN
fHaJCn2mPUBChE3gJ8PGWlxAIOfFhJ0yh3t8qWrHjdkdNHW+u9Dm/7M+iP5iUPza
38Bi1Fw+03ZiSu53cAqN0Y0O7SS2jzWnYGQodiMMSUCOqAa7UY1zeg4QvlDnBIaW
1PFQytbBphBAuiEGC0yPQrSFOGf5Z4fQYOMKzykE0jbzelkFA94=
=gSaN
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to