Your message dated Sun, 17 Apr 2022 09:48:50 +0000
with message-id <[email protected]>
and subject line Bug#994204: fixed in debhelper 13.7
has caused the Debian Bug report #994204,
regarding dh_installsystemd: --no-stop-on-upgrade has no effect, seemingly
broken in 6067bc2f
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
994204: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=994204
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: debhelper
Version: 13.5.1
Severity: normal
X-Debbugs-Cc: [email protected]
Dear Maintainer,
First let me give a bit of context:
I was putting some work on the docker.io package. Right now docker.io
depends on needrestart, so it's not affected by this bug. However I
was working on removing the needrestart dependency, hence making it a
"normal package", with regard to restarting the docker daemon when the
package is upgraded.
So I removed needrestart from the docker.io Depends, I rebuilt the
package, and installed it again and again, to check whether the daemon
was restarted during the package re-installation.
And I was surprised to see that yes, dockerd was restarted all the time.
However the debian/rules for docker.io explicitly states that it should
not:
override_dh_installsystemd:
dh_installsystemd -v --name=docker --no-stop-on-upgrade
--no-restart-after-upgrade
The man page of dh_installsystemd says:
--no-stop-on-upgrade
Do not stop service on upgrade. This has the side-effect of not
restarting the service as a part of the upgrade.
So if I understand properly, this is a bug.
We can see which postinst snippets are installed during the build of the
package in eg. [1], I'll reproduce it here for convenience:
dh_installsystemd -v --name=docker --no-stop-on-upgrade
--no-restart-after-upgrade
install -d debian/docker.io/lib/systemd/system
install -p -m0644 debian/docker.io.docker.service
debian/docker.io/lib/systemd/system/docker.service
install -p -m0644 debian/docker.io.docker.socket
debian/docker.io/lib/systemd/system/docker.socket
[META] Append autosnippet "postinst-systemd-enable" to postinst
[debian/.debhelper/generated/docker.io/postinst.service]
[META] Append autosnippet "postinst-systemd-enable" to postinst
[debian/.debhelper/generated/docker.io/postinst.service]
[META] Prepend autosnippet "postrm-systemd" to postrm
[debian/docker.io.postrm.debhelper.new]
mv debian/docker.io.postrm.debhelper.new
debian/docker.io.postrm.debhelper
[META] Append autosnippet "postinst-systemd-start" to postinst
[debian/.debhelper/generated/docker.io/postinst.service]
[META] Prepend autosnippet "prerm-systemd-restart" to prerm
[debian/.debhelper/generated/docker.io/prerm.service.new]
mv debian/.debhelper/generated/docker.io/prerm.service.new
debian/.debhelper/generated/docker.io/prerm.service
[META] Prepend autosnippet "postrm-systemd-reload-only" to postrm
[debian/docker.io.postrm.debhelper.new]
mv debian/docker.io.postrm.debhelper.new
debian/docker.io.postrm.debhelper
Looking at the snippet postinst-systemd-start, we can see that what it
does is actually "deb-systemd-invoke restart". I believe this is the
problem, it should be "start" instead.
And indeed, it used to be start, and was changed to restart very
recently (Jul 11th), in this commit:
https://salsa.debian.org/debian/debhelper/-/commit/6067bc2
I don't really know what's the proper fix here, since this commit was
not trivial, and just changing it back to "start" might (or might not)
break something else.
Cheers,
Arnaud
-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 5.10.0-8-amd64 (SMP w/8 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages debhelper depends on:
ii autotools-dev 20180224.1+nmu1
ii dh-autoreconf 20
ii dh-strip-nondeterminism 1.12.0-1
ii dpkg 1.20.9
ii dpkg-dev 1.20.9
ii dwz 0.14-1
ii file 1:5.39-3
ii libdebhelper-perl 13.5.1
ii libdpkg-perl 1.20.9
ii man-db 2.9.4-2
ii perl 5.32.1-5
ii po-debconf 1.0.21+nmu1
debhelper recommends no packages.
Versions of packages debhelper suggests:
ii dh-make 2.202101
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: debhelper
Source-Version: 13.7
Done: Niels Thykier <[email protected]>
We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Niels Thykier <[email protected]> (supplier of updated debhelper package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 17 Apr 2022 09:42:46 +0000
Source: debhelper
Architecture: source
Version: 13.7
Distribution: unstable
Urgency: medium
Maintainer: Debhelper Maintainers <[email protected]>
Changed-By: Niels Thykier <[email protected]>
Closes: 994204 1002800 1004939
Changes:
debhelper (13.7) unstable; urgency=medium
.
[ Niels Thykier ]
* dh_installalternatives: Improve validation of alternative files to
catch some "obvious" copy-waste mistakes.
* dh: Invoke dh_installalternatives after dh_link in compat 14 or
later. Thanks to Colin Watson for the suggestion.
(Closes: #1002800)
* cmake.pm: Drop -DCMAKE_SKIP_RPATH=on in compat v14. Thanks to
Vagrant Cascadian for the suggestion and the investigative work on
this topic. (Closes: #1004939)
* debhelper-compat-upgrade-checklist.pod: New file.
* debhelper.pod: Move list of supported compat levels and the related
upgrade checklist into debhelper-compat-upgrade-checklist.pod.
This means you now need `man 7 debhelper-compat-upgrade-checklist`
to see the upgrade checklist.
* dh_installdebconf: Support -D/--define command line parameters
(mirroring those from dh_installdeb).
* Dh_Lib.pm: Cope with "?=" as assignment operator in substvars files
to be future proof with (possible) planned addition of "optional
substvars. At the moment, debhelper will still always use "=" when
adding a substvar but it will now preserve "?=" operator if an
existing substvar is modified.
.
[ Guillem Jover ]
* autoconf.pm: Add support for autotest test suites by passing the
TESTSUITEFLAGS environment variable to `make test`.
.
[ Dave Jones ]
* Rewrite handling of stop services to use the `preinst` when using
--no-restart-after-upgrade. This fixes a regression caused by
the fix for #989155. (Closes: #994204)
.
[ Johannes Schauer Marin Rodrigues ]
* dh_installmenu: Respect DPKG_ROOT when checking for update-menus.
Note this implementation assumes update-menus is present both
inside and outside the chroot to activate. If it is absent on
either side, the update-menus call is skipped.
.
[ Gioele Barabucci ]
* dh_installsysusers: Invoke systemd-sysusers even when DPKG_ROOT
is set (relying on `--root`).
* dh_installpam: In compat 14, install pam snippets into
`/usr/lib/pam.d` instead of `/etc/pam.d`. Remember to remove
(now) obsolete conffiles when you bump to compat 14.
.
[ Andreas Hübner ]
* debhelper.pod: Correct spelling of DEB_BUILD_MAINT_OPTIONS.
Checksums-Sha1:
4b056295e349b904ab53e20bccb0942a4da8114f 1781 debhelper_13.7.dsc
5ada71660423bd027535a8f1fa5491fe8c432e54 570648 debhelper_13.7.tar.xz
c99dd52162c862013c803eb51de8279920645205 5109 debhelper_13.7_source.buildinfo
Checksums-Sha256:
addaef09b019eff48fda58ae0068236a7bf23658954eca0c9aa47e1847f386fa 1781
debhelper_13.7.dsc
552e91ff96e1bd844d549496cb1712b32ae9c5f39e17da8b1c779bd718e4dc49 570648
debhelper_13.7.tar.xz
4058efc2b7ee56fd7038e1f9be1de708c480c328fa9125df4601cfd85330666c 5109
debhelper_13.7_source.buildinfo
Files:
a1b9c2d33c6661b6d76ae32d15b12f73 1781 devel optional debhelper_13.7.dsc
04087c766181d84e011717c0a1ddc22a 570648 devel optional debhelper_13.7.tar.xz
672e0c980e9a95ade3d78d14ba349a13 5109 devel optional
debhelper_13.7_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJGBAEBCgAwFiEE8f9dDX4ALfD+VfsMplt42+Z8eqwFAmJb4V8SHG5pZWxzQHRo
eWtpZXIubmV0AAoJEKZbeNvmfHqs6lkQANodDElgvIIMY2MT5/vyZ3UXfbvEemj/
u9VgFdtd0GSHxhEBnN38M/9SBR0+4B6wPugcQkvAXIh1I19ULh+q6gpznGOMCsZX
+Zx/pi/brQI5D09uSyKqaYTVj5N0IS3Z/eHYQ03BgdK14bT9QFwmHs8P5wYS43k/
o97GHmJ/XiVTSHeNDbkS20TjefDNLAFbBmNM+XVZz0MfJx2UUNut3NwvfCVZhGCM
E11KrkHzRyt8WIVy8Ox9WRkga/vJbZ2HmqmYrBkH6eTN4TtZ7KaH2y5LXkk5HVSe
e1LlmMNzKji2PBYR3DbELV/EQrXtch2RDtcI/JAMGbre4Q54hcgzwmjtA11yXblb
y6BXCpgs2SRB9rUF9gPJw95+pa6w8yUtg84mY9ncS5zuNyySZvKKetnCgo9PVZFZ
G3R95JlkQz8O1z5cweCHXKksDGJbbO8nrtVhYBrPfafvKDrP2KX8ANvw/0yL4Pyd
uvnKAHXfs8v2tDOhBKDg7+CXBmBKpilMMPzg6lL1Obljxpt70yJ+UgxIcKW/vMrI
+rZpLYGruDKUBB7N5JhJjzRN4W3U0j8HNL8UDa/UXJydFuiPeUQGtddcc2SDD0BE
WZXNsrcJ7QO1CYNPAWuEDKIisPm8TmnMQy0gAEtuW7vzlkDv3Ajp9pStltRrvfQr
4nBCyCUF8mdm
=jNFp
-----END PGP SIGNATURE-----
--- End Message ---
