Your message dated Sun, 24 Apr 2022 19:06:43 +0000
with message-id <[email protected]>
and subject line Bug#981348: fixed in smokeping 2.7.3-4
has caused the Debian Bug report #981348,
regarding smokeping: page constantly refreshes while zoomed in, making UI
unusable
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
981348: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=981348
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: smokeping
Version: 2.7.3-2
Severity: important
Tags: upstream patch
Dear Maintainer,
The UI of smokeping automatically refreshes the page when zoomed in on some
graphs (every 10s here) making it completely unusable (or actually higly
annoying) using it.
The bug report upstream is from 2012
https://github.com/oetiker/SmokePing/issues/5
and there is finally a fix for it that's also merged upstream.
https://github.com/oetiker/SmokePing/pull/170
Please consider applying it in debian.
I've tested the patch in a vanilla smokeping installation and also in
our infrastructure and it indeed fixes the problem.
Patch reference:
commit ef1a7eac0a2f0baaf2cf1dc47703a73cdd936752
Author: n0rc <[email protected]>
Date: Wed Mar 13 15:35:48 2019 +0100
disabled page refresh while zooming (#5)
diff --git a/htdocs/js/smokeping.js b/htdocs/js/smokeping.js
index 59410cc..eb34e5e 100644
--- a/htdocs/js/smokeping.js
+++ b/htdocs/js/smokeping.js
@@ -26,12 +26,20 @@ var EndEpoch = 0;
function changeRRDImage(coords,dimensions){
+ // disable reloading the RRD image while zoomed in
+ try {
+ window.stop();
+ } catch (exception) {
+ // fallback for IE
+ document.execCommand('Stop');
+ }
+
var SelectLeft = Math.min(coords.x1,coords.x2);
var SelectRight = Math.max(coords.x1,coords.x2);
if (SelectLeft == SelectRight)
- return; // abort if nothing is selected.
+ return; // abort if nothing is selected.
var RRDLeft = 67; // difference between left border of
RRD image and content
var RRDRight = 26; // difference between right border
of RRD image and content
I've removed all included information as it is from another system and
is not related to this bug report.
ps.: trying to include secrets into a public bugreport is not nice...
best regards,
gebi
--- End Message ---
--- Begin Message ---
Source: smokeping
Source-Version: 2.7.3-4
Done: Gabriel Filion <[email protected]>
We believe that the bug you reported is fixed in the latest version of
smokeping, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Gabriel Filion <[email protected]> (supplier of updated smokeping package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 24 Apr 2022 14:44:58 -0400
Source: smokeping
Architecture: source
Version: 2.7.3-4
Distribution: unstable
Urgency: low
Maintainer: Gabriel Filion <[email protected]>
Changed-By: Gabriel Filion <[email protected]>
Closes: 962225 981348
Changes:
smokeping (2.7.3-4) unstable; urgency=low
.
[ Debian Janitor ]
* Trim trailing whitespace.
* Bump debhelper from old 10 to 12.
* Set debhelper-compat version in Build-Depends.
* Drop unnecessary dependency on dh-autoreconf.
* Update standards version to 4.5.0, no changes needed.
.
[ Gabriel Filion ]
* Import patch that disables refresh while zooming (Closes:#981348)
* Import patch disabling rsa1 and enabling ecdsa for ssh probe (Closes:
#962225)
Checksums-Sha1:
01808bad7b280a87970c16fc5bfe6115d31ad3a4 1802 smokeping_2.7.3-4.dsc
e61175f280091aa58e2e028287610facc6f642dc 27132 smokeping_2.7.3-4.debian.tar.xz
e120141148dac3e16cdb0ffcb8649db15c5200e6 9192 smokeping_2.7.3-4_amd64.buildinfo
Checksums-Sha256:
1cf6a629809b3be5384c5c8b603446a721b09d2288f3f7d68c9e620d86c18928 1802
smokeping_2.7.3-4.dsc
7ae1d95029cf6b413b921762beaedb91665833a5c21876ff0a1890903e440e72 27132
smokeping_2.7.3-4.debian.tar.xz
beac56cf2e77c474570d95326917f91a83500e1c4f5548359a01d14a7a2ecd13 9192
smokeping_2.7.3-4_amd64.buildinfo
Files:
4e4e6093329c085fe1b9c06e4512180c 1802 net optional smokeping_2.7.3-4.dsc
61b39d68d6ecef4764c4ddd5f53775bf 27132 net optional
smokeping_2.7.3-4.debian.tar.xz
718ed959097c694406a7071b747a816c 9192 net optional
smokeping_2.7.3-4_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEexZCBNCWcjsBljWrPqHd3bJh2XsFAmJlnhAACgkQPqHd3bJh
2Xuj5gf/U0EE0961nctYlFdf7o3jlN6qqNV7Gi2pWUf3DMY1Fr510Xb3M3oFLzXA
5ebDvbh1hrnro5KZcS0lGq89nfTXUmWzCra8myv1nl1XJ0vr2dYIpqm7smDdeAI7
GOW9RBXvrZ1wnCHSj+znOvW4NeAzbrQy3jlG6ZQqRXrXPOsxEkMNpR3Egqybv6vX
uR6D3JDXf0NIRPT9GpxJxzzYd5T/Kcm5phMT42V+yI5kPmsh2w/LJ9NOVxR4sUt9
tYJBHg0Ytz3MpxcYcEQeV7IWcSazxqAybPhODosBB50FHZw0nXMUSC6C1TbhKdyY
OXa47FA68RIH8OMxQh18yhaK1G+Lbw==
=Ck8u
-----END PGP SIGNATURE-----
--- End Message ---
