Your message dated Sat, 18 Jun 2022 12:31:39 +0100 with message-id <[email protected]> and subject line Re: Bug#859099: Close as fixed in 1.4.0-1 has caused the Debian Bug report #859099, regarding rsnapshot: fails to handle quoting in +rsync_long_args to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 859099: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=859099 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: rsnapshot Version: 1.3.1-4+deb8u1 Severity: important The fix for #662636 breaks my rsnapshot config. Here's a minimal example of the config: ================================= config_version 1.2 cmd_rsync /usr/bin/rsync sync_first 1 snapshot_root /tmp/rsnap/backup/ retain daily 7 verbose 3 backup /tmp/rsnap/src/ localhost/ +rsync_long_args=--filter="protect /tmp/rsnap/src/a/",exclude=/tmp/rsnap/src/a/ backup /tmp/rsnap/src/a/ localhost/ include="/tmp/rsnap/src/a/b/",exclude="/tmp/rsnap/src/a/*" ================================= The intention of the config is to backup /tmp/rsnap/src/a/b/, but nothing else in /tmp/rsnap/src/a/. Since i upgraded to jessie, i now get the following error when running rsnapshot: ================================= $ rsnapshot -c rsnapshot.conf sync mkdir -m 0755 -p /tmp/rsnap/backup/.sync/ /usr/bin/rsync -a --delete --numeric-ids --relative --delete-excluded \ --exclude=/tmp/rsnap/src/a/ --filter="protect /tmp/rsnap/src/a/" \ /tmp/rsnap/src /tmp/rsnap/backup/.sync/localhost/ Unknown filter rule: `"protect /tmp/rsnap/src/a/"' rsync error: syntax or usage error (code 1) at exclude.c(904) [client=3.1.1] ---------------------------------------------------------------------------- rsnapshot encountered an error! The program was invoked with these options: /usr/bin/rsnapshot -c rsnapshot.conf sync ---------------------------------------------------------------------------- ERROR: /usr/bin/rsync returned 1 while processing /tmp/rsnap/src/ /usr/bin/rsync -a --delete --numeric-ids --relative --delete-excluded \ --include="/tmp/rsnap/src/a/b/" --exclude="/tmp/rsnap/src/a/*" \ /tmp/rsnap/src/a /tmp/rsnap/backup/.sync/localhost/ touch /tmp/rsnap/backup/.sync/ ================================= As you can see, rsync is unable to parse the filter `protect` rule any more. If i remove debian/patches/10_space_destdir.diff, then it works as expected (and has been working for some years with squeeze): ================================= $ rsnapshot -c rsnapshot.conf sync /usr/bin/rsync -a --delete --numeric-ids --relative --delete-excluded \ --exclude=/tmp/rsnap/src/a/ --filter="protect /tmp/rsnap/src/a/" \ /tmp/rsnap/src /tmp/rsnap/backup/.sync/localhost/ /usr/bin/rsync -a --delete --numeric-ids --relative --delete-excluded \ --include="/tmp/rsnap/src/a/b/" --exclude="/tmp/rsnap/src/a/*" \ /tmp/rsnap/src/a /tmp/rsnap/backup/.sync/localhost/ touch /tmp/rsnap/backup/.sync/ ================================= -- System Information: Debian Release: 8.7 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 4.9.0-0.bpo.2-amd64 (SMP w/4 CPU cores) Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages rsnapshot depends on: ii liblchown-perl 1.01-2+b1 ii logrotate 3.8.7-1+b1 ii perl 5.20.2-3+deb8u6 ii rsync 3.1.1-3 Versions of packages rsnapshot recommends: ii openssh-client [ssh-client] 1:6.7p1-5+deb8u3 rsnapshot suggests no packages. -- Configuration Files: /etc/cron.d/rsnapshot changed [not included] /etc/rsnapshot.conf changed [not included] -- no debconf information
--- End Message ---
--- Begin Message ---Version: 1.4.0-1 Stephen, On Thu, Mar 30, 2017 at 12:41:14PM +0200, Stephen Shirley wrote: > Hey, > Sorry, i just realised that this bug is a duplicate of > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=793687 > > The only new information i've provided in this bug is that the > breakage is due to a specific debian patch, and a minimal reproducible > example. The 10_space_destdir patch was removed in version 1.4.0-1. Closing as fixed. Thanks Mark
--- End Message ---
