Your message dated Thu, 08 Jun 2006 01:32:09 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#371139: fixed in gok 1.0.10-2
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: gok
Version: 1.0.10-1
Severity: important
Tags: patch
While investigating #369864, I found that gok doesn't start if it
has problems reading the database. Note that this is not the same as
#369864.
The problems are freeing of an uninitialized pointer and a div-by-0.
A patch is attached.
The problem can be reproduced by setting up a fresh sid chroot,
installing gok, and probably xbase-clients, starting gok and
watching it segfault (given that it finds a proper display, which
can be ensured by bindmounting /tmp to /chroots/sid/tmp).
Cheers,
Christian Aichinger
-- System Information:
Debian Release: testing/unstable
APT prefers testing
APT policy: (990, 'testing'), (500, 'testing-proposed-updates'), (500,
'proposed-updates'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12-rc6-vs2.1.0-pre1-r20050817
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=UTF-8)
--- gok-1.0.10.old/gok/gok-data.c 2006-03-31 22:32:58.000000000 +0200
+++ gok-1.0.10/gok/gok-data.c 2006-06-07 12:26:37.000000000 +0200
@@ -240,15 +240,17 @@
gok_gconf_get_string (gconf_client, GOK_GCONF_AUX_DICTS,
&m_AuxDicts);
- gok_gconf_get_string (gconf_client, GOK_GCONF_DOCK_TYPE,
- &a_gchar);
- m_eDockType = gok_data_dock_type_from_string (a_gchar);
- g_free (a_gchar);
-
- gok_gconf_get_string (gconf_client, GOK_GCONF_COMPOSE_KBD_TYPE,
- &a_gchar);
- compose_keyboard_type = gok_data_compose_type_from_string (a_gchar);
- g_free (a_gchar);
+ if (gok_gconf_get_string (gconf_client, GOK_GCONF_DOCK_TYPE,
+ &a_gchar)) {
+ m_eDockType = gok_data_dock_type_from_string (a_gchar);
+ g_free (a_gchar);
+ }
+
+ if (gok_gconf_get_string (gconf_client, GOK_GCONF_COMPOSE_KBD_TYPE,
+ &a_gchar)) {
+ compose_keyboard_type = gok_data_compose_type_from_string
(a_gchar);
+ g_free (a_gchar);
+ }
/* Read in settings for individual access methods */
access_method_dirs
--- gok-1.0.10.old/gok/gok-keyboard.c 2006-05-15 17:10:00.000000000 +0200
+++ gok-1.0.10/gok/gok-keyboard.c 2006-06-07 12:38:08.000000000 +0200
@@ -3322,6 +3322,8 @@
/* maximum size of text per cell */
maxTextPerCell = gok_data_get_key_width() -
gok_key_get_default_border_width (pKey);
+ if (!maxTextPerCell)
+ maxTextPerCell = 1;
}
while (pKey != NULL)
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: gok
Source-Version: 1.0.10-2
We believe that the bug you reported is fixed in the latest version of
gok, which is due to be installed in the Debian FTP archive:
gok-doc_1.0.10-2_all.deb
to pool/main/g/gok/gok-doc_1.0.10-2_all.deb
gok_1.0.10-2.diff.gz
to pool/main/g/gok/gok_1.0.10-2.diff.gz
gok_1.0.10-2.dsc
to pool/main/g/gok/gok_1.0.10-2.dsc
gok_1.0.10-2_i386.deb
to pool/main/g/gok/gok_1.0.10-2_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Loic Minier <[EMAIL PROTECTED]> (supplier of updated gok package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Thu, 8 Jun 2006 10:13:55 +0200
Source: gok
Binary: gok gok-doc
Architecture: source i386 all
Version: 1.0.10-2
Distribution: unstable
Urgency: low
Maintainer: Akira TAGOH <[EMAIL PROTECTED]>
Changed-By: Loic Minier <[EMAIL PROTECTED]>
Description:
gok - GNOME Onscreen Keyboard
gok-doc - documentation files for the GNOME Onscreen Keyboard
Closes: 339994 367471 369864 371139
Changes:
gok (1.0.10-2) unstable; urgency=low
.
* Let gok depend on at-spi. (Closes: #339994, #367471, #369864)
[debian/control, debian/control.in]
* Drop the xlibs-static-dev build-dep.
[debian/control, debian/control.in]
* Add patch by Christian 'Greek0' Aichinger to fix freeing of an
uninitialized pointer and a div-by-0. (Closes: #371139)
[debian/patches/010_uninitialized-pointer-free-and-div-by-0.patch]
* Bump up Standards-Version to 3.7.2.
[debian/control, debian/control.in]
* Bump up Debhelper compatibility level to 5.
[debian/compat, debian/control, debian/control.in]
* Don't override DEB_CONFIGURE_EXTRA_FLAGS completely and cleanup rules.
[debian/rules]
* Move relibtoolizing patch at the end of the patch stack.
[debian/patches/001_gok-debian-libtool.patch,
debian/patches/900_gok-debian-libtool.patch]
* Remove executable bits on /usr/share/gnome/help/gok/C/legal.xml and make
lintian happy.
[debian/rules]
* Let gok-doc depend on ${misc:Depends}.
[debian/control, debian/control.in]
Files:
375fcfea3b9f2503b62cc9e3a66c7d88 1772 gnome optional gok_1.0.10-2.dsc
eae57bc72123d6000fb48bfe59642118 104970 gnome optional gok_1.0.10-2.diff.gz
676d7d2f9bbc3a420b7bcd28aa78ca0e 190882 doc optional gok-doc_1.0.10-2_all.deb
8701cc4813e017f1e3291d1904bea250 1418918 gnome optional gok_1.0.10-2_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
iD8DBQFEh91q4VUX8isJIMARAmFGAKCp8LKbGBOMMwWY23ctJZoSgI+rKgCdHnhI
8VXwGGPgzJ7eQ1sybJYfIVQ=
=b+jR
-----END PGP SIGNATURE-----
--- End Message ---
