Your message dated Thu, 07 Jul 2022 08:49:02 +0000
with message-id <[email protected]>
and subject line Bug#1009622: fixed in ck 0.7.1-8
has caused the Debian Bug report #1009622,
regarding ck: FTBFS on armhf due to wrong -march target
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1009622: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1009622
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ck
Version: 0.7.1-6
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu jammy ubuntu-patch
Hi Daniel,
In Ubuntu, ck fails to build on armhf because the upstream build system is
passing an explicit -march option that is no longer correct because it does
not include floating-point support which is implicit in armhf:
[...]
/usr/bin/cc -D_XOPEN_SOURCE=600 -D_BSD_SOURCE -D_DEFAULT_SOURCE -std=gnu99
-pedantic -Wall -W -Wundef -Wendif-labels -Wshadow -Wpointer-arith -Wcast-align
-Wcast-qual -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes
-Wnested-externs -Winline -Wdisabled-optimization -fstrict-aliasing -O2 -pipe
-Wno-parentheses -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=.
-fstack-protector-strong -Wformat -Werror=format-security -march=armv7-a -fPIC
-D_XOPEN_SOURCE=600 -D_BSD_SOURCE -D_DEFAULT_SOURCE -std=gnu99 -pedantic -Wall
-W -Wundef -Wendif-labels -Wshadow -Wpointer-arith -Wcast-align -Wcast-qual
-Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs
-Winline -Wdisabled-optimization -fstrict-aliasing -O2 -pipe -Wno-parentheses
-g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -march=armv7-a -fPIC -I/<<PKGBUILDDIR>>/include
-I/<<PKGBUILDDIR>>/include -D__arm__ -c -o
/<<PKGBUILDDIR>>/src/ck_barrier_tournament.o
/<<PKGBUILDDIR>>/src/ck_barrier_tournament.c
cc1: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU
cc1: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU
[...]
(https://launchpad.net/ubuntu/+source/ck/0.7.1-6/+build/22357550)
I have not verified whether this build failure exists with the current
toolchain in Debian, therefore I am not marking this as a serious bug;
however, I expect that if this toolchain change has not yet happened in
Debian, it will happen soon.
I have applied the attached patch in Ubuntu to let ck build by choosing an
appropriate cpu target of -march=armv7-a+fp. Please consider applying it in
Debian as well. Alternatively, upstream could just not override the -march
at all and trust the compiler defaults.
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru ck-0.7.1/debian/rules ck-0.7.1/debian/rules
--- ck-0.7.1/debian/rules 2021-10-30 17:45:35.000000000 -0700
+++ ck-0.7.1/debian/rules 2022-04-12 23:30:57.000000000 -0700
@@ -2,6 +2,11 @@
include /usr/share/dpkg/architecture.mk
+ifeq ($(DEB_HOST_ARCH),armhf)
+ DEB_CFLAGS_MAINT_APPEND = -march=armv7-a+fp
+endif
+export DEB_CFLAGS_MAINT_APPEND
+
ifneq (,$(filter $(DEB_HOST_ARCH), armel x32))
PLATFORM = --platform=unknown
endif
--- End Message ---
--- Begin Message ---
Source: ck
Source-Version: 0.7.1-8
Done: Daniel Baumann <[email protected]>
We believe that the bug you reported is fixed in the latest version of
ck, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Daniel Baumann <[email protected]> (supplier of updated ck
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 07 Jul 2022 10:14:36 +0200
Source: ck
Architecture: source
Version: 0.7.1-8
Distribution: sid
Urgency: medium
Maintainer: Daniel Baumann <[email protected]>
Changed-By: Daniel Baumann <[email protected]>
Closes: 1009622
Changes:
ck (0.7.1-8) sid; urgency=medium
.
* Uploading to sid.
* Updating to standards version 4.6.1.
* Adding patch from Steve Langasek <[email protected]> to fix
FTBFS on armhf (Closes: #1009622).
Checksums-Sha1:
523cba7aa93d42fd3d62c8dd51379edca87e6784 1910 ck_0.7.1-8.dsc
224584481e0b76768aed492f6398fcbe85d4b1e3 5036 ck_0.7.1-8.debian.tar.xz
d0708b4cc38a2c792b2ca1e5e5278ddfb5184d0b 6395 ck_0.7.1-8_amd64.buildinfo
Checksums-Sha256:
b2818d9f89a7c45edc04b4aead97ddcf3d74d94a1305ae1195c083e88ad6f8d9 1910
ck_0.7.1-8.dsc
359248e9fc16b5a985c15d14b39a65564747773f178737a0d43089412ad433a4 5036
ck_0.7.1-8.debian.tar.xz
1854e213ee560cd9edc2590d6d99bc79271a4b65ee49eb90576f762e0234b7b6 6395
ck_0.7.1-8_amd64.buildinfo
Files:
c586ace538bc089229654b1fd425685e 1910 libs optional ck_0.7.1-8.dsc
04be502b0423cfb50ee1572b50efb958 5036 libs optional ck_0.7.1-8.debian.tar.xz
a1c3d53d0ff83442f414abf674700c13 6395 libs optional ck_0.7.1-8_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEgTbtJcfWfpLHSkKSVc8b+YaruccFAmLGl00ACgkQVc8b+Yar
ucfWOw//U5gEZlxPB39GUBYkzz39IB9piQ1dfhXpsOvPZXQ6J0a88uN2FD9J+1LH
BLOqXdyzjZN5AZCY4KTMbDWHY6xeBY/j1pA9v1P1fuK4bVPDCWe6G6b6szzBojY6
gQsIIizPFTeWnEm7lIHqlTldhfJxtpwh5OUHiVOuEP1pzVqwW6gng9CV0eAdVGw/
yxu1l7gfUwHGMq+kcR/QnoGT5w6Dt6WSBPkHHFE41y8kQC5ANrHd42UTvCiN8+II
BQFDDraXT2Zqkj5TnW/XMYzQxD1gk7ge0n5KmZZH2quM4cidtQn0C+/ErGBk14l2
mLgsvlymYiJ9QwVRV5HIvQgzleoNgy/GPu2CZWhBPEHUl/4VsJNlfH1TOJlk1Mtl
zV0xQAJyUdriyvMT+k3G0nbgTJcRV3mWGWJsOtIbsP05XIUyT1s74zzWlV1uHGD8
GHaykxIN3WpRtaI1vdYusaCzx4YeuoXJpsB2naW6F0xUJzGa0+vDvV2Wo2tSJazv
xd9e2P8PLh+H6e+OuqWcEtWRhVWPckjfAVTqRIEIi/SN2VGvtXBAv0tYBMxhDy4o
8repDuv9PP4OLqsd3/8gCNgWNAY3ARyyWgKFuRsnKqQbq5HAobv+7Hb7GbVWnXJ+
KhTSsRSQwWF2DB3BJqeKSmVFPorcUvnlaIkeJotAItS4zjXuzS8=
=bXhQ
-----END PGP SIGNATURE-----
--- End Message ---
