Your message dated Sun, 31 Jul 2022 16:34:20 +0000
with message-id <[email protected]>
and subject line Bug#971558: fixed in clucene-core 2.3.3.4+dfsg-1.1
has caused the Debian Bug report #971558,
regarding clucene-core FTCBFS: uses CHECK_CXX_SOURCE_RUNS
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
971558: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=971558
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: clucene-core
Version: 2.3.3.4+dfsg-1
Tags: patch upstream
User: [email protected]
Usertags: ftcbfs
clucene-core fails to cross build from source, because it uses
CHECK_CXX_SOURCE_RUNS in a number of places. In some cases, it is used
for checking whether a particular syntax is supported by the compiler.
There, we can simply use CHECK_CXX_SOURCE_COMPILES at no loss. In some
cases, runtime bugs are checked. The best course of action here is to
assume that there are no runtime bugs (but only for cross compilation).
The attached patch implements that for all relevant checks. Please
consider applying it to make clucene-core cross buildable.
Helmut
--- clucene-core-2.3.3.4+dfsg.orig/src/shared/cmake/CheckNamespace.cmake
+++ clucene-core-2.3.3.4+dfsg/src/shared/cmake/CheckNamespace.cmake
@@ -1,8 +1,8 @@
#check if we support namespaces
MACRO ( CHECK_NAMESPACE haveNamespace )
#Check if namespaces work in the compiler
- CHECK_CXX_SOURCE_RUNS("
+ CHECK_CXX_SOURCE_COMPILES("
namespace Outer { namespace Inner { int i = 0; }}
int main(){ using namespace Outer::Inner; return i; }"
${haveNamespace} )
-ENDMACRO ( CHECK_NAMESPACE haveNamespace )
\ No newline at end of file
+ENDMACRO ( CHECK_NAMESPACE haveNamespace )
--- clucene-core-2.3.3.4+dfsg.orig/src/shared/cmake/CheckSnprintf.cmake
+++ clucene-core-2.3.3.4+dfsg/src/shared/cmake/CheckSnprintf.cmake
@@ -1,42 +1,46 @@
#checks if snprintf have bugs
MACRO ( CHECK_SNPRINTF )
- #check that our snprintf works correctly...
- IF ( _CL_HAVE_FUNCTION_SNPRINTF )
- CHECK_CXX_SOURCE_RUNS("
- #include <stdio.h>
- int main(){
- char ovbuf[7];
- int i;
- for (i=0; i<7; i++) ovbuf[i]='x';
- snprintf(ovbuf, 4,\"foo%s\", \"bar\");
- if (ovbuf[5]!='x') return 1;
- snprintf(ovbuf, 4,\"foo%d\", 666);
- if (ovbuf[5]!='x') return 1;
- return 0;
- }" _CL_HAVE_NO_SNPRINTF_BUG)
- IF ( NOT _CL_HAVE_NO_SNPRINTF_BUG )
- SET ( _CL_HAVE_SNPRINTF_BUG 1 )
- MESSAGE ( FATAL_ERROR "snprintf has a bug, and we don't have a replacement!" )
- ENDIF ( NOT _CL_HAVE_NO_SNPRINTF_BUG )
- ENDIF ( _CL_HAVE_FUNCTION_SNPRINTF )
-
- #check that our swnprintf works correctly...
- IF ( _CL_HAVE_FUNCTION_SNWPRINTF )
- CHECK_CXX_SOURCE_RUNS("
- #include <stdio.h>
- #include <wchar.h>
-
- int main(void)
- {
- wchar_t buf[5];
- snwprintf(buf,5,L\"%s\",L\"foo\");
- if ( wcslen(buf) != 3 )
- return 1;
- return 0;
- }" _CL_HAVE_NO_SNWPRINTF_BUG)
- IF ( NOT _CL_HAVE_NO_SNWPRINTF_BUG )
- SET ( _CL_HAVE_SNWPRINTF_BUG 1 )
- ENDIF ( NOT _CL_HAVE_NO_SNWPRINTF_BUG )
- ENDIF ( _CL_HAVE_FUNCTION_SNWPRINTF )
+ IF ( CMAKE_CROSSCOMPILING )
+ MESSAGE ( WARNING "cannot check for snprintf bugs during cross compilation")
+ ELSE ( CMAKE_CROSSCOMPILING )
+ #check that our snprintf works correctly...
+ IF ( _CL_HAVE_FUNCTION_SNPRINTF )
+ CHECK_CXX_SOURCE_RUNS("
+ #include <stdio.h>
+ int main(){
+ char ovbuf[7];
+ int i;
+ for (i=0; i<7; i++) ovbuf[i]='x';
+ snprintf(ovbuf, 4,\"foo%s\", \"bar\");
+ if (ovbuf[5]!='x') return 1;
+ snprintf(ovbuf, 4,\"foo%d\", 666);
+ if (ovbuf[5]!='x') return 1;
+ return 0;
+ }" _CL_HAVE_NO_SNPRINTF_BUG)
+ IF ( NOT _CL_HAVE_NO_SNPRINTF_BUG )
+ SET ( _CL_HAVE_SNPRINTF_BUG 1 )
+ MESSAGE ( FATAL_ERROR "snprintf has a bug, and we don't have a replacement!" )
+ ENDIF ( NOT _CL_HAVE_NO_SNPRINTF_BUG )
+ ENDIF ( _CL_HAVE_FUNCTION_SNPRINTF )
+
+ #check that our swnprintf works correctly...
+ IF ( _CL_HAVE_FUNCTION_SNWPRINTF )
+ CHECK_CXX_SOURCE_RUNS("
+ #include <stdio.h>
+ #include <wchar.h>
+
+ int main(void)
+ {
+ wchar_t buf[5];
+ snwprintf(buf,5,L\"%s\",L\"foo\");
+ if ( wcslen(buf) != 3 )
+ return 1;
+ return 0;
+ }" _CL_HAVE_NO_SNWPRINTF_BUG)
+ IF ( NOT _CL_HAVE_NO_SNWPRINTF_BUG )
+ SET ( _CL_HAVE_SNWPRINTF_BUG 1 )
+ ENDIF ( NOT _CL_HAVE_NO_SNWPRINTF_BUG )
+ ENDIF ( _CL_HAVE_FUNCTION_SNWPRINTF )
+ ENDIF ( CMAKE_CROSSCOMPILING )
ENDMACRO ( CHECK_SNPRINTF )
--- clucene-core-2.3.3.4+dfsg.orig/src/shared/cmake/CheckAtomicFunctions.cmake
+++ clucene-core-2.3.3.4+dfsg/src/shared/cmake/CheckAtomicFunctions.cmake
@@ -3,7 +3,7 @@
MACRO ( CHECK_HAVE_GCC_ATOMIC_FUNCTIONS result )
# Do step by step checking,
-CHECK_CXX_SOURCE_RUNS("
+SET( CHECK_HAVE_GCC_ATOMIC_FUNCTIONS_SOURCE "
#include <cstdlib>
int main()
{
@@ -20,6 +20,13 @@
return EXIT_SUCCESS;
}
-" ${result} )
+")
+
+IF ( CMAKE_CROSSCOMPILING )
+ CHECK_CXX_SOURCE_COMPILES("${CHECK_HAVE_GCC_ATOMIC_FUNCTIONS_SOURCE}" ${result} )
+ MESSAGE ( WARNING "cannot check atomics during cross compilation, assuming that they work" )
+ELSE ( CMAKE_CROSSCOMPILING )
+ CHECK_CXX_SOURCE_RUNS("${CHECK_HAVE_GCC_ATOMIC_FUNCTIONS_SOURCE}" ${result} )
+ENDIF ( CMAKE_CROSSCOMPILING )
ENDMACRO ( CHECK_HAVE_GCC_ATOMIC_FUNCTIONS result )
--- clucene-core-2.3.3.4+dfsg.orig/src/shared/cmake/CheckErrorHandling.cmake
+++ clucene-core-2.3.3.4+dfsg/src/shared/cmake/CheckErrorHandling.cmake
@@ -3,7 +3,7 @@
MACRO ( CHECK_HAVE_FUNCTION_TRY_BLOCKS result )
#check for try/catch blocks
- CHECK_CXX_SOURCE_RUNS("
+ CHECK_CXX_SOURCE_COMPILES("
void foo() { try{ return; } catch( ... ){} }
int main(){ foo(); return 0; }" ${result})
IF ( NOT ${result} )
--- clucene-core-2.3.3.4+dfsg.orig/src/shared/cmake/DefineStaticSyntax.cmake
+++ clucene-core-2.3.3.4+dfsg/src/shared/cmake/DefineStaticSyntax.cmake
@@ -3,11 +3,17 @@
MACRO ( DEFINE_STATIC_SYNTAX )
#check which syntax of static const to use
- CHECK_CXX_SOURCE_RUNS("class x{public: static const int SCI=55; }; int main(){ x a; if ( a.SCI!=55 ) throw \"err\"; return 0; }" LUCENE_STATIC_CONSTANT_SYNTAX)
+ SET ( DEFINE_STATIC_SYNTAX_SOURCE "class x{public: static const int SCI=55; }; int main(){ x a; if ( a.SCI!=55 ) throw \"err\"; return 0; }")
+ IF ( CMAKE_CROSSCOMPILING )
+ MESSAGE ( WARNING "testing for \"static const\" using a compile-only test")
+ CHECK_CXX_SOURCE_COMPILES ( "${DEFINE_STATIC_SYNTAX_SOURCE}" LUCENE_STATIC_CONSTANT_SYNTAX)
+ ELSE ( CMAKE_CROSSCOMPILING )
+ CHECK_CXX_SOURCE_RUNS ( "${DEFINE_STATIC_SYNTAX_SOURCE}" LUCENE_STATIC_CONSTANT_SYNTAX)
+ endif ( CMAKE_CROSSCOMPILING )
IF ( LUCENE_STATIC_CONSTANT_SYNTAX )
SET ( LUCENE_STATIC_CONSTANT_SYNTAX "static const type assignment")
ELSE ( LUCENE_STATIC_CONSTANT_SYNTAX )
SET ( LUCENE_STATIC_CONSTANT_SYNTAX "enum { assignment }")
ENDIF ( LUCENE_STATIC_CONSTANT_SYNTAX )
-ENDMACRO ( DEFINE_STATIC_SYNTAX )
\ No newline at end of file
+ENDMACRO ( DEFINE_STATIC_SYNTAX )
--- End Message ---
--- Begin Message ---
Source: clucene-core
Source-Version: 2.3.3.4+dfsg-1.1
Done: Håvard F. Aasen <[email protected]>
We believe that the bug you reported is fixed in the latest version of
clucene-core, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Håvard F. Aasen <[email protected]> (supplier of updated clucene-core
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 31 Jul 2022 07:44:35 +0200
Source: clucene-core
Architecture: source
Version: 2.3.3.4+dfsg-1.1
Distribution: unstable
Urgency: medium
Maintainer: Fathi Boudra <[email protected]>
Changed-By: Håvard F. Aasen <[email protected]>
Closes: 971558 1016219
Changes:
clucene-core (2.3.3.4+dfsg-1.1) unstable; urgency=medium
.
* Non-maintainer upload.
* Add gcc12.patch, include 'ctime' header. Closes: #1016219
* Add cross.patch, makes package cross buildable. Closes: #971558
Thanks to Helmut Grohne for patch.
* Add Multi-Arch: same to libclucene-dev.
Checksums-Sha1:
8b6cfc17d3e828d71314b357a6a80015559742e3 1880 clucene-core_2.3.3.4+dfsg-1.1.dsc
01e8630439dda1130a43a10341958e41b9ef8ce1 10344
clucene-core_2.3.3.4+dfsg-1.1.debian.tar.xz
ca8c4dd3aaeba57602ffd8eb566f75b7831821ec 6471
clucene-core_2.3.3.4+dfsg-1.1_source.buildinfo
Checksums-Sha256:
0c9726cce24512f30e4249681e868bdf2270bd29b7bdaca65ed358ab8bad3ea0 1880
clucene-core_2.3.3.4+dfsg-1.1.dsc
c8506dd1b0d70962a10c97bd7173190daf4c9a88664a5dfdcd0a0485ba7c8dae 10344
clucene-core_2.3.3.4+dfsg-1.1.debian.tar.xz
a0f809260b29a69b18caf404d9063d9cee4c9f37f61f230599f76474f7fd6fd9 6471
clucene-core_2.3.3.4+dfsg-1.1_source.buildinfo
Files:
e48042aa6156b19a2d6b4e3480a8341b 1880 libs optional
clucene-core_2.3.3.4+dfsg-1.1.dsc
3d465f96ee73b6da249a14802c2e8a77 10344 libs optional
clucene-core_2.3.3.4+dfsg-1.1.debian.tar.xz
6e0b2a7cf75999ef6c0c26e14c4d4ea1 6471 libs optional
clucene-core_2.3.3.4+dfsg-1.1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQHEBAEBCgAuFiEEQGIgyLhVKAI3jM5BH1x6i0VWQxQFAmLmrggQHGJhZ2VAZGVi
aWFuLm9yZwAKCRAfXHqLRVZDFDNQDAD16HJ5RJOLySa/8MnppxxVof5JO+DtfWkZ
pJzN8tKJSFSiTKgnHHNxDH0k+tT1j/v2LlJofWuzatSyIC+HCPB1Xm6glHTdc6nm
+ponB1jzck1OBSbj4qrzT0lFusmwkOiKTinfTdu3hlvheHz97gMM5GSyp44lgyn4
1ZZeVnOtULUf6dL83NA5siNFIiL3ph2GDNIAIy3V3SNZgQn1NSeI7GYvz315dRAO
QetDBpyQoBps6aSarj1wTiInlyjQ+jaieejpkfB3wIH9tHsTTLThDUqkBY2p+H/b
p3FoZPAQe/MhsNaJ+6DGhtv8qnB7YA05K/Vvpp+T4SsXW5Ht6JLoJn65Rmx3eL5D
Cqrs9mswiSl4A53oVe8gxYqDZZUVK3T44Q39PHmVWnamDDMXXY6CRv+J1IglPwTd
7sNqDW5hK4R/0dpMzwBxSURyuybutHj1X5DiBFe64nbaI0YvDYCdO5lQBdWmmEEw
jQoTOxfUHPoAu+xEnrGZrag7uOiZGRU=
=6QaC
-----END PGP SIGNATURE-----
--- End Message ---
