Your message dated Sun, 09 Oct 2022 19:36:07 +0000
with message-id <[email protected]>
and subject line Bug#1019490: fixed in ndctl 74-2
has caused the Debian Bug report #1019490,
regarding ndctl FTCBFS: multiple reasons
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1019490: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1019490
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: ndctl
Version: 73-1
Tags: patch
User: [email protected]
Usertags: ftcbfs
ndctl regressed cross building. It added a meson check using cc.runs to
test for typeof. Such tests make cross builds fail. However, the test
can be easily rewritten as a compile check. Beyond that, debian/rules
confuses the terms "build" and "host". Please refer to man
dpkg-architecture for their definitions. I'm attaching a patch that
fixes both for your convenience.
Helmut
diff --minimal -Nru ndctl-74/debian/changelog ndctl-74/debian/changelog
--- ndctl-74/debian/changelog 2022-08-24 12:53:47.000000000 +0200
+++ ndctl-74/debian/changelog 2022-09-10 06:31:41.000000000 +0200
@@ -1,3 +1,12 @@
+ndctl (74-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: (Closes: #-1)
+ + cross.patch: Avoid an unnecessary compiler run test.
+ + Fix confusion of build and host.
+
+ -- Helmut Grohne <[email protected]> Sat, 10 Sep 2022 06:31:41 +0200
+
ndctl (74-1) unstable; urgency=medium
* New upstream release.
diff --minimal -Nru ndctl-74/debian/patches/cross.patch
ndctl-74/debian/patches/cross.patch
--- ndctl-74/debian/patches/cross.patch 1970-01-01 01:00:00.000000000 +0100
+++ ndctl-74/debian/patches/cross.patch 2022-09-10 06:31:39.000000000 +0200
@@ -0,0 +1,26 @@
+--- ndctl-74.orig/meson.build
++++ ndctl-74/meson.build
+@@ -231,19 +231,18 @@
+ conf.set('ENABLE_LOGGING', get_option('logging').enabled())
+ conf.set('ENABLE_DEBUG', get_option('dbg').enabled())
+
+-typeof = cc.run('''
+- int main() {
++typeof_code = '''
++ void func() {
+ struct {
+ char a[16];
+ } x;
+ typeof(x) y;
+
+- return sizeof(x) == sizeof(y);
++ char static_assert[2 * (sizeof(x) == sizeof(y)) - 1];
+ }
+ '''
+-)
+
+-if typeof.compiled() and typeof.returncode() == 1
++if cc.compiles(typeof_code)
+ conf.set('HAVE_TYPEOF', 1)
+ conf.set('HAVE_STATEMENT_EXPR', 1)
+ endif
diff --minimal -Nru ndctl-74/debian/patches/series
ndctl-74/debian/patches/series
--- ndctl-74/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ ndctl-74/debian/patches/series 2022-09-10 06:25:33.000000000 +0200
@@ -0,0 +1 @@
+cross.patch
diff --minimal -Nru ndctl-74/debian/rules ndctl-74/debian/rules
--- ndctl-74/debian/rules 2022-08-24 12:21:41.000000000 +0200
+++ ndctl-74/debian/rules 2022-09-10 06:31:41.000000000 +0200
@@ -27,7 +27,7 @@
dh_installinit -p ndctl --init-script=ndctl-monitor
override_dh_install:
- mv debian/tmp/usr/$(DEB_BUILD_MULTIARCH)/*
debian/tmp/usr/lib/$(DEB_BUILD_MULTIARCH)/
+ mv debian/tmp/usr/$(DEB_HOST_MULTIARCH)/*
debian/tmp/usr/lib/$(DEB_HOST_MULTIARCH)/
dh_install
override_dh_makeshlibs:
--- End Message ---
--- Begin Message ---
Source: ndctl
Source-Version: 74-2
Done: Adam Borowski <[email protected]>
We believe that the bug you reported is fixed in the latest version of
ndctl, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Adam Borowski <[email protected]> (supplier of updated ndctl package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 09 Oct 2022 21:07:29 +0200
Source: ndctl
Architecture: source
Version: 74-2
Distribution: unstable
Urgency: medium
Maintainer: Adam Borowski <[email protected]>
Changed-By: Adam Borowski <[email protected]>
Closes: 1019490
Changes:
ndctl (74-2) unstable; urgency=medium
.
[ Helmut Grohne ]
* Fix FTCBFS: (Closes: #1019490)
+ cross.patch: Avoid an unnecessary compiler run test.
+ Fix confusion of build and host.
Checksums-Sha1:
b897a9268eea60466a69b6e72d1db145e05fe658 2407 ndctl_74-2.dsc
08a17d8d09a2b78b3f2cbc769152c7216a6c85b0 11444 ndctl_74-2.debian.tar.xz
451b50cd215da7f3c98160268a88627d0e88c99c 7646 ndctl_74-2_source.buildinfo
Checksums-Sha256:
b7e78eb19dde5d0cb7997ae4c431521ca2cf09f11851ec9d213c71ce3185cf4f 2407
ndctl_74-2.dsc
143ac1e47fab94bb20fe957f64ba4d19fd3472d4ef1654916d2e8854ef7404f4 11444
ndctl_74-2.debian.tar.xz
9a92319e0b19078d3b501612599751f440cedf8d8e830f9a643520a7c634ba9c 7646
ndctl_74-2_source.buildinfo
Files:
a9ecf341a432002ef12cc5dc9018562f 2407 libs optional ndctl_74-2.dsc
cdad08c5fc76f41ecdbbc3ad8e7363f5 11444 libs optional ndctl_74-2.debian.tar.xz
4514e8bf7ed4b09c72e9eaa2b85f86d7 7646 libs optional ndctl_74-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAmNDHU0ACgkQweDZLphv
fH43sQ/8DcVP/I0p15keOySZ3IfvnaMM39eQOGvYbPFI8f3MjuxauLgw68VHDSqz
W6vIDAkGBaEhmscybJwmwojWbGo7zuA11gYg/bAuVwmRo4ZwFHKzRR6NaOT+hvPG
O6I/cNPJzGtdoF+O4Ralyl7//zrBdxCv6sZEKwJBKMqc9gsluOj8IpoOJVepncQA
HIJnZMS4KI3aEcQuRw4dc+PhuRG6dsOh6WeKGdV1eBtQGBpx2xOTEabNWa7Wblai
YIDVCsvVmjthJ2bwsXKY9qvFpIfFSB4TDqI4ky5oU5aLPDIACG2XfM2uzC9rad/1
UUwFra8lJIyxA+osadp/y1g0AGReECdHFYLTb2fScaFmbJJ8kF+9Y6yndFiu3jAe
gtTS3r4YPOxjf/xyJNcL0FoXrGffrPXKHBPzQvMv/D9cbdEVAGrhQIJONEueaZWt
RSumauTlcp75yvFDDjvlo20N4GBAvIkcDFcbXQDNuKM/H8cI5julihYZK2bo8E34
UFYq50KzVNdb5KLPnBa0py6NSh432S6i1RLS10IFKk5sq7U/oeWFTZdBO8Eh1+2C
4V4MIcBLFEC18ZY1XBCKRW81qim4cmKxDjWp2hyqV7X9yLsaOlWlGYlTumjrL3dg
UtEm8oLSZyTkh+AOuVQmZliGrtvVd1ImegAvO6Qj2RSzR6AlQWc=
=eX6e
-----END PGP SIGNATURE-----
--- End Message ---
