Your message dated Wed, 12 Oct 2022 00:20:37 +0000
with message-id <[email protected]>
and subject line Bug#1019062: fixed in opentracing-cpp 1.6.0-4
has caused the Debian Bug report #1019062,
regarding opentracing-cpp: FTBFS on riscv64
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1019062: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1019062
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: opentracing-cpp
Version: 1.6.0-2
Severity: normal
Tags: ftbfs patch
Justification: fails to build from source (but built successfully in the past)
X-Debbugs-Cc: [email protected]
Dear maintainer,
opentracing-cpp failed to build on riscv64 due to not linking libatomic:
```
[ 81%] Linking CXX executable ../../output/mocktracer_propagation_test
cd /<<PKGBUILDDIR>>/obj-riscv64-linux-gnu/mocktracer/test && /usr/bin/cmake -E
cmake_link_script CMakeFiles/mocktracer_propagation_test.dir/link.txt
--verbose=1
/usr/bin/c++ -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=.
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
-D_FORTIFY_SOURCE=2 -Wall -Wextra -Wl,-z,relro -Wl,-z,now -rdynamic
CMakeFiles/mocktracer_propagation_test.dir/propagation_test.cpp.o -o
../../output/mocktracer_propagation_test
-Wl,-rpath,/<<PKGBUILDDIR>>/obj-riscv64-linux-gnu/output
../../output/libopentracing_mocktracer.so.1.6.0
../../output/libopentracing.so.1.6.0 -ldl
/usr/bin/ld: ../../output/libopentracing_mocktracer.so.1.6.0: undefined
reference to `__atomic_exchange_1'
collect2: error: ld returned 1 exit status
make[3]: ***
[mocktracer/test/CMakeFiles/mocktracer_tracer_factory_test.dir/build.make:102:
output/mocktracer_tracer_factory_test] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-riscv64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:1097:
mocktracer/test/CMakeFiles/mocktracer_tracer_factory_test.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
/usr/bin/ld: ../../output/libopentracing_mocktracer.so.1.6.0: undefined
reference to `__atomic_exchange_1'
collect2: error: ld returned 1 exit status
make[3]: ***
[mocktracer/test/CMakeFiles/mocktracer_json_test.dir/build.make:102:
output/mocktracer_json_test] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-riscv64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:1151:
mocktracer/test/CMakeFiles/mocktracer_json_test.dir/all] Error 2
/usr/bin/ld: ../../output/libopentracing_mocktracer.so.1.6.0: undefined
reference to `__atomic_exchange_1'
collect2: error: ld returned 1 exit status
make[3]: ***
[mocktracer/test/CMakeFiles/mocktracer_tracer_test.dir/build.make:102:
output/mocktracer_tracer_test] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-riscv64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:1070:
mocktracer/test/CMakeFiles/mocktracer_tracer_test.dir/all] Error 2
/usr/bin/ld: ../../output/libopentracing_mocktracer.so.1.6.0: undefined
reference to `__atomic_exchange_1'
collect2: error: ld returned 1 exit status
make[3]: ***
[mocktracer/test/CMakeFiles/mocktracer_propagation_test.dir/build.make:102:
output/mocktracer_propagation_test] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-riscv64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:1124:
mocktracer/test/CMakeFiles/mocktracer_propagation_test.dir/all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/obj-riscv64-linux-gnu'
make[1]: *** [Makefile:169: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>/obj-riscv64-linux-gnu'
dh_auto_build: error: cd obj-riscv64-linux-gnu && make -j4 "INSTALL=install
--strip-program=true" VERBOSE=1 returned exit code 2
make: *** [debian/rules:6: binary-arch] Error 25
dpkg-buildpackage: error: debian/rules binary-arch subprocess returned exit
status 2
```
Full buildd log:
https://buildd.debian.org/status/fetch.php?pkg=opentracing-cpp&arch=riscv64&ver=1.6.0-3&stamp=1661892134&raw=0
I've attached a patch that fixes FTBFS on riscv64. Please let me know if I
missed anything.
Cheers,
Eric
-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 5.18.0-4-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Description: Link libatomic on riscv64 and fix FTBFS
Author: Eric Long <[email protected]>
Last-Update: 2022-09-03
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -155,6 +155,9 @@
list(APPEND LIBRARIES ${CMAKE_DL_LIBS})
endif()
+if (${CMAKE_SYSTEM_PROCESSOR} STREQUAL "riscv64")
+ list(APPEND LIBRARIES atomic)
+endif()
if (BUILD_SHARED_LIBS)
add_library(opentracing SHARED ${SRCS})
--- End Message ---
--- Begin Message ---
Source: opentracing-cpp
Source-Version: 1.6.0-4
Done: Stephen Gelman <[email protected]>
We believe that the bug you reported is fixed in the latest version of
opentracing-cpp, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Stephen Gelman <[email protected]> (supplier of updated opentracing-cpp package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 11 Oct 2022 16:20:18 -0500
Source: opentracing-cpp
Architecture: source
Version: 1.6.0-4
Distribution: unstable
Urgency: medium
Maintainer: Stephen Gelman <[email protected]>
Changed-By: Stephen Gelman <[email protected]>
Closes: 1019062
Changes:
opentracing-cpp (1.6.0-4) unstable; urgency=medium
.
* Fix build on riscv64. Thanks to Eric Long! (Closes: #1019062)
* Update standards version to 4.6.1.0
Checksums-Sha1:
b065201153437794c51ed2739bb89760b398de71 2017 opentracing-cpp_1.6.0-4.dsc
7d30fd68525e1272f7c4a03cef12314c34ee1859 4684
opentracing-cpp_1.6.0-4.debian.tar.xz
e2980b1a9500987b0bee944ee2bee95b0df3d916 7797
opentracing-cpp_1.6.0-4_amd64.buildinfo
Checksums-Sha256:
09ae6b43e38df9a6798d721bd76e5c610e20865415e4f6e2efedb7a218f6e9e0 2017
opentracing-cpp_1.6.0-4.dsc
793721cd2798c0a431a2d8b3c888c4f93f826bded0e28fc8f3ff70a97e8895dd 4684
opentracing-cpp_1.6.0-4.debian.tar.xz
e0dd0a525b954388a5eb5f03cafe37f365924f955680a3d821ebcd4eb85ca525 7797
opentracing-cpp_1.6.0-4_amd64.buildinfo
Files:
528f0e7a8b7313bfb2d0a67a38b8ed31 2017 libs optional opentracing-cpp_1.6.0-4.dsc
3da58d8b6a70a0f5cd007d15dcf406ee 4684 libs optional
opentracing-cpp_1.6.0-4.debian.tar.xz
64a0be687b8de47bd434ad25a0adecc2 7797 libs optional
opentracing-cpp_1.6.0-4_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJGBAEBCgAwFiEEPwDop1BN06KlsbfijqM4hED8f1wFAmNGBEwSHHNzZ2VsbUBk
ZWJpYW4ub3JnAAoJEI6jOIRA/H9ciY4QAJEcZSQryUzBK3cz+CYIs7n6O9wAfpRt
JVvBWiWkiVyRHNq6zGiqloBtJKcS0+SEgJVequwLjvYAeUNW6GJgu9fi8/KJUWNX
UjezQOgIsXtUhi86+y6MBgRnqy79f/2lcTP6pCRGP8QLOjyocWDPLHrBXjczBXdz
jvl+6IH88VG2+y6yguALzYGl09A9D8OJu3K5ex7cUqO2Z64LA8aC6RuYIwGRpvZR
wy4i6weXhzPVoAb5s/9uF/CIzcM234XVR9TxWOdRWrpv7qHo0YeNr2EAznjkZnYP
1tGUzFm7n+EUnHhXrwS2ktrb1wH29iqi6hKQLoh39QGieh+QPU19U54/D8hnFHdQ
BVMH1U3Ygp8rVvpdqRptFdIypvQec5YmI7YhrgzpPncs4xitqTTQ5QxXFs0Mdc6M
dVrETTdpe6MTEDtIIr+BwYk1GumWBvGhJDOAXosJ0oyiPI3Lc75ZeGUi8qLGA/5k
zKpLAyvijyJpWzV+4EFEWjrPIXB7tIfwnkhb2N4GnXHqasQcLnxZbJpQml5aIzyY
x/YmnNzmsip58xwVTec+c68lW1rpHdICVyeW3PjlwMdCjeHbsUEGntjxBSf4PuXH
gzYsmIJsmneeKTLE5wQk8LAF1jdGFOevqTtNSoIlfSGy6YdDoLgnunQ3dlbm23Vx
l5O/M3LgKzcy
=Oy4h
-----END PGP SIGNATURE-----
--- End Message ---
