Your message dated Thu, 20 Oct 2022 09:38:38 -0700
with message-id <87r0z278mp.fsf@contorta>
and subject line Re: Bug#831972: aboot: please make the build reproducible
has caused the Debian Bug report #831972,
regarding aboot: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
831972: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831972
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: aboot
Version: 1.0~pre20040408-4
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: timestamps locale
X-Debbugs-Cc: [email protected]
Hi!
While working on the "reproducible builds" effort [1], we have noticed
that aboot could not be built reproducibly.
It has a copy of the docbook2man-de-spec.pl script from docbook-utils,
which doesn't support SOURCE_DATE_EPOCH yet, so the timestamp
embedded into manpages varies with locale and build time.
The attached patch fixes this.
Regards,
Reiner
[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/doc/man/de/docbook2man-de-spec.pl b/doc/man/de/docbook2man-de-spec.pl
index 2eed901..d52b26a 100644
--- a/doc/man/de/docbook2man-de-spec.pl
+++ b/doc/man/de/docbook2man-de-spec.pl
@@ -78,6 +78,7 @@ Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.
use SGMLS; # Use the SGMLS package.
use SGMLS::Output; # Use stack-based output.
use SGMLS::Refs;
+use POSIX qw(strftime setlocale LC_TIME);
########################################################################
@@ -93,6 +94,10 @@ $blank_xrefs = 0;
$default_sect = "1";
$default_date = `date "+%d %B %Y"`; # L10N
+if ($ENV{SOURCE_DATE_EPOCH}) {
+ setlocale(LC_TIME, "C");
+ $default_date = strftime("%d %B %Y", gmtime($ENV{SOURCE_DATE_EPOCH} || time));
+}
while (@ARGV) {
my $arg = shift @ARGV;
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Version: 1.0~pre20200212-1
On 2016-07-20, Reiner Herrmann wrote:
> While working on the "reproducible builds" effort [1], we have noticed
> that aboot could not be built reproducibly.
> It has a copy of the docbook2man-de-spec.pl script from docbook-utils,
> which doesn't support SOURCE_DATE_EPOCH yet, so the timestamp
> embedded into manpages varies with locale and build time.
I cannot reproduce these issues locally with reprotest, nor on the
tests.reproducible-builds.org infrastructure since ~2020:
https://tests.reproducible-builds.org/debian/history/aboot.html
Presumably something was fixed either in the newer versions of aboot, or
in the toolchains used...
Marking as done.
live well,
vagrant
signature.asc
Description: PGP signature
--- End Message ---
