Your message dated Mon, 31 Oct 2022 09:19:30 +0000
with message-id <[email protected]>
and subject line Bug#1023138: fixed in clickhouse 18.16.1+ds-7.3~exp3
has caused the Debian Bug report #1023138,
regarding clickhouse: server aborts when it cannot set core file size.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1023138: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023138
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: clickhouse
Version: 18.16.1+ds-7.2
Severity: normal
Tags: patch
Dear maintainer,
when building in pbuilder, I get test suit errors. This is due that
in a pbuilder environment disables core dumps.
However, clickhouse tries to set maximium core size to 1GiB, which
does not work, as setrlimit cannot increase the limit.
The attached patch fixes that: It will first check if the user has
configured something, and if so, it will try to set the configuration
value (and fail if it cannot.)
If the user has not set a value in configuration, it will either
set it to 1GiB (as before) or the maximum allowed value.
As this code is used in the server code, the situation where this can
happen is not limited to pbuilder, but can also happen if an admin
turns off or limits core dumps less than 1GiB and not adapt config
accordingly.
--
tobi
-- System Information:
Debian Release: bookworm/sid
APT prefers stable-security
APT policy: (500, 'stable-security'), (500, 'unstable'), (500, 'testing'),
(500, 'stable'), (100, 'bullseye-fasttrack'), (100,
'bullseye-backports-staging'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.19.0-2-amd64 (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
--- a/libs/libdaemon/src/BaseDaemon.cpp
+++ b/libs/libdaemon/src/BaseDaemon.cpp
@@ -905,9 +905,17 @@
if (getrlimit(RLIMIT_CORE, &rlim))
throw Poco::Exception("Cannot getrlimit");
/// 1 GiB by default. If more - it writes to disk too long.
- rlim.rlim_cur = config().getUInt64("core_dump.size_limit", 1024 * 1024 * 1024);
+ auto wanted = config().getUInt64("core_dump.size_limit", 0);
+ if(!wanted) {
+ // configuration is not present -- default to 1 GiB, but only if current rlimits allows it.
+ wanted = std::min(1024*1024*1024, rlim.rlim_cur);
+ wanted = std::min(wanted, rlim.rlim_max);
+ }
- if (setrlimit(RLIMIT_CORE, &rlim))
+ auto orig = rlim.rlim_cur;
+ rlim.rlim_cur = wanted;
+
+ if (orig != wanted && setrlimit(RLIMIT_CORE, &rlim))
{
std::string message = "Cannot set max size of core file to " + std::to_string(rlim.rlim_cur);
#if !defined(ADDRESS_SANITIZER) && !defined(THREAD_SANITIZER) && !defined(MEMORY_SANITIZER) && !defined(SANITIZER) && !defined(__APPLE__)
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: clickhouse
Source-Version: 18.16.1+ds-7.3~exp3
Done: Tobias Frost <[email protected]>
We believe that the bug you reported is fixed in the latest version of
clickhouse, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Tobias Frost <[email protected]> (supplier of updated clickhouse package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 31 Oct 2022 08:46:48 +0100
Source: clickhouse
Architecture: source
Version: 18.16.1+ds-7.3~exp3
Distribution: experimental
Urgency: medium
Maintainer: Alexander GQ Gerasiov <[email protected]>
Changed-By: Tobias Frost <[email protected]>
Closes: 1023138
Changes:
clickhouse (18.16.1+ds-7.3~exp3) experimental; urgency=medium
.
* Add patch dont-fail-setrlimit.patch, avoid failing when server tries to
increases core dump size if not explictly configured. Closes: #1023138
* Skip test 00047_stored_aggregates_complex. Seems another rounding issue.
* test "with_server" hangs also on arm64. Do not execute it there.
Checksums-Sha1:
e898d78959aefbc747f333f32fc41323f24ea86c 3225
clickhouse_18.16.1+ds-7.3~exp3.dsc
33d8c3936331aec3612ed286115f487ed21a0854 27412
clickhouse_18.16.1+ds-7.3~exp3.debian.tar.xz
7fd21cfc91cd9b44ea293d7818f23054ae2d3b13 15102
clickhouse_18.16.1+ds-7.3~exp3_amd64.buildinfo
Checksums-Sha256:
969cec0fb30744d000989b20b963e538d20ecedaa60365a661c7f94d366f724d 3225
clickhouse_18.16.1+ds-7.3~exp3.dsc
5c838439987f7b8766458afc13337a69665f1b175501201a40b35ee7ec31b724 27412
clickhouse_18.16.1+ds-7.3~exp3.debian.tar.xz
882f8f293f74f1701f50941c48d0f50517619887872c7289ef3c40b942e34001 15102
clickhouse_18.16.1+ds-7.3~exp3_amd64.buildinfo
Files:
9d03441f6d9003989406029fbf995d17 3225 database optional
clickhouse_18.16.1+ds-7.3~exp3.dsc
8f985a9636f8fe3ff94e46a5929899c2 27412 database optional
clickhouse_18.16.1+ds-7.3~exp3.debian.tar.xz
26fc6bded7d1650b333aa5fff0de3b17 15102 database optional
clickhouse_18.16.1+ds-7.3~exp3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE/d0M/zhkJ3YwohhskWT6HRe9XTYFAmNfjgAACgkQkWT6HRe9
XTaqRw/9FrM7G4ETXFd/ZdcT35sCcOuCWcyfiCDXShztggGkNcK4tUQnqwsjvdLW
xJhNCdzL79biug9VI6f0XRwy1EUr53Wo+ANCQzLLcwo/xTaxpydbDX/YfJUL0V4J
WJM994hEHFBr4lM8y5WgAkjKOIfquc2bDqFGNdToKRwiYGFBFlJQnSTIgutYJ0U/
W4yDhtoxOnPErlUnFNdfzHlx5CUCY/PG5LgjfUkJM2LJNpCoS314CGTyUEbeLuVj
7fmVi451miw4bje8K1LFGPTdOdQkq6fh197+aUj5+Wc9jXURx0jcRp79hIRp7jxG
Ii5eOkgkRkd9ZN3lCZFi6EuLcjsNlLDQ3s2V7s2yZT8R/YX2O+WmSGDqx8ix4kMb
uM8wfyAKpao55OG4hqzp2gCscoxOHptbqvmYZxh0zAOOGd3TjZo0L0hp06j81z/i
CE9CwecklvOOfwCOF8XxlP/HjRBcSlkcLZ2DTWI7Hh7nb8A+jyFYIKqhjF4mYwyy
lszUK6HcuTHzVbDeu2/jZ8QfirWsiKbNibAzgyBQ3VepaJzbtRUlKI3lkpT9T9Ko
NByXsEYciUUks4REXSN+E15zCwtD9ixDaJcBd5YbgtgB63GiK2cB2fixZriSxoYh
hqAMruMhT1HDUX5Aug9mF/omRJsC3rlzKOTVGE1+eLuFjm5oVTU=
=D3ij
-----END PGP SIGNATURE-----
--- End Message ---
