Your message dated Sun, 13 Nov 2022 12:35:02 +0000
with message-id <[email protected]>
and subject line Bug#1023824: fixed in crmsh 4.4.0-3
has caused the Debian Bug report #1023824,
regarding crmsh: WARNING: crmadmin -S <HOST> unexpected output
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1023824: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023824
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: crmsh
Version: 4.4.0-2
Severity: important
Tags: upstream patch
Forwarded: https://github.com/ClusterLabs/crmsh/issues/970

Hi!

The output from pacemaker changed from what crmsh expects, which makes
certain commands now fail (in addition to causing WARNING and INFO output).

This is affecting us on our HA setup.

The (merged) upstream commit fixing this is
<https://github.com/ClusterLabs/crmsh/commit/f83aa41185dbc71a25a3def39d42356e503b1f96>,
which I'm attaching here for your convenience.

Thanks,
Guillem
From f83aa41185dbc71a25a3def39d42356e503b1f96 Mon Sep 17 00:00:00 2001
From: liangxin1300 <[email protected]>
Date: Wed, 11 May 2022 11:09:28 +0800
Subject: [PATCH] Fix: utils: wait4dc: Make change since output of 'crmadmin
 -S' changed(bsc#1199412)

---
 crmsh/utils.py | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/crmsh/utils.py b/crmsh/utils.py
index 9f2603a1..9ebce28f 100644
--- a/crmsh/utils.py
+++ b/crmsh/utils.py
@@ -895,15 +895,10 @@ def wait4dc(what="", show_progress=True):
             return False
         cmd = "crmadmin -S %s" % dc
         rc, s = get_stdout(add_sudo(cmd))
-        if not s.startswith("Status"):
-            logger.warning("%s unexpected output: %s (exit code: %d)", cmd, s, rc)
-            return False
-        try:
-            dc_status = s.split()[-2]
-        except:
-            logger.warning("%s unexpected output: %s", cmd, s)
+        if rc != 0:
+            logger.error("Exit code of command {} is {}".format(cmd, rc))
             return False
-        if dc_status == "S_IDLE":
+        if re.search("S_IDLE.*ok", s):
             if output_started:
                 sys.stderr.write(" done\n")
             return True
-- 
2.38.1


--- End Message ---
--- Begin Message ---
Source: crmsh
Source-Version: 4.4.0-3
Done: Valentin Vidic <[email protected]>

We believe that the bug you reported is fixed in the latest version of
crmsh, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Valentin Vidic <[email protected]> (supplier of updated crmsh package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 13 Nov 2022 13:18:35 +0100
Source: crmsh
Architecture: source
Version: 4.4.0-3
Distribution: unstable
Urgency: medium
Maintainer: Debian HA Maintainers 
<[email protected]>
Changed-By: Valentin Vidic <[email protected]>
Closes: 1023824
Changes:
 crmsh (4.4.0-3) unstable; urgency=medium
 .
   * d/patches: fix crmadmin parsing (Closes: #1023824)
   * d/tests: add test for resource restart
Checksums-Sha1:
 0ee4bc3ae925f0fff5bf4f5f78ff4c31cb23e6f1 2325 crmsh_4.4.0-3.dsc
 a5c100a55bd1ca9f23cb79006fd2121a803bb0c3 29000 crmsh_4.4.0-3.debian.tar.xz
 2c8fd20b6ee840767b4ce6b786aa900ed6302a59 6921 crmsh_4.4.0-3_source.buildinfo
Checksums-Sha256:
 9814c892b923bd5cac835982b2b5db2c845babe0542041c660bab89d58f49959 2325 
crmsh_4.4.0-3.dsc
 19bc1d30822e23fcb7dec006b0d4e4d641f9275c284866f654dd5749d33ee39a 29000 
crmsh_4.4.0-3.debian.tar.xz
 a77f0ef877119f27a38a5c2b79925d2c642d017bfd6fd2a9d3029574ccaf7825 6921 
crmsh_4.4.0-3_source.buildinfo
Files:
 0e315427620451306b08c95557053c21 2325 admin optional crmsh_4.4.0-3.dsc
 ba21aff787a17d723c6081eed1e0b662 29000 admin optional 
crmsh_4.4.0-3.debian.tar.xz
 f79e06a6277fe534c06772c7d977d646 6921 admin optional 
crmsh_4.4.0-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEExaW53cM9k/u2PWfIMofYmpfNqHsFAmNw4yQSHHZ2aWRpY0Bk
ZWJpYW4ub3JnAAoJEDKH2JqXzah7ltMP/0Oc/CxxVEaxAZaHdGaePasIzhwWFykv
yS9SJxSVQRQnIiomv6/gAJmz3HPncYu1ByjnBJySICkMkMmf+Zshuwq4702K03gA
NXYknxod46enis9Hmr9MueB3+t2+KL0chYRbarOHFvgKZNUkDPLbm1QlY3kuVJ8W
R1+DuoNF8cPkSf0P7GP3yq7KfX85R/nQtwpzq71Ry3XUJ+ajPvLvLwc4kaRWhcdA
oaK5kyFBBuz2GX+wEkTKHMjhIvgPZ9WMt0+ANw0Iq2FLbOWUI6ZZQqFq/tzTE8ED
tnwz1t5SxD7PmtW5e7pCZsMdml9ISWq3qoCQTrtZWX/9OQa4LAfFbUZGx9adoBO6
KLDY28Nf6P6SaZ3mMSS1j+LJyG9UO255HItvOoGPw80TdarOVHYz1W1XOBvKeLJj
A7CwoYmI2ZkK9NSIX4Wx/wbbKKGbgaAhY6jXf5mscUfCBjT19M+pdE7KllzMsXMs
tsQRl5iuclvf5V7OdUidNU/O249kolFXZPTv77QQbweKjad0SwxnFihecqKnoBFm
atG9ZIgyDHK/k9iepqhfBG7mOOzk+1LPuqGytBfIU2mnlwwmUkHMzYWNsbkz1PPI
yuGeoHYZnfg6hEDXVnY8I6KBd7fxFR1YgetPxl20foU6ZsT3AIE8elaqESLESDXn
uMmmTG+erZKc
=RbV+
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to