Your message dated Wed, 23 Nov 2022 15:53:25 +0100
with message-id <[email protected]>
and subject line Re: Bug#901719: ssh-askpass-fullscreen FTCBFS: upstream 
Makefile hard codes build architecture build tools
has caused the Debian Bug report #901719,
regarding ssh-askpass-fullscreen FTCBFS: upstream Makefile hard codes build 
architecture build tools
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
901719: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901719
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: ssh-askpass-fullscreen
Version: 0.3-3.1
Tags: patch upstream
User: [email protected]
Usertags: rebootstrap

ssh-askpass-fullscreen fails to cross build from source, because the
upstream Makefile hard codes gcc and pkg-config. The attached patch
makes them substitutable and that is enough to make
ssh-askpass-fullscreen cross build, because cdbs passes cross compilers
to make. Please consider applying the attached patch. Also please
consider replacing cdbs' simple patchsys with quilt. Thank you.

Helmut
--- a/Makefile
+++ b/Makefile
@@ -1,5 +1,6 @@
+PKG_CONFIG ?= pkg-config
 all:
-	gcc -o gtk2-ssh-askpass gtk2-ssh-askpass.c -lX11 `pkg-config --libs gtk+-2.0` `pkg-config --cflags gtk+-2.0`
+	$(CC) -o gtk2-ssh-askpass gtk2-ssh-askpass.c -lX11 `$(PKG_CONFIG) --libs --cflags gtk+-2.0`
 
 clean:
 	rm gtk2-ssh-askpass

--- End Message ---
--- Begin Message ---
Version: 1.2-1

On Wed, Nov 23, 2022 at 11:48:53AM +0100, Axel Beckert wrote:
> The new upstream switched the build system to autotools, so there's no
> more a Makefile to patch anymore. Chances that this issue is also
> fixed by this switch seem quite high.

In this case, you may just FTCBFS bugs without checking, because that'll
trigger a retest for me.

> Can you check if this issue is still present in the recently uploaded
> 1.2-1 package?

There actually is an easy way for you to do yourself. The package
tracking system has a little "cross" link in the links section. That
leads to https://crossqa.debian.net/src/ssh-askpass-fullscreen. At the
time of your mail, the new version hasn't been checked yet, but there is
a "cross build" button to request a build. I've clicked it for you and a
minute later, it got an "ok" build. So if you prefer checking, you can
do it yourself at low effort now. :)

Helmut

--- End Message ---

Reply via email to