Your message dated Wed, 23 Nov 2022 21:07:46 +0000
with message-id <[email protected]>
and subject line Bug#977118: fixed in insighttoolkit4 4.13.3withdata-dfsg2-4
has caused the Debian Bug report #977118,
regarding insighttoolkit4: remove_gcc_version_test.patch causes excessive 
warnings
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
977118: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977118
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: insighttoolkit4
Version: 4.13.3withdata-dfsg1-3
Severity: normal


I'm sure there is a good reason for the remove_gcc_version_test.patch which 
removes a load of variable setting by GCC presence and version in 
Modules/ThirdParty/VNL/src/vxl/vcl/vcl_compiler.h

However, doing this causes VCL_GCC not to be defined which causes this snippet 
further down the file to use the definition with 'export' on the end:
// if the compiler doesn't understand "export", we just leave it out.
// gcc understands it, but ignore it noisily.
// icc understands it, but ignore it noisily.
#if !VCL_HAS_EXPORT || defined(VCL_GCC) || defined(VCL_ICC)
# define VCL_TEMPLATE_EXPORT /* ignore */
#else
# define VCL_TEMPLATE_EXPORT export
#endif

Every time that define is used we get pointless warning noise of the form;
insighttoolkit4/Modules/ThirdParty/VNL/src/vxl/vcl/vcl_compiler.h:114:30: 
 warning: keyword 'export' not implemented, and will be ignored

That wouldn't matter too much except that it occurs 31,024 times (!)
during the build, which really does distract from things which might
actually be real issues and bloats the log.

Removing that patch so that VCL_GCC gets set makes this problem go away.

So, is that patch still useful, and why?

Can we please at least leave this bit:
#if defined(__GNUC__) && !defined(__ICC) // icc 8.0 defines __GNUC__
# define VCL_GCC
#endif

to kill the epic level of 'export' whinges?

--
Wookey

--- End Message ---
--- Begin Message ---
Source: insighttoolkit4
Source-Version: 4.13.3withdata-dfsg2-4
Done: Étienne Mollier <[email protected]>

We believe that the bug you reported is fixed in the latest version of
insighttoolkit4, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Étienne Mollier <[email protected]> (supplier of updated insighttoolkit4 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 23 Nov 2022 20:50:27 +0100
Source: insighttoolkit4
Architecture: source
Version: 4.13.3withdata-dfsg2-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Med Packaging Team 
<[email protected]>
Changed-By: Étienne Mollier <[email protected]>
Closes: 977118
Changes:
 insighttoolkit4 (4.13.3withdata-dfsg2-4) unstable; urgency=medium
 .
   * d/rules: add -fno-sized-deallocation; fix ftbfs with gcc-12.
     Note the packaging still fails with gcc-12, but due to failing test items.
   * denoise-build-log.patch: added to reduce a bit the size of build logs.
     (Closes: #977118)
   * d/{control,rules}: revert to build using gcc-11.
     Work around test failures occurring only with gcc-12.
   * d/rules: disable python wrappers.
     This resolves another failure to build from source, and substancially
     reduces the build time, but renders the insighttoolkit4-python3
     package useless.
   * d/NEWS: inform end users about the disabled python wrappers.
   * d/control: remove the now empty insighttoolkit4-python3 package.
Checksums-Sha1:
 a47b69d6b1a2dd30c9ef73771044e6e710b41b0f 2802 
insighttoolkit4_4.13.3withdata-dfsg2-4.dsc
 58a87fff9e8d6a9f794ca29e1a7ec01e088c0af6 29916 
insighttoolkit4_4.13.3withdata-dfsg2-4.debian.tar.xz
Checksums-Sha256:
 0eeefcebd3f4252e466a69539cba3320cde888ba477fd35afe76ab75279a2c38 2802 
insighttoolkit4_4.13.3withdata-dfsg2-4.dsc
 134e00a92ee9b31befad594aec4661a93fa9a2433548a990fd5a5cc1dc16ff12 29916 
insighttoolkit4_4.13.3withdata-dfsg2-4.debian.tar.xz
Files:
 63457b3182220c5117d58ba4b995dcea 2802 science optional 
insighttoolkit4_4.13.3withdata-dfsg2-4.dsc
 55f592d8ae34ea2e9f89e9d51421e46d 29916 science optional 
insighttoolkit4_4.13.3withdata-dfsg2-4.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCgAyFiEEj5GyJ8fW8rGUjII2eTz2fo8NEdoFAmN+hvgUHGVtb2xsaWVy
QGRlYmlhbi5vcmcACgkQeTz2fo8NEdq+YQ//UWDVt6bxHHdpNxDcphX8hSySADfI
IogFXez7OtxtKj71XPtRVAtkoshMZe+sDFLwmUnIIObTDhgViAguPW6/P6rn5ok8
tkv8xZH071BFg7F/MEFhkR7mC5Ufg6G+tvefobN7tjgTKR0VYvMMRko6xPLhgosf
MyrqbwU4v0eRN82uw9Z9ZYfLQy3KjUJKWfU13yGHmiNICs5eROXC/9xQuwBxY9MO
qqYVsJr+GnSdZQNeY7e8n3AOIwrrS9TMZ63Ixvy4PxkFkONt1WoOsDyeU+KOxEPS
vqiB8w9u2ctYvFy+swVS7zKKCAOv0sJ58qabuRsopOK4yITo4NYIEc2Se+jSxt4N
OjgD2NG2rxiOrIIJVI0fSU4/BymRprDlf5TK6USS+tNcL1i+BfYP6UuGPendefu5
1RN6mwPqfdPHgqgPuXnuDZVRokkBPGyZwB+CtLAS9ph2RI3I/PIar1GH/NUbtoRH
oLxjzCKtIq/IWeHebK3Gf5nW0TSzpO+Ch+sU8DMcgO3BEfh9sHyFjERoAZlTWJcX
4g4cJ0eaDI+YelfnD+udUSfvP8snCTsKShJTH6N4R7scAISjYIh7/UqOOWF3hXSw
KtYJI9Yh5uPJmb660XC8ZVSfkwE0gD7bvcCTUhLqqMJT4MYMwfrjb5QUDoZSvy0R
QutzxrBVpuWlYnY=
=HjhT
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to