Your message dated Fri, 25 Nov 2022 06:50:22 +0000
with message-id <e1oysxw-00hkoz...@fasolo.debian.org>
and subject line Bug#1023616: fixed in opensbi 1.1-2
has caused the Debian Bug report #1023616,
regarding opensbi: Emulation of fence.tso hangs in endless loop
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1023616: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023616
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: opensbi
Version: 1.1-1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu lunar ubuntu-patch
Dear Maintainer,
* Fix emulation of fence.tso hanging in endless loop on Allwinner D1
d/p/lib-sbi_illegal_insn-Fix-FENCE.TSO-emulation-infinit.patch
(LP: #1995860)
Thanks for considering the patch.
Best regards
Heinrich
-- System Information:
Debian Release: bookworm/sid
APT prefers lunar-proposed
APT policy: (500, 'lunar-proposed'), (500, 'lunar')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.19.0-21-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru
opensbi-1.1/debian/patches/lib-sbi_illegal_insn-Fix-FENCE.TSO-emulation-infinit.patch
opensbi-1.1/debian/patches/lib-sbi_illegal_insn-Fix-FENCE.TSO-emulation-infinit.patch
---
opensbi-1.1/debian/patches/lib-sbi_illegal_insn-Fix-FENCE.TSO-emulation-infinit.patch
1970-01-01 01:00:00.000000000 +0100
+++
opensbi-1.1/debian/patches/lib-sbi_illegal_insn-Fix-FENCE.TSO-emulation-infinit.patch
2022-11-07 14:25:01.000000000 +0100
@@ -0,0 +1,36 @@
+From 111afc12306e4368fa112f97d31ea802c4561294 Mon Sep 17 00:00:00 2001
+From: Rahul Pathak <rpat...@ventanamicro.com>
+Date: Fri, 12 Aug 2022 19:24:42 +0530
+Subject: [PATCH] lib: sbi_illegal_insn: Fix FENCE.TSO emulation infinite trap
+ loop
+
+In case of missing "FENCE.TSO" instruction implementation,
+opensbi can emulate the "FENCE.TSO" with "FENCE RW,RW", but
+mepc was not incremented to continue from the next instruction
+causing infinite trap.
+
+Fixes: cb8271c8 ("lib: sbi_illegal_insn: Add emulation for fence.tso")
+Signed-off-by: Rahul Pathak <rpat...@ventanamicro.com>
+Reviewed-by: Andrew Jones <ajo...@ventanamicro.com>
+Reviewed-by: Xiang W <wxj...@126.com>
+Reviewed-by: Samuel Holland <sam...@sholland.org>
+Origin:
https://github.com/riscv-software-src/opensbi/commit/111afc12306e4368fa112f97d31ea802c4561294
+---
+ lib/sbi/sbi_illegal_insn.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/lib/sbi/sbi_illegal_insn.c b/lib/sbi/sbi_illegal_insn.c
+index ecd3508..9691bce 100644
+--- a/lib/sbi/sbi_illegal_insn.c
++++ b/lib/sbi/sbi_illegal_insn.c
+@@ -40,6 +40,7 @@ static int misc_mem_opcode_insn(ulong insn, struct
sbi_trap_regs *regs)
+ /* Errata workaround: emulate `fence.tso` as `fence rw, rw`. */
+ if ((insn & INSN_MASK_FENCE_TSO) == INSN_MATCH_FENCE_TSO) {
+ smp_mb();
++ regs->mepc += 4;
+ return 0;
+ }
+
+--
+2.37.2
+
diff -Nru opensbi-1.1/debian/patches/series opensbi-1.1/debian/patches/series
--- opensbi-1.1/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ opensbi-1.1/debian/patches/series 2022-11-07 13:18:42.000000000 +0100
@@ -0,0 +1 @@
+lib-sbi_illegal_insn-Fix-FENCE.TSO-emulation-infinit.patch
--- End Message ---
--- Begin Message ---
Source: opensbi
Source-Version: 1.1-2
Done: Vagrant Cascadian <vagr...@debian.org>
We believe that the bug you reported is fixed in the latest version of
opensbi, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1023...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Vagrant Cascadian <vagr...@debian.org> (supplier of updated opensbi package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 24 Nov 2022 21:45:21 -0800
Source: opensbi
Architecture: source
Version: 1.1-2
Distribution: unstable
Urgency: medium
Maintainer: Vagrant Cascadian <vagr...@debian.org>
Changed-By: Vagrant Cascadian <vagr...@debian.org>
Closes: 1023616
Changes:
opensbi (1.1-2) unstable; urgency=medium
.
[ Lintian Brush ]
* Set upstream metadata fields: Bug-Database, Bug-Submit, Repository,
Repository-Browse.
.
[ Heinrich Schuchardt ]
* Fix emulation of fence.tso hanging in endless loop on Allwinner D1
d/p/lib-sbi_illegal_insn-Fix-FENCE.TSO-emulation-infinit.patch (LP:
#1995860) (Closes: #1023616)
Checksums-Sha1:
c0e2d184c76ddc724cd0393f9dc787f91dbada33 1303 opensbi_1.1-2.dsc
2cc620557bc246a86455b0def8afd69090b03b25 5988 opensbi_1.1-2.debian.tar.xz
5aa1ae22766626205f09b1acc54ff28f4460a5e5 5812 opensbi_1.1-2_arm64.buildinfo
Checksums-Sha256:
242f4be9690bbce86b8eb97a636bb76eb0c95f3121fa9ead7181e00a21df6e07 1303
opensbi_1.1-2.dsc
3fd941d4733e25a924f952da4410dc7ce5070411facff65fbb45faad4d600314 5988
opensbi_1.1-2.debian.tar.xz
5fa229045799c4490f44e6ea1830a3c9c28e6f325393b369a6be3d6628c09ec8 5812
opensbi_1.1-2_arm64.buildinfo
Files:
bfb2023419ad39f0d6863e0e841a0c60 1303 misc optional opensbi_1.1-2.dsc
c620e44fdffd3b2168a9d391acc4c4e8 5988 misc optional opensbi_1.1-2.debian.tar.xz
850891e91e3b769df8896a7da8486b12 5812 misc optional
opensbi_1.1-2_arm64.buildinfo
-----BEGIN PGP SIGNATURE-----
iIkEARYKADEWIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY4Bh8xMcdmFncmFudEBk
ZWJpYW4ub3JnAAoJENxRj8h/lxaqJosA/1sFKdmuFBp7JCWBiQQIlZFJGrVbsfCU
G4uAwVUaeaXOAQCxdLUourbGwqvJIBw7wYtBJ+7RX8cymIPAOzA9rS3ODA==
=9muz
-----END PGP SIGNATURE-----
--- End Message ---
