Your message dated Sat, 26 Nov 2022 03:04:00 +0000
with message-id <e1oylu0-004rzf...@fasolo.debian.org>
and subject line Bug#1023413: fixed in dh-cargo 30
has caused the Debian Bug report #1023413,
regarding dh-cargo: should prevent dh_clean from removing Cargo.toml.orig
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1023413: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023413
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: dh-cargo
Version: 28
Control: affects -1 debhelper src:rust-document-features debcargo
When packaging Rust crates, the rust-team typically packages from the
bundles published on crates.io. Those are published with a modified
version of Cargo.toml, and the original upstream source for Cargo.toml
is present as Cargo.toml.orig.
debhelper's dh_clean by default removes all files matching *.orig, which
means that the upstream Cargo.toml.orig is getting stripped before the
build happens. (dh_clean is typically invoked before a build)
This is problematic for tools like the document-features crate, which
relies on comments in Cargo.toml.orig to extract documention about the
features of any given crate.
See the upstream discussion at
https://github.com/slint-ui/document-features/issues/15
If dh-cargo were able to force the exclusion Cargo.toml.orig, that would
be great, but i tried hacking on the clean() function in cargo.pm to
push something into @{dh{EXCLUDE}} and i couldn't get it to work. Maybe
someone who knows debhelper or dh-cargo better than me can figure out
how to do it.
Or, maybe a newer version of debhelper itself could just generically
avoid destroying Cargo.toml.orig in the top-level of any source tree,
even though it removes all the other *.orig files ?
Alternately, debcargo could be modified to add the following stanza to
its autogenerated debian/rules:
--- debian/rules
+++ debian/rules
@@ -4,3 +4,6 @@
override_dh_auto_test:
dh_auto_test -- test --all
+
+override_dh_clean:
+ dh_clean -XCargo.toml.orig
If the dh-cargo folks think it should be fixed in either debhelper or
debcargo, feel free to reassign this bug report.
Thanks,
--dkg
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: dh-cargo
Source-Version: 30
Done: Daniel Kahn Gillmor <d...@fifthhorseman.net>
We believe that the bug you reported is fixed in the latest version of
dh-cargo, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1023...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Daniel Kahn Gillmor <d...@fifthhorseman.net> (supplier of updated dh-cargo
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 26 Nov 2022 09:45:44 +0700
Source: dh-cargo
Architecture: source
Version: 30
Distribution: unstable
Urgency: medium
Maintainer: Rust Maintainers <pkg-rust-maintain...@lists.alioth.debian.org>
Changed-By: Daniel Kahn Gillmor <d...@fifthhorseman.net>
Closes: 1023413
Changes:
dh-cargo (30) unstable; urgency=medium
.
* wrap-and-sort -ast
* Add Provides: dh-sequence-cargo
* Avoid stripping Cargo.toml.orig (Closes: #1023413)
* Declare Rules-Requires-Root: no
* Clarify package description, clearing using-first-person-in-description
* d/copyright: correct Source URL to point explicitly to salsa
* d/copyright: update dates, include other contributors
* Add myself to uploaders
Checksums-Sha1:
3f78f3ba5c27db6ac7c27e0cde2706db1e22c962 1054 dh-cargo_30.dsc
7e9d62c4f9976d17464838e4048ed8165959fc23 9768 dh-cargo_30.tar.xz
920f4d5293834b5193a15440a23f2c06a7b8daee 6819 dh-cargo_30_amd64.buildinfo
Checksums-Sha256:
c481fcc4886ca42c8ae6b3f27ce2e12bb432bf7dea597850dfe5e07d681b2cc6 1054
dh-cargo_30.dsc
65a53d8f89e03c06d6316e218f9d6de4a8c6c2fcfec36e7824c0ef245ffc49b7 9768
dh-cargo_30.tar.xz
eb32267ea3ba6330b0ddd390354df83233c2a2cb4c90eec5f575334d25df78d7 6819
dh-cargo_30_amd64.buildinfo
Files:
903f6a2db35bbab0808973f420b55783 1054 devel optional dh-cargo_30.dsc
0a9eecc1ea058a7889c820f9ac23c576 9768 devel optional dh-cargo_30.tar.xz
1b01fc10bb11df16e625fb73b148f24a 6819 devel optional
dh-cargo_30_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iHUEARYIAB0WIQQttUkcnfDcj0MoY88+nXFzcd5WXAUCY4F+HwAKCRA+nXFzcd5W
XFoRAP9e0Sr5dN4iJcwB7ltvo+GMUfZbR9dbKsbYSa46uzu0/QEA8ldRYwFp2/+F
vVAQgxbpVUls+WDWmiRI/u/vFjUcGAE=
=AweO
-----END PGP SIGNATURE-----
--- End Message ---
