Your message dated Mon, 02 Jan 2023 15:04:06 +0000
with message-id <[email protected]>
and subject line Bug#1027014: fixed in debhelper 13.11.4
has caused the Debian Bug report #1027014,
regarding debhelper: pass --destdir to `meson install`
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1027014: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027014
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: debhelper
Version: 13.11.3
Severity: normal
Tags: patch
X-Debbugs-Cc: [email protected]

Hi,

First of all, thanks a lot for making Debian packaging a lot easier by
working on debhelper!

What do you think of the attached patch (also tracked in a Salsa merge request,
https://salsa.debian.org/debian/debhelper/-/merge_requests/101) that makes
the new `meson install` invocation pass the destdir as an argument to
`--destdir` instead of a positional parameter? I stumbled upon this when
I tried to use the new buildsystem functionality in the libmodulemd package:
putting 14 in debian/compat and changing the debhelper-compat B-D to
debhelper (>> 13.11~) made the build fail:

       dh_auto_install
            cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 meson install 
/<<PKGBUILDDIR>>/debian/tmp
    usage: meson [-h]
                 
{setup,configure,dist,install,introspect,init,test,wrap,subprojects,rewrite,compile,devenv,env2mfile,help}
                 ...
    meson: error: unrecognized arguments: /<<PKGBUILDDIR>>/debian/tmp
    dh_auto_install: error: cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 meson 
install /<<PKGBUILDDIR>>/debian/tmp returned exit code 2
    make: *** [debian/rules:8: binary] Error 25
    dpkg-buildpackage: error: debian/rules binary subprocess returned exit 
status 2

Thanks again for all your work on Debian!

G'luck,
Peter

-- System Information:
Debian Release: bookworm/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'stable-updates'), (500, 
'stable-security'), (500, 'oldstable-updates'), (500, 'oldoldstable'), (500, 
'stable'), (500, 'oldstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.0.0-6-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages debhelper depends on:
ii  autotools-dev            20220109.1
ii  dh-autoreconf            20
ii  dh-strip-nondeterminism  1.13.0-2
ii  dpkg                     1.21.13
ii  dpkg-dev                 1.21.13
ii  dwz                      0.14+20220924-2
ii  file                     1:5.41-4
ii  libdebhelper-perl        13.11.3
ii  libdpkg-perl             1.21.13
ii  man-db                   2.11.1-1
ii  perl                     5.36.0-6
ii  po-debconf               1.0.21+nmu1

debhelper recommends no packages.

Versions of packages debhelper suggests:
pn  dh-make  <none>

-- no debconf information
From 70705d6429387f2142676b42d53dead01b547c09 Mon Sep 17 00:00:00 2001
From: Peter Pentchev <[email protected]>
Date: Mon, 26 Dec 2022 11:57:01 +0200
Subject: [PATCH] Pass --destdir to `meson install`

The `meson install` subcommand does not like a directory passed directly as
a positional argument.
---
 lib/Debian/Debhelper/Buildsystem/meson.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/Debian/Debhelper/Buildsystem/meson.pm 
b/lib/Debian/Debhelper/Buildsystem/meson.pm
index 9d11b2c6..d82512f3 100644
--- a/lib/Debian/Debhelper/Buildsystem/meson.pm
+++ b/lib/Debian/Debhelper/Buildsystem/meson.pm
@@ -136,6 +136,7 @@ sub test {
 
 sub install {
        my $this = shift;
+       my ($destdir) = @_;
        my $target = $this->get_targetbuildsystem;
 
        if (compat(13) or $target->NAME ne 'ninja') {
@@ -148,7 +149,7 @@ sub install {
                                'LC_ALL' => 'C.UTF-8',
                        }
                );
-               $this->doit_in_builddir(\%options, 'meson', 'install', @_);
+               $this->doit_in_builddir(\%options, 'meson', 'install', 
'--destdir', $destdir);
        }
        return 1;
 }
-- 
2.35.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: debhelper
Source-Version: 13.11.4
Done: Niels Thykier <[email protected]>

We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Niels Thykier <[email protected]> (supplier of updated debhelper package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 02 Jan 2023 14:54:26 +0000
Source: debhelper
Architecture: source
Version: 13.11.4
Distribution: unstable
Urgency: medium
Maintainer: Debhelper Maintainers <[email protected]>
Changed-By: Niels Thykier <[email protected]>
Closes: 1027014
Changes:
 debhelper (13.11.4) unstable; urgency=medium
 .
   [ Peter Pentchev ]
   * meson.pm: Pass --destdir to `meson install`.  (Closes: #1027014)
Checksums-Sha1:
 c084735068d81706a6b41deb77efc75d71dcb1dd 1793 debhelper_13.11.4.dsc
 dec667c5cde6bc71666e00e51f49501319958e8a 580484 debhelper_13.11.4.tar.xz
 d38158f5d9748f395bf5289e0919b02aa2cbfd64 5452 
debhelper_13.11.4_source.buildinfo
Checksums-Sha256:
 45bb36ef9fd32737da31fe44cc0243c6c488f2c6d45e64ece6db1da5353957fa 1793 
debhelper_13.11.4.dsc
 9ed846bb34f1a5501894d06c9f30e4831f9c18e0b03e1a177ceac7eb63212b42 580484 
debhelper_13.11.4.tar.xz
 7e4a0053c89901ee7ac9f68d6d28465b6dd5bf1a93136155d7880e8ccddb64ba 5452 
debhelper_13.11.4_source.buildinfo
Files:
 039d3548b5b2579e72f37e2e3cd6ce60 1793 devel optional debhelper_13.11.4.dsc
 ddb659a58a9b0da2ec0e5dbe73c5d69f 580484 devel optional debhelper_13.11.4.tar.xz
 70e10db951d598236641e39dabc7f22e 5452 devel optional 
debhelper_13.11.4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEE8f9dDX4ALfD+VfsMplt42+Z8eqwFAmOy8EsSHG5pZWxzQHRo
eWtpZXIubmV0AAoJEKZbeNvmfHqsS+cQAM48dXSL3HrVpt6vx489eskciSSiNtz4
mIW8kSViulZsBD/hJc0HkEG3MMJCpfb6Gm8a+7iIfqaZ76oK2olakyMwAEJJO86M
4Jr+k0YuQq1kE3qlVSUstFljFZZ2P5ucUA+YBV3hkZiktavHnNIfB/s5N+9PVB9b
At8rulDbaDK1bIqZ6QqrwnG/Jm4VgOYOcUygbKBSn5QIUgyQY1T9GBUjdeKCbnYO
2GfhoUTsYM0f9V6NQlgDN3L3tO6sz/URi3/dtyuJlCgybNMJdLBNMKU52dNB+V7E
Ym2U1TUr5GREkPjOGPzkfLcdlQJZyyhUEC9iiN0NXfg6vkMaNwbOo9Zwap5z5gl9
Uz1712xNFxsbP7NeV63xp8o+vLYYQVq08p3D27WNeMZmhBsxlIwq2LdGkUjPRsLa
iU+REDGPCX3Pm00YwX+6qy6Rwy8FAw5Jli3qf+oeEs0nCNHrSVANwAIpI2laBRKV
3YgCMgfoYWD9rcOrCfUbdJ1NdoD+uipKioDRwFwaVrP2B8w0ONqx/npZQRfreXA1
X6AR2M13OGK31+wuS2YdNgu/SIGYuL0duCka5XvSgOsq8UXxEPuELgg8CQ0ykcDu
c5gcV2NM34Gpo32WFVL1d/QAzxBBs2rE7gU405UyulZA3TJAFp4x2asR5l+JVR44
iL6m26oDCAWB
=tPZt
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to