Your message dated Wed, 04 Jan 2023 13:06:49 +0000
with message-id <[email protected]>
and subject line Bug#1027829: fixed in pflogsumm 1.1.5-8
has caused the Debian Bug report #1027829,
regarding pflogsumm ignores header filter rejects in postfix logs
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1027829: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027829
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: pflogsumm
Version: 1.1.5-7
Severity: normal
Tags: patch

pflogsumm ignores emails rejected by non-milter cleanup mechanisms such
as header filtering. This because of a bug/typo in the milter-rejects
patch which was added in #743570: 
https://sources.debian.org/patches/pflogsumm/1.1.5-7/milter-rejects/

With the milter-rejects patch, plain 'reject:' loglines are ignored and only
'milter-reject:' loglines are counted.

Example of an ignored logline:

Dec 29 08:01:23 server postfix/cleanup[12345]: AEGIM3EE9EID: reject: header 
Received: from example.com (example.com [192.0.2.1])??by 
KooR3roh2ooxuk.server.example.org.example.com (x) with ESMTP ID: Eu_h4do??Thu, 
29 Dec 2022 08:01:23 +0100 from out.example.net[203.0.113.1]; 
from=<[email protected]> to=<[email protected]> proto=ESMTP 
helo=<out.example.net>: 5.7.1 Forged Received header


How to reproduce:
- echo 'Dec 29 08:01:23 server postfix/cleanup[12345]: AEGIM3EE9EID: reject: 
header Received: from example.com (example.com [192.0.2.1])??by 
KooR3roh2ooxuk.server.example.org.example.com (x) with ESMTP ID: Eu_h4do??Thu, 
29 Dec 2022 08:01:23 +0100 from out.example.net[203.0.113.1]; 
from=<[email protected]> to=<[email protected]> proto=ESMTP 
helo=<out.example.net>: 5.7.1 Forged Received header' > testlog
- pflogsumm testlog
- observe that 0 messages are reported


How to fix:
The regex in the milter-rejects patch has a bug/typo which causes it to
only match 'milter-reject:' but no longer match plain 'reject:'

+       /\/cleanup\[\d+\]: .*?\b((?:milter-)reject|warning|hold|discard): 
(header|body|END-OF-MESSAGE) (.*)$/) == 3)

The 'milter-' part should be optional to match both:

+       /\/cleanup\[\d+\]: .*?\b((?:milter-)?reject|warning|hold|discard): 
(header|body|END-OF-MESSAGE) (.*)$/) == 3)







-- System Information:
Debian Release: 11.6
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'stable-security')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-20-amd64 (SMP w/4 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages pflogsumm depends on:
ii  libdate-calc-perl  6.4-1.1
ii  perl               5.32.1-4+deb11u2

pflogsumm recommends no packages.

pflogsumm suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: pflogsumm
Source-Version: 1.1.5-8
Done: Sven Hoexter <[email protected]>

We believe that the bug you reported is fixed in the latest version of
pflogsumm, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sven Hoexter <[email protected]> (supplier of updated pflogsumm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 04 Jan 2023 13:36:16 +0100
Source: pflogsumm
Architecture: source
Version: 1.1.5-8
Distribution: unstable
Urgency: medium
Maintainer: Sven Hoexter <[email protected]>
Changed-By: Sven Hoexter <[email protected]>
Closes: 1027829
Changes:
 pflogsumm (1.1.5-8) unstable; urgency=medium
 .
   * Fix regex in milter-rejects patch. Kudos to Andreas Jaggi
     <[email protected]> for the report and patch. (Closes: #1027829)
   * Update debian/copyright for 2023.
   * Increase debhelper compat level from v12 to v13.
   * Update Standards-Version to 4.6.2, no changes required.
   * Add Rules-Requires-Root: no in debian/control.
   * Update debian/watch file to version 4.
Checksums-Sha1:
 45bb0c573c7af09428d3b31fd1ec8caea4fd1cfb 1852 pflogsumm_1.1.5-8.dsc
 fa09afc3ea9c3bb9e7252cb3a7ae18001755d581 8308 pflogsumm_1.1.5-8.debian.tar.xz
 d2c419b2ded972d40709081c3c1a91c8c00254a4 6105 pflogsumm_1.1.5-8_amd64.buildinfo
Checksums-Sha256:
 b388a305138b030bbfb86a1dfade7c9d1c3270b1e1cfc17d8c1b408d31b31055 1852 
pflogsumm_1.1.5-8.dsc
 eff60b5fc4c833a9136ee858299055feee52b67cbcfd24647459800a67eb0d1f 8308 
pflogsumm_1.1.5-8.debian.tar.xz
 7812c1a60e56796caef3c0fbf47c4c16157f5ca14f2972651edce634109fe3ba 6105 
pflogsumm_1.1.5-8_amd64.buildinfo
Files:
 0480205d3619e4bafdfb92f93a4585e4 1852 admin optional pflogsumm_1.1.5-8.dsc
 6de2fbd15ebfb89774d887efdd6b67ee 8308 admin optional 
pflogsumm_1.1.5-8.debian.tar.xz
 26ff351f2d66647203d6a2baf5e53e60 6105 admin optional 
pflogsumm_1.1.5-8_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEfAcX+forK514ixQbptwk2dokk9EFAmO1dBMACgkQptwk2dok
k9GQ9RAAjO5XG5hjRldX//sbo1NTLrMHxguYiCidOULBZflFaTKI4rdHn8CJgRgo
UkC6S1nDU8ivdoHOBny7HWO8nmCgDBiSHcSX5JGQLrhMC/QQFk2F4yJ4WylhEyh1
K8Rg3EExl9vKTFxwUUJQ2bL+Gqvmwkd0fS9rgvQIvnO2KE5zfhUxH+LEYOIYfYaz
gTcDiFl2vGW77+OE+hc+bi4lyCiGeS0oR3zEXMJMSQbN6P07Iud0JB9MP79swIfb
9t1Agb81Pf0/nXC5GynDwTFXtGguA0MSpKf2zI0lVxLRnUT6K+qao08mvEQwwymG
owK1a0v1gddgQJ6L130m3H2TxMY+rSgbAQZ7RqfaG8yEyXkyFnXzXuQ0RY2MIQFO
YCSsad9+3I5+CyP84G9ja8LRbw8ExXwakr2CjBikrMDEsgmhMB5uojw4gHChT3UA
JB0wGd9iOBp8l6oR1/r7muPALkD1pfqrd7HBDgXm/4A2JsXiNryl8JUxauPMhhfa
0JA360idqDkSk0MMASCvmvUJhNvOC4+3o+1EFjz3ubjEtrMrltajPQM5uRTgOTYN
OPPE93JmKNEBEy2L3WNwm6aQuwhCZxeFt1xdpfwfWuDPO97ynzq/5jmTTq8UIovU
47/4te0v3tEBu5YsQO8I/2nx+EijPGg1wfbiO6D5/NlmkywBEEY=
=wmUs
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to