Your message dated Wed, 04 Jan 2023 22:27:36 +0000
with message-id <[email protected]>
and subject line Bug#1021956: fixed in libvirt 8.10.0-3
has caused the Debian Bug report #1021956,
regarding Drop inlined and outdated maintscript code from dh_installsystemd
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1021956: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1021956
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libvirt
Version: 8.5.0-1
Severity: important
Tags: patch
Hi,
there were some recent changes in dh_installinit and dh_installsystemd
in now to handle removed but not purged packages. To read more on the
details you can check [1].
It seems, libvirt has some inlined, outdated copies of the generated
maintscript code from dh_installsystemd.
Since #994204 has been fixed, which was the reason to inline this code,
please reverting that change again.
The attached patch does that.
Thanks for considering.
Regards,
Michael
[1] https://salsa.debian.org/debian/debhelper/-/merge_requests/90
diff -Nru libvirt-8.5.0/debian/changelog libvirt-8.5.0/debian/changelog
--- libvirt-8.5.0/debian/changelog 2022-07-17 17:12:07.000000000 +0200
+++ libvirt-8.5.0/debian/changelog 2022-10-17 23:21:29.000000000 +0200
@@ -1,3 +1,11 @@
+libvirt (8.5.0-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Drop inlined copy of dh_installsystemd generated maintscript code now that
+ #994204 is fixed.
+
+ -- Michael Biebl <[email protected]> Mon, 17 Oct 2022 23:21:29 +0200
+
libvirt (8.5.0-1) unstable; urgency=medium
* [74b9b5c] New upstream version 8.5.0
diff -Nru libvirt-8.5.0/debian/libvirt-daemon-system.postinst
libvirt-8.5.0/debian/libvirt-daemon-system.postinst
--- libvirt-8.5.0/debian/libvirt-daemon-system.postinst 2022-07-17
17:12:07.000000000 +0200
+++ libvirt-8.5.0/debian/libvirt-daemon-system.postinst 2022-10-17
23:20:51.000000000 +0200
@@ -162,202 +162,6 @@
db_stop
-# Section copied verbatim from the output of dh_installsystemd/13.6
-#
-# Due to #994204, we are forced to handle systemd units ourselves to
-# avoid the restart of services/sockets which would result in VMs
-# being stopped or crashing.
-#
-# In order to do this, instead of calling dh_installsystemd in
-# debian/rules we take the output that those calls would generate
-# and hardcode it here, tweaking it as necessary to prevent the
-# problematic scenarios.
-if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" =
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
- # This will only remove masks created by d-s-h on package removal.
- deb-systemd-helper unmask 'libvirtd.service' >/dev/null || true
-
- # was-enabled defaults to true, so new installations run enable.
- if deb-systemd-helper --quiet was-enabled 'libvirtd.service'; then
- # Enables the unit on first installation, creates new
- # symlinks on upgrades if the unit file has changed.
- deb-systemd-helper enable 'libvirtd.service' >/dev/null || true
- else
- # Update the statefile to add new symlinks (if any), which need
to be
- # cleaned up on purge. Also remove old symlinks.
- deb-systemd-helper update-state 'libvirtd.service' >/dev/null
|| true
- fi
-fi
-if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" =
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
- if [ -z "${DPKG_ROOT:-}" ] && [ -d /run/systemd/system ]; then
- systemctl --system daemon-reload >/dev/null || true
- deb-systemd-invoke restart 'libvirtd.service' >/dev/null || true
- fi
-fi
-if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" =
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
- # This will only remove masks created by d-s-h on package removal.
- deb-systemd-helper unmask 'libvirt-guests.service' >/dev/null || true
-
- # was-enabled defaults to true, so new installations run enable.
- if deb-systemd-helper --quiet was-enabled 'libvirt-guests.service'; then
- # Enables the unit on first installation, creates new
- # symlinks on upgrades if the unit file has changed.
- deb-systemd-helper enable 'libvirt-guests.service' >/dev/null
|| true
- else
- # Update the statefile to add new symlinks (if any), which need
to be
- # cleaned up on purge. Also remove old symlinks.
- deb-systemd-helper update-state 'libvirt-guests.service'
>/dev/null || true
- fi
-fi
-if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" =
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
- # This will only remove masks created by d-s-h on package removal.
- deb-systemd-helper unmask 'virtlockd.service' >/dev/null || true
-
- # was-enabled defaults to true, so new installations run enable.
- if deb-systemd-helper --quiet was-enabled 'virtlockd.service'; then
- # Enables the unit on first installation, creates new
- # symlinks on upgrades if the unit file has changed.
- deb-systemd-helper enable 'virtlockd.service' >/dev/null || true
- else
- # Update the statefile to add new symlinks (if any), which need
to be
- # cleaned up on purge. Also remove old symlinks.
- deb-systemd-helper update-state 'virtlockd.service' >/dev/null
|| true
- fi
-fi
-if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" =
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
- # This will only remove masks created by d-s-h on package removal.
- deb-systemd-helper unmask 'virtlogd.service' >/dev/null || true
-
- # was-enabled defaults to true, so new installations run enable.
- if deb-systemd-helper --quiet was-enabled 'virtlogd.service'; then
- # Enables the unit on first installation, creates new
- # symlinks on upgrades if the unit file has changed.
- deb-systemd-helper enable 'virtlogd.service' >/dev/null || true
- else
- # Update the statefile to add new symlinks (if any), which need
to be
- # cleaned up on purge. Also remove old symlinks.
- deb-systemd-helper update-state 'virtlogd.service' >/dev/null
|| true
- fi
-fi
-if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" =
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
- if [ -z "${DPKG_ROOT:-}" ] && [ -d /run/systemd/system ]; then
- systemctl --system daemon-reload >/dev/null || true
- # We have already called 'reload' for virtlogd and virtlockd
earlier if they were active
- deb-systemd-invoke start 'libvirt-guests.service'
'virtlockd.service' 'virtlogd.service' >/dev/null || true
- fi
-fi
-if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" =
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
- # This will only remove masks created by d-s-h on package removal.
- deb-systemd-helper unmask 'libvirtd-admin.socket' >/dev/null || true
-
- # was-enabled defaults to true, so new installations run enable.
- if deb-systemd-helper --quiet was-enabled 'libvirtd-admin.socket'; then
- # Enables the unit on first installation, creates new
- # symlinks on upgrades if the unit file has changed.
- deb-systemd-helper enable 'libvirtd-admin.socket' >/dev/null ||
true
- else
- # Update the statefile to add new symlinks (if any), which need
to be
- # cleaned up on purge. Also remove old symlinks.
- deb-systemd-helper update-state 'libvirtd-admin.socket'
>/dev/null || true
- fi
-fi
-if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" =
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
- # This will only remove masks created by d-s-h on package removal.
- deb-systemd-helper unmask 'libvirtd-ro.socket' >/dev/null || true
-
- # was-enabled defaults to true, so new installations run enable.
- if deb-systemd-helper --quiet was-enabled 'libvirtd-ro.socket'; then
- # Enables the unit on first installation, creates new
- # symlinks on upgrades if the unit file has changed.
- deb-systemd-helper enable 'libvirtd-ro.socket' >/dev/null ||
true
- else
- # Update the statefile to add new symlinks (if any), which need
to be
- # cleaned up on purge. Also remove old symlinks.
- deb-systemd-helper update-state 'libvirtd-ro.socket' >/dev/null
|| true
- fi
-fi
-if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" =
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
- # This will only remove masks created by d-s-h on package removal.
- deb-systemd-helper unmask 'libvirtd.socket' >/dev/null || true
-
- # was-enabled defaults to true, so new installations run enable.
- if deb-systemd-helper --quiet was-enabled 'libvirtd.socket'; then
- # Enables the unit on first installation, creates new
- # symlinks on upgrades if the unit file has changed.
- deb-systemd-helper enable 'libvirtd.socket' >/dev/null || true
- else
- # Update the statefile to add new symlinks (if any), which need
to be
- # cleaned up on purge. Also remove old symlinks.
- deb-systemd-helper update-state 'libvirtd.socket' >/dev/null ||
true
- fi
-fi
-if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" =
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
- # This will only remove masks created by d-s-h on package removal.
- deb-systemd-helper unmask 'virtlockd-admin.socket' >/dev/null || true
-
- # was-enabled defaults to true, so new installations run enable.
- if deb-systemd-helper --quiet was-enabled 'virtlockd-admin.socket'; then
- # Enables the unit on first installation, creates new
- # symlinks on upgrades if the unit file has changed.
- deb-systemd-helper enable 'virtlockd-admin.socket' >/dev/null
|| true
- else
- # Update the statefile to add new symlinks (if any), which need
to be
- # cleaned up on purge. Also remove old symlinks.
- deb-systemd-helper update-state 'virtlockd-admin.socket'
>/dev/null || true
- fi
-fi
-if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" =
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
- # This will only remove masks created by d-s-h on package removal.
- deb-systemd-helper unmask 'virtlockd.socket' >/dev/null || true
-
- # was-enabled defaults to true, so new installations run enable.
- if deb-systemd-helper --quiet was-enabled 'virtlockd.socket'; then
- # Enables the unit on first installation, creates new
- # symlinks on upgrades if the unit file has changed.
- deb-systemd-helper enable 'virtlockd.socket' >/dev/null || true
- else
- # Update the statefile to add new symlinks (if any), which need
to be
- # cleaned up on purge. Also remove old symlinks.
- deb-systemd-helper update-state 'virtlockd.socket' >/dev/null
|| true
- fi
-fi
-if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" =
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
- # This will only remove masks created by d-s-h on package removal.
- deb-systemd-helper unmask 'virtlogd-admin.socket' >/dev/null || true
-
- # was-enabled defaults to true, so new installations run enable.
- if deb-systemd-helper --quiet was-enabled 'virtlogd-admin.socket'; then
- # Enables the unit on first installation, creates new
- # symlinks on upgrades if the unit file has changed.
- deb-systemd-helper enable 'virtlogd-admin.socket' >/dev/null ||
true
- else
- # Update the statefile to add new symlinks (if any), which need
to be
- # cleaned up on purge. Also remove old symlinks.
- deb-systemd-helper update-state 'virtlogd-admin.socket'
>/dev/null || true
- fi
-fi
-if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" =
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
- # This will only remove masks created by d-s-h on package removal.
- deb-systemd-helper unmask 'virtlogd.socket' >/dev/null || true
-
- # was-enabled defaults to true, so new installations run enable.
- if deb-systemd-helper --quiet was-enabled 'virtlogd.socket'; then
- # Enables the unit on first installation, creates new
- # symlinks on upgrades if the unit file has changed.
- deb-systemd-helper enable 'virtlogd.socket' >/dev/null || true
- else
- # Update the statefile to add new symlinks (if any), which need
to be
- # cleaned up on purge. Also remove old symlinks.
- deb-systemd-helper update-state 'virtlogd.socket' >/dev/null ||
true
- fi
-fi
-if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" =
"abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then
- if [ -z "${DPKG_ROOT:-}" ] && [ -d /run/systemd/system ]; then
- systemctl --system daemon-reload >/dev/null || true
- deb-systemd-invoke start 'libvirtd-admin.socket'
'libvirtd-ro.socket' 'libvirtd.socket' 'virtlockd-admin.socket'
'virtlockd.socket' 'virtlogd-admin.socket' 'virtlogd.socket' >/dev/null || true
- fi
-fi
-# End of section copied verbatim
-
#DEBHELPER#
exit 0
diff -Nru libvirt-8.5.0/debian/libvirt-daemon-system.postrm
libvirt-8.5.0/debian/libvirt-daemon-system.postrm
--- libvirt-8.5.0/debian/libvirt-daemon-system.postrm 2022-07-17
17:12:07.000000000 +0200
+++ libvirt-8.5.0/debian/libvirt-daemon-system.postrm 2022-10-17
23:21:28.000000000 +0200
@@ -142,63 +142,6 @@
;;
esac
-# Section copied verbatim from the output of dh_installsystemd/13.6
-#
-# Due to #994204, we are forced to handle systemd units ourselves to
-# avoid the restart of services/sockets which would result in VMs
-# being stopped or crashing.
-#
-# In order to do this, instead of calling dh_installsystemd in
-# debian/rules we take the output that those calls would generate
-# and hardcode it here, tweaking it as necessary to prevent the
-# problematic scenarios.
-if [ "$1" = remove ] && [ -d /run/systemd/system ] ; then
- systemctl --system daemon-reload >/dev/null || true
-fi
-if [ "$1" = "remove" ]; then
- if [ -x "/usr/bin/deb-systemd-helper" ]; then
- deb-systemd-helper mask 'libvirtd-admin.socket'
'libvirtd-ro.socket' 'libvirtd.socket' 'virtlockd-admin.socket'
'virtlockd.socket' 'virtlogd-admin.socket' 'virtlogd.socket' >/dev/null || true
- fi
-fi
-
-if [ "$1" = "purge" ]; then
- if [ -x "/usr/bin/deb-systemd-helper" ]; then
- deb-systemd-helper purge 'libvirtd-admin.socket'
'libvirtd-ro.socket' 'libvirtd.socket' 'virtlockd-admin.socket'
'virtlockd.socket' 'virtlogd-admin.socket' 'virtlogd.socket' >/dev/null || true
- deb-systemd-helper unmask 'libvirtd-admin.socket'
'libvirtd-ro.socket' 'libvirtd.socket' 'virtlockd-admin.socket'
'virtlockd.socket' 'virtlogd-admin.socket' 'virtlogd.socket' >/dev/null || true
- fi
-fi
-if [ "$1" = remove ] && [ -d /run/systemd/system ] ; then
- systemctl --system daemon-reload >/dev/null || true
-fi
-if [ "$1" = "remove" ]; then
- if [ -x "/usr/bin/deb-systemd-helper" ]; then
- deb-systemd-helper mask 'libvirt-guests.service'
'virtlockd.service' 'virtlogd.service' >/dev/null || true
- fi
-fi
-
-if [ "$1" = "purge" ]; then
- if [ -x "/usr/bin/deb-systemd-helper" ]; then
- deb-systemd-helper purge 'libvirt-guests.service'
'virtlockd.service' 'virtlogd.service' >/dev/null || true
- deb-systemd-helper unmask 'libvirt-guests.service'
'virtlockd.service' 'virtlogd.service' >/dev/null || true
- fi
-fi
-if [ "$1" = remove ] && [ -d /run/systemd/system ] ; then
- systemctl --system daemon-reload >/dev/null || true
-fi
-if [ "$1" = "remove" ]; then
- if [ -x "/usr/bin/deb-systemd-helper" ]; then
- deb-systemd-helper mask 'libvirtd.service' >/dev/null || true
- fi
-fi
-
-if [ "$1" = "purge" ]; then
- if [ -x "/usr/bin/deb-systemd-helper" ]; then
- deb-systemd-helper purge 'libvirtd.service' >/dev/null || true
- deb-systemd-helper unmask 'libvirtd.service' >/dev/null || true
- fi
-fi
-# End of section copied verbatim
-
#DEBHELPER#
exit 0
--- End Message ---
--- Begin Message ---
Source: libvirt
Source-Version: 8.10.0-3
Done: Andrea Bolognani <[email protected]>
We believe that the bug you reported is fixed in the latest version of
libvirt, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andrea Bolognani <[email protected]> (supplier of updated libvirt package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 04 Jan 2023 22:09:31 +0100
Source: libvirt
Architecture: source
Version: 8.10.0-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Libvirt Maintainers
<[email protected]>
Changed-By: Andrea Bolognani <[email protected]>
Closes: 934474 1021956 1025578
Changes:
libvirt (8.10.0-3) unstable; urgency=medium
.
[ Michael Biebl ]
* [4d6db56] Replace manual maintscript code with dh_installsystemd
- No longer needed now that #994204 has been addressed
- Closes: #1021956
* [91d9ac0] Drop no longer supported static priorities from dh_installinit
.
[ Smits Katze ]
* [60b2ca1] libnss-libvirt: Update apt seccomp filter
- Allow getdents64() in addition to getdents()
- Thanks to Thomas Luzat
- Closes: #934474
.
[ Andrea Bolognani ]
* [b9b2923] libvirt-daemon-system: Depend on polkitd instead of policykit-1
- Makes it possible to not install / uninstall pkexec
- Closes: #1025578
* [c62b8b2] libvirt-daemon-system: Drop polkit rules in legacy pkla format
- Makes it possible to not install / uninstall polkitd-pkla
* [8c5870d] control: Bump Standards-Version to 4.6.2
- No changes needed
Checksums-Sha1:
51aaef216eebe22b23ec12b69110d66b0698ce4b 5515 libvirt_8.10.0-3.dsc
851490bc825df0a422041d7b82359eae2adee9fb 82180 libvirt_8.10.0-3.debian.tar.xz
1826f2e53bafc9fa79377b21d23c359f23505490 14440
libvirt_8.10.0-3_source.buildinfo
Checksums-Sha256:
233ff4f4ee47916af4bb516d0b9744f17b0c15ba61cbf9738c08c4425f9a2b29 5515
libvirt_8.10.0-3.dsc
a4820b99c302d8edd975e91f81614efac768f6b6810bd8f61efcae02cfd126d5 82180
libvirt_8.10.0-3.debian.tar.xz
6fe956c0e9d81d765991a44dc92635180e70a42c33ccfc3a71bdfc9426b76ce2 14440
libvirt_8.10.0-3_source.buildinfo
Files:
229a54f05a39630d552deeb660e8444a 5515 libs optional libvirt_8.10.0-3.dsc
b7c5dfbfaac69a9959a0ec4322d5e16e 82180 libs optional
libvirt_8.10.0-3.debian.tar.xz
967df3e0954c5ceddecf9edfeb45e776 14440 libs optional
libvirt_8.10.0-3_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJDBAEBCgAtFiEEO48t9niVypx3EjLf954fxUKFg6wFAmO1+JIPHGVvZkBraXl1
a28ub3JnAAoJEPeeH8VChYOsIuMP/jKmF2SEkf+1L+8glYPEPcDFD/YH+EDwC7x3
MHBhH+OMqBzeCAnN/KvEDA5JYQJvRcqMSFM63HbER3g7Xfl49wyBl3BqoYwwAgjn
hrRlFamuD7/KvWUGwV36JKnkbWby0hSEDGvBMtslaVmgJxd30e2n4e7q62Ad2h7w
Amb9zDr50J7Unv1uVtkVIuiVAXe0IUF/ThNeUBPkhTr9Qb1fEKB+9iVOtlhxaG9+
i1W7Fb8UxfliqRnlVRNSYLUeoHkAn+Jww9XXA/nyDRKiZGAa7cV0PxMMQKCC3bir
gDVMJBM9oQYfD+MPnNUNBni4Soi3RHSyPqWdDkrJ8UhCR74KoxvusGW0lXYUCQwS
wtdGaV0B9pnrxRggN8L9vKt0WVHUgdcvRahkMY8Km8D0WYWJuDgl9syZV9IZQTNy
bpkrkGBY31sRHSCBYDug1mwagIjdrWmIE0awzQEcDFJDZJ8DvTV7wRM7iee1kb6C
O6zareDR5VLdamlYqAPj0fBq9E49l2/sNDuyrg61mgqdP0sREzWpbaN5Uxf0yy4h
0bvOScNvSLSEdJaKmHF+qKWTpRcKlVdg/b5wZOgKqDqGlMTfOL+NnDQcDr1Ahz0k
DWIJvFysg2EYhz6o14RmcmX5I5JxlkIg5mo/quzF9VKk2dQqVWcWKaei7+UmcI03
2/B0VGa4
=evt3
-----END PGP SIGNATURE-----
--- End Message ---
