Your message dated Fri, 6 Jan 2023 11:21:28 -0500
with message-id
<cabw6+srvsap8fq6vpahmu66d-vytmrc_bzm0icies1zry8u...@mail.gmail.com>
and subject line Re: Bug#1028073: libonvif: Fix build problem on hurd
has caused the Debian Bug report #1028073,
regarding libonvif: Fix build problem on hurd
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1028073: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028073
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libonvif
Version: 1.4.4-1
Tags: patch
The code enumerating all network interfaces using getifaddrs() include a
linux specific header file. As far as I can tell from getifaddrs(3),
there is no need for the <linux/if_link.h> include, only the <ifaddrs.h>
one is needed. The latter is available on Hurd, while the former is
not.
This patch get the code building on Debian Hurd.
diff --git a/onvif-gui/src/settingspanel.cpp b/onvif-gui/src/settingspanel.cpp
index b0c6e72..ff0cc52 100644
--- a/onvif-gui/src/settingspanel.cpp
+++ b/onvif-gui/src/settingspanel.cpp
@@ -31,7 +31,6 @@
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
- #include <linux/if_link.h>
#endif
#include <cmath>
--
Happy hacking
Petter Reinholdtsen
--- End Message ---
--- Begin Message ---
The unneeded header <linux/if_link.h> has been removed from source code
On Fri, Jan 6, 2023 at 9:33 AM Petter Reinholdtsen <[email protected]> wrote:
>
> Package: libonvif
> Version: 1.4.4-1
> Tags: patch
>
> The code enumerating all network interfaces using getifaddrs() include a
> linux specific header file. As far as I can tell from getifaddrs(3),
> there is no need for the <linux/if_link.h> include, only the <ifaddrs.h>
> one is needed. The latter is available on Hurd, while the former is
> not.
>
> This patch get the code building on Debian Hurd.
>
> diff --git a/onvif-gui/src/settingspanel.cpp
> b/onvif-gui/src/settingspanel.cpp
> index b0c6e72..ff0cc52 100644
> --- a/onvif-gui/src/settingspanel.cpp
> +++ b/onvif-gui/src/settingspanel.cpp
> @@ -31,7 +31,6 @@
> #include <stdio.h>
> #include <stdlib.h>
> #include <unistd.h>
> - #include <linux/if_link.h>
> #endif
>
> #include <cmath>
>
> --
> Happy hacking
> Petter Reinholdtsen
>
--- End Message ---
