Your message dated Fri, 13 Jan 2023 22:22:50 +0000 with message-id <[email protected]> and subject line Bug#977832: fixed in fai 6.0 has caused the Debian Bug report #977832, regarding fai-setup-storage: setup-storage fails if old disk setup contains a VG with plus sign in its name to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 977832: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977832 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: fai-setup-storage Version: 5.9.4 Severity: normal Dear Maintainer, setup-storage fails to setup a disk if the disk already contains a VG with a plus sign in its name. Minimized disk setup that causes the issue: ``` $ parted --script /dev/loop0 print free Model: Loopback device (loopback) Disk /dev/loop2: 128MB Sector size (logical/physical): 512B/512B Partition Table: gpt Disk Flags: Number Start End Size File system Name Flags 1 17.4kB 128MB 128MB primary lvm $ lsblk /dev/loop0 NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT loop2 7:2 0 122.1M 0 loop └─loop2p1 259:7 0 122M 0 part └─old_vg-a+b 253:5 0 120M 0 lvm ``` Minimized disk config that reproduces the issue: ``` disk_config disk1 disklabel:gpt primary - 0- - - disk_config lvm ``` The setup-storage error message I get for this combination: ``` Cannot satisfy pre-depends for lvremove -f /dev/old_vg/a+b: wipefs_old_vg/a+b -- system left untouched. ``` The impact is that setup-storage can't resetup the disk. If I remove the `+` from `a+b` then the issue doesn't happen. If I remove the `disk_config lvm` line then the issue doesn't happen. We've encountered this issue with existing machines that have been previously installed with Debian Installer. Best, Michael Schaller setup-storage debug output: ``` disklist: loop0 Starting setup-storage 2.3 Using config file: <redacted> Input was: disk_config disk1 disklabel:gpt primary - 0- - - disk_config lvm (CMD) parted -s /dev/loop0 unit TiB print 1> /tmp/DawnyWaUqw 2> /tmp/1CdIC7E2lZ Executing: parted -s /dev/loop0 unit TiB print (STDOUT) Model: Loopback device (loopback) (STDOUT) Disk /dev/loop0: 0.00TiB (STDOUT) Sector size (logical/physical): 512B/512B (STDOUT) Partition Table: gpt (STDOUT) Disk Flags: (STDOUT) (STDOUT) Number Start End Size File system Name Flags (STDOUT) 1 0.00TiB 0.00TiB 0.00TiB primary lvm (STDOUT) (CMD) parted -s /dev/loop0 unit B print free 1> /tmp/6y8bZKl8j9 2> /tmp/cRw5eJZBPo Executing: parted -s /dev/loop0 unit B print free (STDOUT) Model: Loopback device (loopback) (STDOUT) Disk /dev/loop0: 128000000B (STDOUT) Sector size (logical/physical): 512B/512B (STDOUT) Partition Table: gpt (STDOUT) Disk Flags: (STDOUT) (STDOUT) Number Start End Size File system Name Flags (STDOUT) 1 17408B 127983103B 127965696B primary lvm (STDOUT) (CMD) parted -s /dev/loop0 unit chs print free 1> /tmp/JpcgqNuRbJ 2> /tmp/fAQl87C8ra Executing: parted -s /dev/loop0 unit chs print free (STDOUT) Model: Loopback device (loopback) (STDOUT) Disk /dev/loop0: 490,49,1 (STDOUT) Sector size (logical/physical): 512B/512B (STDOUT) BIOS cylinder,head,sector geometry: 490,255,2. Each cylinder is 261kB. (STDOUT) Partition Table: gpt (STDOUT) Disk Flags: (STDOUT) (STDOUT) Number Start End File system Name Flags (STDOUT) 1 0,17,0 490,33,0 primary lvm (STDOUT) Ignoring volume group: dhcp-100-105-1-216-vg Current disk layout in %current_config $VAR1 = { '/dev/loop0' => { 'sector_size' => '512', 'bios_sectors_per_track' => '2', 'size' => '128000000', 'partitions' => { '1' => { 'flags' => 'lvm', 'filesystem' => '', 'count_byte' => '127965696', 'is_extended' => 0, 'begin_byte' => '17408', 'end_byte' => '127983103' } }, 'begin_byte' => 0, 'bios_cylinders' => '490', 'bios_heads' => '255', 'disklabel' => 'gpt', 'end_byte' => 127999999 } }; Current LVM layout in %current_lvm_config $VAR1 = { 'old_vg' => { 'physical_volumes' => [ '/dev/loop0p1' ], 'size' => '120.000839233398', 'volumes' => { 'a+b' => { 'size' => '120.000839233398' } } } }; Current RAID layout in %current_raid_config $VAR1 = {}; Current device tree in %current_dev_children $VAR1 = { 'VG_old_vg' => [ '/dev/old_vg/a+b' ], '/dev/loop0p1' => [ 'VG_old_vg' ], '/dev/loop0' => [ '/dev/loop0p1' ] }; Desired disk layout in %FAI::configs $VAR1 = { 'VG_--ANY--' => { 'opts_all' => {}, 'fstabkey' => 'device' }, 'PHY_/dev/loop0' => { 'partitions' => { '1' => { 'encrypt' => 0, 'start_byte' => 1048576, 'mountpoint' => '-', 'filesystem' => '-', 'size' => { 'always_format' => 0, 'extended' => 0, 'eff_size' => 126934528, 'resize' => 0, 'range' => '126934528-126934528', 'preserve' => 0 }, 'mount_options' => '-', 'end_byte' => 127983103 } }, 'bootable' => -1, 'fstabkey' => 'device', 'preserveparts' => 0, 'disklabel' => 'gpt', 'opts_all' => {}, 'virtual' => 0 } }; Desired device tree in %FAI::dev_children $VAR1 = { '/dev/loop0' => [ '/dev/loop0p1' ] }; Erased devices: /dev/loop0p1 Trying to add CMD: true PRE: POST: exist_/dev/loop0 Trying to add CMD: wipefs -af /dev/loop0p1 PRE: exist_/dev/loop0,self_cleared_VG_old_vg POST: wipefs_/dev/loop0p1 Trying to add CMD: true PRE: exist_/dev/loop0,self_cleared_VG_old_vg,wipefs_/dev/loop0p1 POST: cleared1_/dev/loop0 Trying to add CMD: parted -s /dev/loop0 mklabel gpt PRE: cleared1_/dev/loop0 POST: cleared2_/dev/loop0 Trying to add CMD: parted -s /dev/loop0 mkpart primary "" 1048576B 127983103B PRE: cleared2_/dev/loop0 POST: prep2_/dev/loop0p1 Trying to add CMD: true PRE: prep2_/dev/loop0p1 POST: exist_/dev/loop0p1 Trying to add CMD: vgchange -a n old_vg PRE: self_cleared_/dev/old_vg/a+b POST: vgchange_a_n_VG_old_vg Trying to add CMD: vgchange -a y old_vg PRE: POST: pre_wipe_old_vg Trying to add CMD: wipefs -a /dev/old_vg/a+b PRE: pre_wipe_old_vg, POST: wipefs_old_vg/a+b Trying to add CMD: lvremove -f /dev/old_vg/a+b PRE: wipefs_old_vg/a+b POST: lv_rm_old_vg/a+b,self_cleared_/dev/old_vg/a+b Trying to add CMD: vgremove old_vg PRE: vgchange_a_n_VG_old_vg,lv_rm_old_vg/a+b POST: vg_removed_old_vg Trying to add CMD: pvremove /dev/loop0p1 PRE: vg_removed_old_vg POST: pvremove_old_vg Trying to add CMD: wipefs -af /dev/loop0p1 PRE: pvremove_old_vg POST: pv_sigs_removed_wipe_/dev/loop0p1_old_vg Trying to add CMD: true PRE: pvremove_old_vg,pv_sigs_removed_wipe_/dev/loop0p1_old_vg POST: pv_sigs_removed_old_vg Trying to add CMD: true PRE: vgchange_a_n_VG_old_vg,pv_sigs_removed_old_vg,self_cleared_/dev/old_vg/a+b POST: self_cleared_VG_old_vg Trying to add CMD: true PRE: cleared2_/dev/loop0,exist_/dev/loop0p1 POST: pt_complete_/dev/loop0 Trying to add CMD: wipefs -af /dev/loop0p1 PRE: exist_/dev/loop0,self_cleared_VG_old_vg POST: wipefs_/dev/loop0p1 Trying to add CMD: true PRE: exist_/dev/loop0,self_cleared_VG_old_vg,wipefs_/dev/loop0p1 POST: cleared1_/dev/loop0 Trying to add CMD: parted -s /dev/loop0 mklabel gpt PRE: cleared1_/dev/loop0 POST: cleared2_/dev/loop0 Trying to add CMD: parted -s /dev/loop0 mkpart primary "" 1048576B 127983103B PRE: cleared2_/dev/loop0 POST: prep2_/dev/loop0p1 Trying to add CMD: true PRE: prep2_/dev/loop0p1 POST: exist_/dev/loop0p1 Trying to add CMD: vgchange -a n old_vg PRE: self_cleared_/dev/old_vg/a+b POST: vgchange_a_n_VG_old_vg Trying to add CMD: lvremove -f /dev/old_vg/a+b PRE: wipefs_old_vg/a+b POST: lv_rm_old_vg/a+b,self_cleared_/dev/old_vg/a+b Cannot satisfy pre-depends for lvremove -f /dev/old_vg/a+b: wipefs_old_vg/a+b -- system left untouched. ```
--- End Message ---
--- Begin Message ---Source: fai Source-Version: 6.0 Done: Thomas Lange <[email protected]> We believe that the bug you reported is fixed in the latest version of fai, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Thomas Lange <[email protected]> (supplier of updated fai package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Fri, 13 Jan 2023 22:45:03 +0100 Source: fai Architecture: source Version: 6.0 Distribution: unstable Urgency: low Maintainer: Thomas Lange <[email protected]> Changed-By: Thomas Lange <[email protected]> Closes: 844377 951659 964761 977832 985303 987779 989547 990211 990633 999739 1000572 1005745 1006847 1010593 1010906 1011642 1020976 Changes: fai (6.0) unstable; urgency=low . [ Thomas Lange ] * fai-do-scripts: write output of all scripts to scripts.log, remove code for old cfengine versions (1 and 2) * fai-make-nfsroot: drop support for .asc files, use only .gpg * add autopkgtest * install_packages: add release=<name> feature, Closes: #844377, add pacman support add --allow-change-held-packages parse apt-cache output, Closes: #990211 * fetch-basefile: use curl instead of lftp for downloading * Commands.pm: special handling of nvme devices, Closes: #999739, quote variables, Closes: #977832, remove old code need by old version of mkfs.btrfs and lvcreate, * fai-mk-network: use iproute commands instead of brctl * fai-make-nfsroot: add dracut modul network-legacy, Closes: #1010906 do not kill dhclient, Closes: #987779, drop support for dracut < 049, patch udev rule of lvm for bullseye, include empty machine-id into base.tar * Exec.pm: better error message, Closes: #1005745 * fcopy: handle broken symlinks, Closes: #985303 * fai-chboot: add variable substitution when coping a template, add option -a * fai-class: use of .source scripts now emits an error * fai-kvm: add -M for creating NVMe devices * fai-mirror: use only first line of bpo in sources.list, Closes: #1006847, print number of packages inside the mirror * fai-diskimage: call losetup with -P, Closes: #1010593, do not remove VGs, deactivate them, Closes: #990633, add option -c, print error if umount fails, increase number of tries * fai-cd: set TMPDIR for chroot, Closes: #1000572, add grub module regexp * fai-setup: create ECDSA keys * Fstab.pm: support tmpfs size -, this uses the system default size for tmpfs, Closes: #951659 * setup-storage: add support for fstabkey:partlabel and fstabkey:partuuid, remove crypto keyfile after use * enhance disk_config format for partition label support * ftar: add support for zstd * fai: check if unshare can be used, Closes: #989547 use only IPv4 address as hostname remove code for deprecated taskname prepareapt * watch: update to version 4, use new url * subroutines: umount tmpfs if config space was downloaded via http, Closes: #1011642, check if systemd-resolved is used * task_sysinfo: print machine readable partition information, do not call commands that modify the system if no run in FAI environment, print battery information * subroutines: add help functions: ctam (Chroot TArget Mount pseudo filesystems) ctau (Chroot TArget Umount) ctai (Chroot TArget Into) rm_target (remount /target read-write) * NFSROOT: cleanup package list, add cryptsetup, zstd * update my email address * mk-basefile: remove /var/lib/dbus/machine-id, use zstd instead of gzip add Rocky 9, Debian Forky * ROCKY/60-network-scripts: add support for system-connections/${NIC1}.nmconnection * simple/examples: use fai-link and fai-sed instead of ln and sed, remove cryptsetup passphrase from format.log, use class ROCKY instead of CENTOS, update Ubuntu support to 22.04, add CLOUD_EFI, use ext4 for /boot in LVM examples, install kernel packages without recommends, use $kernelname in package_config set by class/DEBIAN.var * 20-hwdetect.sh: do not load kernel modules by default * get-boot-info: set NIC1 even if no network is used during installation * grub.cfg: new code booting from local disk, support more than two disks, add menu for UEFI settings * 15-root-ssh-key: new script that adds ssh keys class based * disk_config/*_EFI: use new format for gpt, p=<partlabel> instead of primary * GRUB_PC/10-setup: add test * remove --pid from unshare call . [ Mike Gabriel ] * fai-abort:give job control to bash, Closes: #1020976 . [ Juri Grabowski ] * install_packages: add support for alpine Linux apk and Archlinux pacman . [ Guido Günther ] * subroutines: allow one to pass a debootstrap script in FAI_DEBOOTSTRAP . [ Christian Meyer ] * fai-setup: add ECDSA-key to known_hosts . [ Aki Tuomi ] * check-cross-arch: fail on errors and unbound variables . [ Hannes Eberhardt ] * package_config/ROCKY: update EFI packages . [ Christoph Pleger ] * Commands.pm: sort btrfs subvolumes, Closes: #964761 do not call mkfs mutliple times Checksums-Sha1: 3a0b76cded94dd8cfe3733a491efb24437f65c8e 2062 fai_6.0.dsc ede9f2ba29f165363c7a97c6e064f3528c544069 294104 fai_6.0.tar.xz 6f2623d54908a5efe3baaa2f488ca47252771083 16177 fai_6.0_amd64.buildinfo Checksums-Sha256: 822719ef8ff85843be942d09d962c2d56930ac1fc157c14c5fec8330e5ebabef 2062 fai_6.0.dsc 5a9a6b7cb6a60fae5ed3d5446c9b759035365340790f96fcb43e9f27391ae0a7 294104 fai_6.0.tar.xz c2015e3619183d99ea715f3f2a6ada24dd943c0173205af09c9f99a607578f58 16177 fai_6.0_amd64.buildinfo Files: fb3ca16e9afa6c89ebe669ae79d729b1 2062 admin optional fai_6.0.dsc 6620846501a0e8218fb57f49814d2c27 294104 admin optional fai_6.0.tar.xz 3f1eb8bd1408a927acfc305a0ba0b22a 16177 admin optional fai_6.0_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iQJFBAEBCAAvFiEEsR7jJz9rLetSjJPaK/jZ/gdLzeQFAmPB0SERHGxhbmdlQGRl Ymlhbi5vcmcACgkQK/jZ/gdLzeTcow/9EmA/eCOTtnoQIQyNI81VtcybeYHQIdyf lPX9gLXmuC9DBtbmo1DG91ruLX88YMe8D3RGdOaTI200/jzetRx33yqkuQ3dRiYL u2c2/Hu5Sqw9W1080Ym62rxDK4WGKV2BPArS27/FmMgx2JohV5ioy3iveVB7L9Nr uvxy2aTDatT9lvwnCcooljlnW6HPXVyW9UHAbCIbQ2tYzT7jtNsEG/QKRdle+P37 PDpZkpQq9labB3GFBOYW3ZB44TLDIonX7mNOXv/mjmKAcIviOC8VQsydAJl4CySG oXXxU5S3Dwtd2j3pja2sl4AVTSE6t15nslEQho13U2Sz9TzDvpLpW57q7epdgHHK FSLgXfjkjmhuTxOFghQSUqgterFGjtCIKNHgt37n6yD0D1o7guj0epL02oLWYpby M0B2zTzGb4Bht8mknJfvNS7MwOHtHQHa1KPuT+gW+pyo5J0jHyQyG4RHvLa+lmXk bs4eU3q34QuVskmwOzsma5+AwVJiUOXYOHaGxlW12828oDR6QaYkAdHVPMiCEu0k UAuqbtHCeT2fnzSaMw/VwZrXYGiGOKc2uHsU2o9jdWcfblbA/HFj3EpOrtfAKxYN RBLTTY6qPyhFVMcWV8YnXSiYq+GGsF5M1TNGeUx3+USs80sRLfnplTgpEnwplWzv Q65Sqzf8Ijo= =1ynP -----END PGP SIGNATURE-----
--- End Message ---
