Your message dated Sun, 15 Jan 2023 01:22:59 +0000
with message-id <[email protected]>
and subject line Bug#1028919: fixed in mupdf 1.21.1+ds1-2
has caused the Debian Bug report #1028919,
regarding mupdf: Fails to build on GNU Hurd
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1028919: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028919
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: mupdf
Severity: normal
Tags: patch ftbfs
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Dear maintainer,
2 days ago sioyek was accepted into the Debian archive, but it fails to
build on GNU Hurd because of an old version of mupdf.
While GNU Hurd is not a release architecture, I managed to find out why
mupdf fails to build.
I have attached a patch that fixes the build issue on GNU Hurd without
breaking any other architectures.
Kind regards,
Victor Westerhuis
- -- System Information:
Debian Release: bookworm/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (100, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 6.0.0-6-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_NL.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8),
LANGUAGE=en_GB:en_US:en:nl_NL:nl
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
-----BEGIN PGP SIGNATURE-----
iQJHBAEBCAAxFiEE6OxII3T+o0Ujs6ECQz2Rq5dHQPsFAmPDRksTHHZpY3RvckB3
ZXN0ZXJodS5pcwAKCRBDPZGrl0dA+9bMEACc75Oe2An9GtjTKPk8m1V1zGxff98x
v8F37eksHw2Ym6tcGZvj7ScDpzJ6eOnR4T/1HJHDrGYUwwkoCyDHAVu0sV+PH1Wz
NKAz0ozGm7rJglcoVFkvebinsCbqTOdcXIN8N9R2SnyrNW9LakgODKDlWzdexmgK
YYRueG9V4konee8xv4Sh4IuR5wqnEt1GYRfyDnBzZom01SwEB9puDWAUizmNm3vV
PXcniwbq3SdjUMguHiqf/DTC2o/4r2OP3npphuz/m4ASp8LXm9hQX7J3JTeiBlJF
xbHb75r3GlbDTUq03TeDkmQRKk2dUjzbMulsGGAbgMshbYDf+9jTXSOwRgDIkjxT
B5sq/i2ZLeYIvyyB6WS2wMiHgG5pwcHovBl474FcCI/4Hk/A4042AAWkTFtRIk2L
x9kbDDnSKx/OZZXBO6XP6RXTDuUqpeVEweg6rJv+JYzDhcOplwNrkj7uVT4bjkq8
tR6p+ynBtLIh9LRH5+uD2win/+pjionAWXmzjy95hDwEkDOhaG1gwOLFvGqxF+oC
sZtM53dXqQrgfz87VEHRnjy3eCakmnjmIokQ35h5mpBVp88FLl/l/h+dBszHvAv0
FTariZHkwCOzJQOdIOEjO8vDlohsCPFYt+FXtt0edGI3k69kixf1zmSQ49gsrETw
hjb8LD5g4BonOg==
=PFi4
-----END PGP SIGNATURE-----
From: Victor Westerhuis <[email protected]>
Date: Sun, 15 Jan 2023 00:21:34 +0100
Subject: Add fallback for missing SA_NOCLDWAIT
GNU Hurd does not implement SA_NOCLDWAIT. It also does not
automatically reap zombies if SIGCHLD is ignored.
This fallback does not check for failures from waitpid(2), because
there is not much the program can do about them.
---
platform/gl/gl-main.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/platform/gl/gl-main.c b/platform/gl/gl-main.c
index d5ae69c..3060020 100644
--- a/platform/gl/gl-main.c
+++ b/platform/gl/gl-main.c
@@ -2957,6 +2957,11 @@ static void signal_handler(int signal)
{
if (signal == SIGHUP)
reloadrequested = 1;
+#ifndef SA_NOCLDWAIT
+ else if (signal == SIGCHLD)
+ while (waitpid(-1, NULL, WNOHANG) > 0)
+ ;
+#endif
}
#endif
@@ -2973,11 +2978,18 @@ int main(int argc, char **argv)
#ifndef _WIN32
/* Never wait for termination of child processes. */
+#ifdef SA_NOCLDWAIT
struct sigaction arg = {
.sa_handler=SIG_IGN,
.sa_flags=SA_NOCLDWAIT
};
sigaction(SIGCHLD, &arg, NULL);
+#else
+ struct sigaction arg = {
+ .sa_handler=signal_handler
+ };
+ sigaction(SIGCHLD, &arg, NULL);
+#endif
signal(SIGHUP, signal_handler);
#endif
--- End Message ---
--- Begin Message ---
Source: mupdf
Source-Version: 1.21.1+ds1-2
Done: Bastian Germann <[email protected]>
We believe that the bug you reported is fixed in the latest version of
mupdf, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Bastian Germann <[email protected]> (supplier of updated mupdf package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 15 Jan 2023 01:38:15 +0100
Source: mupdf
Architecture: source
Version: 1.21.1+ds1-2
Distribution: unstable
Urgency: medium
Maintainer: Kan-Ru Chen (陳侃如) <[email protected]>
Changed-By: Bastian Germann <[email protected]>
Closes: 1028919
Changes:
mupdf (1.21.1+ds1-2) unstable; urgency=medium
.
* Team upload
* Add fallback for missing SA_NOCLDWAIT (Closes: #1028919)
.
[ Debian Janitor ]
* Trim trailing whitespace
* Use secure URI in Homepage field
* Update standards version to 4.6.2, no changes needed
Checksums-Sha1:
5d1c1a5b15826b0839827092371e283908915b65 2094 mupdf_1.21.1+ds1-2.dsc
1230611b3bd65db76e4a8ecb13aeb61f6b6c3487 27432 mupdf_1.21.1+ds1-2.debian.tar.xz
4cdef2bef92c19d3797fec40c4761b8890970330 6182
mupdf_1.21.1+ds1-2_source.buildinfo
Checksums-Sha256:
d1f963f03beba7d06c9211d435dba569a371a3a46fe35f89d5a19c063bb01434 2094
mupdf_1.21.1+ds1-2.dsc
e0bd318ec70d2407e229d38a4f43dc0da2358c86731a3bdb140a4aafa6705866 27432
mupdf_1.21.1+ds1-2.debian.tar.xz
9b56964ffb20a592195b4c7417cfb050d8602ee97e52596afea8f6015f8cdf59 6182
mupdf_1.21.1+ds1-2_source.buildinfo
Files:
36de3baa99b05c59824dd8c50c3ff557 2094 text optional mupdf_1.21.1+ds1-2.dsc
bb454d3ea239cbe7e8906cbb5e74df20 27432 text optional
mupdf_1.21.1+ds1-2.debian.tar.xz
048874792989d95fbab1bcdf264c39e7 6182 text optional
mupdf_1.21.1+ds1-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQHEBAEBCgAuFiEEQGIgyLhVKAI3jM5BH1x6i0VWQxQFAmPDULIQHGJhZ2VAZGVi
aWFuLm9yZwAKCRAfXHqLRVZDFDMYC/sFC852/2JVYnw75x1q5e62u7dvny+CRdvP
TqS7NIFj22hMa/h08+D1Fi/iOQ6dtJi220RKQGgmtn0AJBognue2ynNWVNHXGFGD
tkgMmQUTJRAlcC+1MRXCgHEu8fm1TMac9imCZ4vDnegcuWcJkJTrx6nSDJWW0F07
hIxJ4phi9aK4zCFWlM6PYgxWx0qoU5BSwIv9xIfsLKof7l/OksdgJH7yURf/DDMs
eKtiiE/FLK+PiOxrLuAzw81fVNw0dXgFTfaKTZpon3GJiEyTm5vBBclfea2RJ5WR
jpkxQBErzLQyG5u27OVfX24MOjgCE7zJJjVtjot/H9M5IHcxZZQ4MU+4nPJIaxdO
U1cNB0goq/Zk3pWUrfS9qFzURT56/S+WAUMAkJ4Q17Ue7ffXGARAJaM6Lw5DCcmN
6phxggWWc8GoYsltQenId2iRrYMXSlA7C+5xSUENhJTfdE6tSCYG+NQ7wQmdcTwp
+Q+wAFLL6TkXS5ZvQ3aChf2tD7cB9oY=
=jla8
-----END PGP SIGNATURE-----
--- End Message ---
