Your message dated Mon, 16 Jan 2023 23:08:49 +0000 with message-id <[email protected]> and subject line Bug#1028977: fixed in mmdebstrap 1.3.0-1 has caused the Debian Bug report #1028977, regarding mmdebstrap --include incorrectly splits apt patterns containing comma to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 1028977: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028977 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: mmdebstrap Version: 1.2.5-1 File: /usr/bin/mmdebstrap Tags: patch upstream Hi Johannes, we recently talked about mmdebstrap --include with an apt pattern containing a comma being broken. An example invocation is: mmdebstrap --variant=apt '--include=?or(?exact-name(linux-image-cloud-amd64),?exact-name(linux-image-amd64))' unstable I figured that I could also come up with the fixing patch and am attaching it to your convenience. If you want to include test cases, please keep in mind that this is fixed twice, once for --variant=extract and once for --variant=apt. Helmut--- a/mmdebstrap +++ b/mmdebstrap @@ -2343,14 +2343,18 @@ } my @apt_argv = ('install'); for my $incl (@{ $options->{include} }) { - for my $pkg (split /[,\s]+/, $incl) { - # strip leading and trailing whitespace - $pkg =~ s/^\s+|\s+$//g; - # skip if the remainder is an empty string - if ($pkg eq '') { - next; + if ($incl =~ /^[?~!(]/) { + push @apt_argv, $incl; + } else { + for my $pkg (split /[,\s]+/, $incl) { + # strip leading and trailing whitespace + $pkg =~ s/^\s+|\s+$//g; + # skip if the remainder is an empty string + if ($pkg eq '') { + next; + } + push @apt_argv, $pkg; } - push @apt_argv, $pkg; } } @@ -2882,14 +2886,18 @@ my %pkgs_to_install; for my $incl (@{ $options->{include} }) { - for my $pkg (split /[,\s]+/, $incl) { - # strip leading and trailing whitespace - $pkg =~ s/^\s+|\s+$//g; - # skip if the remainder is an empty string - if ($pkg eq '') { - next; + if ($incl =~ /^[?~!(]/) { + $pkgs_to_install{$incl} = (); + } else { + for my $pkg (split /[,\s]+/, $incl) { + # strip leading and trailing whitespace + $pkg =~ s/^\s+|\s+$//g; + # skip if the remainder is an empty string + if ($pkg eq '') { + next; + } + $pkgs_to_install{$pkg} = (); } - $pkgs_to_install{$pkg} = (); } } if ($options->{variant} eq 'buildd') {
--- End Message ---
--- Begin Message ---Source: mmdebstrap Source-Version: 1.3.0-1 Done: Johannes Schauer Marin Rodrigues <[email protected]> We believe that the bug you reported is fixed in the latest version of mmdebstrap, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Johannes Schauer Marin Rodrigues <[email protected]> (supplier of updated mmdebstrap package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Mon, 16 Jan 2023 23:13:27 +0100 Source: mmdebstrap Architecture: source Version: 1.3.0-1 Distribution: unstable Urgency: medium Maintainer: Johannes Schauer Marin Rodrigues <[email protected]> Changed-By: Johannes Schauer Marin Rodrigues <[email protected]> Closes: 1028977 Changes: mmdebstrap (1.3.0-1) unstable; urgency=medium . * new upstream release - Do not split --include values again in run_download and run_install (Closes: #1028977) * add debian/patches/run_null.patch Checksums-Sha1: 8e58b6d82b29fb4edef32613e6ea594f4cbe30eb 5037 mmdebstrap_1.3.0-1.dsc 6e0292b9fc9115a74f791e8e50b44f9ef567b061 136708 mmdebstrap_1.3.0.orig.tar.gz 54512a0a227237d4e295eb8e95ac76f2ea901c27 14488 mmdebstrap_1.3.0-1.debian.tar.xz Checksums-Sha256: 541c8d78fdee4385212896fca328dda170eea336dc18241e35f4abec10c73f99 5037 mmdebstrap_1.3.0-1.dsc 9e69194f29cc685b40fb1ea0ea182dec29b7fc5a387a110ff0c32eedd1de6518 136708 mmdebstrap_1.3.0.orig.tar.gz eb8f5974bb19b55b654ffcb414cdbd43085b52c5d803f2328845cd3b3c5ffd52 14488 mmdebstrap_1.3.0-1.debian.tar.xz Files: 183ff3e4d9a07e6e5353b0dca4a03423 5037 admin optional mmdebstrap_1.3.0-1.dsc 1b3ff3260d6cbf33732fbf57f633fd36 136708 admin optional mmdebstrap_1.3.0.orig.tar.gz 9b44e5590268e2b46cd27b8ae1e8d154 14488 admin optional mmdebstrap_1.3.0-1.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEElFhU6KL81LF4wVq58sulx4+9g+EFAmPF0rEACgkQ8sulx4+9 g+FsaxAAsMepnOsul69RDn75l/srctr9Ah+hFn+vGAohUe7JS5FNtOZ1ZqW2nI/f drR+xqsvc0e9hCg7Z90WNExiIc2w7HVPspncfhyELyJJmtPFsfXzV4R5+iC50PjN PVV0V8EesJd/qc7zWowM6ErBm/8f+YclGnoq9EjrR/8uAHlv2gJ79I46TtjacYF4 KUGAod+DU/qud0Sdy9JBBqfvixmFQW0Yfbt4/GHcRI2QiU6PsU4bCZzMPJB7cnnf 2EhizmHyWDUB+XCJquVcoMGUDJJEgTv1UgQFgvKbugmt9BcTmSNVxebUf5TxfTc7 ZFIG8c8NX50KTsyjH5LoWqDmu83/1CiztXoR7qqma3qEl9gehhUh7sGJ4ieBtTmp /6YX9Gq21WMlUk1Toy3p88fBt/vnfl2QW/cJEkpWu6CZ29k2xuYAAGlwgQ24vzqk ApStRNGG8nOS3U485jdxZtMPgrT8Thk/EpMHFhT0O+SUhT3PEk5r/2+G+lpr0UVT e5+mCrbwNQNJaj5PzLi2oTjjUi5ZqvV91en2BMeI7PWPgmJGs/w3st9cwhl5uO8+ OR3P6imj/Q9oAz4ctIk7jpJyrBU+lzjnxINXHr1NgyB1Vrmb0QWSw7FgX4QPKMwz dm5vE+WGUyEdNn7rvPZi+G9PDR/5g9utEbYB46mE2AZJ+EL1FAg= =0Bs6 -----END PGP SIGNATURE-----
--- End Message ---
