Your message dated Sun, 12 Feb 2023 19:32:11 +0000
with message-id <[email protected]>
and subject line Bug#1026927: fixed in needrestart 3.5-4+deb11u3
has caused the Debian Bug report #1026927,
regarding needrestart -b on AMD processors complains of perl  uninitialized 
variable
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1026927: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1026927
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: needrestart
Version: 3.5-4+deb11u2
Severity: normal

Dear Maintainer,

When running 'needrestart -b' on an AMD system, I get the following
uninitialized variable warning.  It also does not report the expected
microcode version (NEEDRESTART-UCEXP).  See output: section below for
example output of needrestart -b.

Use of uninitialized value $ucode_vars{"AVAIL"} in concatenation (.) or string 
at /usr/sbin/needrestart line 904.

This perl warning disappears when adding the -v option (needrestart -b -v),
and the correct value is reported for NEEDRESTART-UCEXP.

The processor, in this system, is:

    vendor_id       : AuthenticAMD
    cpu family      : 18
    model           : 1
    model name      : AMD A4-3400 APU with Radeon(tm) HD Graphics
    stepping        : 0
    microcode       : 0x3000027



It looks to me like the problem is that line 182 of
/usr/share/perl5/NeedRestart/uCode/AMD.pm ends in a comma (,) instead
of a semicolon (;).  This means that assignment is subsumed into the
next line which is under if ($debug).

See the attached patch.

It also looks to me like this is similar symptoms with a different
root cause from bug #973050.


Thanks,
George Robbert


-- Package-specific info:
needrestart output:



-- System Information:
Debian Release: 11.1
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-20-amd64 (SMP w/2 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=ANSI_X3.4-1968) 
(ignored: LC_ALL set to C), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages needrestart depends on:
ii  binutils                   2.35.2-2
ii  dpkg                       1.20.12
ii  gettext-base               0.21-4
ii  libintl-perl               1.26-3+deb11u1
ii  libmodule-find-perl        0.15-1
ii  libmodule-scandeps-perl    1.30-1
ii  libproc-processtable-perl  0.59-2+b1
ii  libsort-naturally-perl     1.03-2
ii  libterm-readkey-perl       2.38-1+b2
ii  perl                       5.32.1-4+deb11u2
ii  xz-utils                   5.2.5-2.1~deb11u1

Versions of packages needrestart recommends:
ii  libpam-elogind [libpam-systemd]  246.10-2
ii  sysvinit-core                    2.96-7+devuan2

Versions of packages needrestart suggests:
pn  iucode-tool                          <none>
pn  needrestart-session | libnotify-bin  <none>

-- Configuration Files:
/etc/apt/apt.conf.d/99needrestart changed:
DPkg::Post-Invoke {"test -x /usr/lib/needrestart/apt-pinvoke && 
/usr/lib/needrestart/apt-pinvoke -b || true"; };

/etc/needrestart/hook.d/20-rpm [Errno 2] No such file or directory: 
'/etc/needrestart/hook.d/20-rpm'

-- no debconf information
--- /tmp/AMD.pm 2022-12-22 11:00:14.589106185 -0700
+++ /usr/share/perl5/NeedRestart/uCode/AMD.pm   2022-12-22 11:00:24.329046436 
-0700
@@ -179,7 +179,7 @@
     if ( exists( $_ucodes->{cpuid}->{$cpuid} ) ) {
         my $prid = $_ucodes->{cpuid}->{$cpuid};
         if ( exists( $_ucodes->{prid}->{$prid} ) ) {
-            $vars{AVAIL} = sprintf( "0x%08x", $_ucodes->{prid}->{$prid} ),
+            $vars{AVAIL} = sprintf( "0x%08x", $_ucodes->{prid}->{$prid} );
 
               print STDERR "$LOGPREF #$info->{processor} found ucode 
$vars{AVAIL}\n" if ($debug);
             if ( $_ucodes->{prid}->{$prid} > $ucode ) {

--- End Message ---
--- Begin Message ---
Source: needrestart
Source-Version: 3.5-4+deb11u3
Done: Patrick Matthäi <[email protected]>

We believe that the bug you reported is fixed in the latest version of
needrestart, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Patrick Matthäi <[email protected]> (supplier of updated needrestart package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 08 Feb 2023 12:20:03 +0100
Source: needrestart
Architecture: source
Version: 3.5-4+deb11u3
Distribution: bullseye
Urgency: medium
Maintainer: Patrick Matthäi <[email protected]>
Changed-By: Patrick Matthäi <[email protected]>
Closes: 1026927
Changes:
 needrestart (3.5-4+deb11u3) bullseye; urgency=medium
 .
   * Add patch 10-amd-reporting from George Robbert to fix a Perl warning on
     AMD64 systems.
     Closes: #1026927
Checksums-Sha1:
 67dfc73ccaaa7ac7fc787fd75622736b963458e1 1800 needrestart_3.5-4+deb11u3.dsc
 d6b82e9130ded3b40d7f4ca95d7c8237785ea907 67824 needrestart_3.5.orig.tar.gz
 e6c85140e2ad2dfed902b8579b520c33ac8cfd0c 11872 
needrestart_3.5-4+deb11u3.debian.tar.xz
 5ed104d8d9f684ef326f4e1fe639cd61d36d16dc 6710 
needrestart_3.5-4+deb11u3_source.buildinfo
Checksums-Sha256:
 57ea5db6b4ce5222b3f31690a1389e753d90e9828ed883416cb9b25204f16c13 1800 
needrestart_3.5-4+deb11u3.dsc
 e9453efde9a0ebaefa5cb3af241382203d14abcc7091bee1249b60039348597e 67824 
needrestart_3.5.orig.tar.gz
 338b5c5e2b1e7189af5e523b43ebaa3675dd31aa77f7d5d2d3ec1fa87d2cba44 11872 
needrestart_3.5-4+deb11u3.debian.tar.xz
 c72da407ce9ab38d099eac15ec3bf7fb007ef2ea16293258ac5ad2334d8006be 6710 
needrestart_3.5-4+deb11u3_source.buildinfo
Files:
 34d4c727932e425e750fb41e793d3060 1800 admin optional 
needrestart_3.5-4+deb11u3.dsc
 1e5ce6743aa6aaf2ca6c7ab37e32f524 67824 admin optional 
needrestart_3.5.orig.tar.gz
 d6e752b429d4ec40f5815bc933171c5b 11872 admin optional 
needrestart_3.5-4+deb11u3.debian.tar.xz
 5811ec91c6c3b3ce8c78e11c3e705ee9 6710 admin optional 
needrestart_3.5-4+deb11u3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEWKA9xYJCWk3IuQ4TEtmwSpDL2OQFAmPjn+YACgkQEtmwSpDL
2OQPOw//SEWVa2GvrviUKJgCYnwPb2rBiECcJRt/pGWyOcsnqZrOf0R2v8uhHFpQ
Y8y8tdLfU+NZXuD+m+vQ5SUhkVyntrD8b06csHX2yzZv1wCjnQL+RdKciA8V+o1c
Kbt4IY5523d1pBAvrb/1iHWO7XemRElEtur/iH1cucF9Dyv56RHSgw2zL/jSG/Mg
+xN4xAgi04lKO1q7qVbxwoswV0Npd+7w0Y2nQENtwQIozjJ558Hgc45shrkIoTQa
F4zhQYyOaZZSNLLQyo2fNjlFNB5+t2Ngrr+70GyN5Ih398lagytU+djBlcUp7ota
5wquJADvfLOkvvcuISqymmOS++rO0dZoQf2Y5aHzaPwE9NiTbZ56K6GHxV49wTD0
TVrE2g6IJQTDavt/NNJBrRMOeXYEf1CdTcIpM23dnc352hkSF5K5gt9pU/yQtRvP
4xUxkmWF4o6PbouwVilbES2Zax6wGIt+s7sa/6MdRtpbamuPh3SHCOhdc0IS23ok
yISicw16q1CJCM/7STmdezjfwGOZxoSqq5R9HHA6LiU4ctQDFx6O2cdf0oBIO4lf
LnyNKPsBOMD70Cw/dgywlGbSCMQWpDM+kXhtEYwbYLcPs07Ac4ZwlbxVxd4o9fig
FgXcgXd0RJ8JpDwj1X+1UUn5pthFTpJubUp+08LrPROElxu/X3Q=
=MVql
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to