Your message dated Sun, 19 Feb 2023 01:03:08 +0000
with message-id <e1pty6e-00aph6...@fasolo.debian.org>
and subject line Bug#1031519: Removed package(s) from unstable
has caused the Debian Bug report #846179,
regarding gitlab: Use notify on ready under systemd instead of hack with sleep
+ check commandline
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
846179: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=846179
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: gitlab
Version: 8.13.6+dfsg1-2
Severity: normal
Dear Maintainer,
The current systemd service file for gitlab-sidekiq contains a hack to
delay the systemd service startup until sidekiq is actually ready by
sleeping for up to 32 seconds (in increments of 4 seconds) until
sidekiq's cmdline changes.
Besides being an unpleasant hack, and potentially ending too early (e.g.
if sidekiq takes more than 32 seconds to start up on a slow/loaded
machine), this also has the unfortunate consequence of showing this
command forever in the service status output, and of making the service
take up to 4 seconds longer than necessary to actually be registered as
started.
We can do much better by performing a proper systemd notify, as follows
(I've tested this locally, and it works properly):
1. Patch the installed /etc/gitlab/initializers/sidekiq.rb to add, near
the top of the configure_server function:
if ((socket_path = ENV["NOTIFY_SOCKET"]))
config.on(:startup) do
notify_socket = Socket.new(Socket::AF_UNIX, Socket::SOCK_DGRAM, 0)
notify_socket.connect(Socket.sockaddr_un(socket_path))
notify_socket.sendmsg "READY=1", Socket::MSG_NOSIGNAL
end
end
2. change the gitlab-sidekiq.service file to contain:
Type=notify
and delete the ExecStartPost= line.
Then we get proper notification support: notification happens
immediately upon sidekiq being ready, the hack is gone, and the job
starts faster.
Jason Rhinelander
smime.p7s
Description: S/MIME Cryptographic Signature
--- End Message ---
--- Begin Message ---
Version: 13.4.7-2+rm
Dear submitter,
as the package gitlab has just been removed from the Debian archive
unstable we hereby close the associated bug reports. We are sorry
that we couldn't deal with your issue properly.
For details on the removal, please see https://bugs.debian.org/1031519
The version of this package that was in Debian prior to this removal
can still be found using https://snapshot.debian.org/.
Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.
This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmas...@ftp-master.debian.org.
Debian distribution maintenance software
pp.
Scott Kitterman (the ftpmaster behind the curtain)
--- End Message ---
