Your message dated Thu, 23 Feb 2023 07:48:59 +0000 with message-id <[email protected]> and subject line Bug#951076: fixed in abi-compliance-checker 2.3-2 has caused the Debian Bug report #951076, regarding abi-compliance-checker: Invalid use of Perl "next" to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 951076: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=951076 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: abi-compliance-checker Version: 2.3-0.2 Severity: normal I've noticed this message repeatedly appearing in the ci.debian.net logs: Can't "next" outside a loop block at /usr/bin/abi-compliance-checker line 10171. That's the "next" in this function: sub exec_helper(@) { my ($reader, $writer) = @_; do { chomp($line = <$reader>); next if (!$line); if ($line eq 'exit') { exit(0); } system($line); print $writer "$? $!\n"; } while(1); } This is a quirk of Perl - "next" doesn't work in a "do { ... } while" like "continue" in C/C++ does because it's really a "do { ... }" block with a while applied. "perldoc perlsyn" suggests just doubling the braces on the loop, but in this case a clearer fix (untested) is probably to rewrite the loop in the form: "while(1) { ... }" The actual current effect of "next" here seems to be to terminate the loop. That seems problematic on the face of it, but in practice I think the only cases where it would trigger are an entirely empty line or "0" with no newline, both of which would mean the end of the input stream. But maybe the loop should terminate at the end of the input stream, since otherwise it seems this loop will never terminate if the stream ends without "exit" being received. So perhaps the better fix is: if (!$line || $line eq 'exit) { exit(0); } Cheers, Olly
--- End Message ---
--- Begin Message ---Source: abi-compliance-checker Source-Version: 2.3-2 Done: Mathieu Malaterre <[email protected]> We believe that the bug you reported is fixed in the latest version of abi-compliance-checker, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Mathieu Malaterre <[email protected]> (supplier of updated abi-compliance-checker package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Thu, 23 Feb 2023 08:27:46 +0100 Source: abi-compliance-checker Architecture: source Version: 2.3-2 Distribution: unstable Urgency: medium Maintainer: Mathieu Malaterre <[email protected]> Changed-By: Mathieu Malaterre <[email protected]> Closes: 951076 1030540 Changes: abi-compliance-checker (2.3-2) unstable; urgency=medium . [ Mathieu Malaterre ] * d/control: Point to actual correct homepage . [ Steve Langasek ] * d/patches: Fix Invalid use of Perl "next". Closes: #951076 * d/patches: uses inconsitent flags to GCC for C code. Closes: #1030540 . [ Mathieu Malaterre ] * d/s/lintian-overrides: remove warning about doc/index.html * d/control: Bump Std-Vers to 4.6.2 no changes needed Checksums-Sha1: c009a5c8f256f0b6f9ee2c928b0e9807ef75f3fe 2098 abi-compliance-checker_2.3-2.dsc 284daa5a650b40fd549f0091481c484e7ba8f65a 11368 abi-compliance-checker_2.3-2.debian.tar.xz bfdbc4c80b1a34cf7207e6364fda3ff4aa28767b 6298 abi-compliance-checker_2.3-2_source.buildinfo Checksums-Sha256: 149f8f34a5e702f01a0cb4cbb552bfdd1718c253fc1b4350c471e19e0de1a4cb 2098 abi-compliance-checker_2.3-2.dsc ee35f91eb8b5d309eaee4cf12f880f3fc42cc5ecb0d2c44efe4eb95df1ea5fca 11368 abi-compliance-checker_2.3-2.debian.tar.xz b8b81723147304d278ce15a17ca1c0b6206a752b3e433d50aa30b7c3cb5e60d1 6298 abi-compliance-checker_2.3-2_source.buildinfo Files: 3b7f4ab3dc7a2c38e9fee43bb82779a4 2098 devel optional abi-compliance-checker_2.3-2.dsc 2d548ca5ffc182b16b7ab7300be92a72 11368 devel optional abi-compliance-checker_2.3-2.debian.tar.xz f78c5fd5db8610599ebef6866482113b 6298 devel optional abi-compliance-checker_2.3-2_source.buildinfo -----BEGIN PGP SIGNATURE----- iQJFBAEBCgAvFiEEaTNn/67NjqrNHwY7AXHhgorgk0UFAmP3FaYRHG1hbGF0QGRl Ymlhbi5vcmcACgkQAXHhgorgk0W4jg//axOVG/VbxLnF8PNcLICG3l5HNMVtGxwU CBchbEg7gHGALiv8ijkeUxfnMZf3LcLtaM+vj09kR3YrL6mC/hc1T6Z/gZIVpu/8 bAuULyzs6PLV6t89BnHKtUEHVHHAaam0zbm7gxot/TnKBfz4OwmUgCQkTNb+Kktp jcSeSLyUdyuSCx/mWuy/3ff+rdmz9qC5HXlVhx/RFCAB4jcUq7d1pPufL4OL2/HH tEx8rWUeewFRZoYeDeYf0UPUJJymTZMdnv8BYP3J5CVetFtqkJmCxw6+KsfzqGpK tQkLCdvcEogokBd3r0e/2J8oxS10iLydvwPRL2uaCQJElx5ggtaESIwukfYUumSc cV7aVlrTpj7aL6PUcLLQh+bfGhKiSvT1n4YPPz6AMqubher3YHJWGV8BiR9R15t9 V4mMnfCMbh8pzd+dBmT6SsmKHpREQA44zxR/4fKrO7mrTAPjv6BJ5WH8o0gvutir b86s2S4Ng1I4Y8kVugJLtnmHjftOuMgjoIWPJTtXF37IYesDLQpBgXmsM6Md/Ylw rdLF4/KWIQcnKca1NZcFQ5fTJW5ZQiZWiAJgq2St+NdsKAFXy66y41Neq+eQSzJd WThe3KbqSfkl2wzkMlvTHTrYQIQzYVu3t7/DtcfLMUpCsftjsaFXO6qkEf0Pioeb i8JhXkOjY0g= =OSGG -----END PGP SIGNATURE-----
--- End Message ---
