Your message dated Sun, 26 Feb 2023 15:48:58 +0000
with message-id <[email protected]>
and subject line Bug#1025369: fixed in debci 3.6
has caused the Debian Bug report #1025369,
regarding debci: Self Service doesn't work for multiple pinned packages
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1025369: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1025369
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: debci
Version: 3.5.2+nmu1
Severity: important
Tags: upstream patch
Dear Maintainer,
Requested tests via Self Service fail to use multiple pinned packaged from the
same suite.
This job failed because it only used libgdal-grass from unstable:
https://ci.debian.net/user/sebastic/retry/28928121
Package name: libgdal-grass
Suite and Arch: testing/amd64
Trigger: grass/8.2.0-3 libgdal-grass/1:1.0.2-3
Pinned packages: ["src:grass", "src:libgdal-grass", "unstable"]
Extra APT Sources: —
From the log:
https://ci.debian.net/data/autopkgtest/testing/amd64/libg/libgdal-grass/28928112/log.gz
Get:141 http://deb.debian.org/debian testing/main amd64 grass-core amd64
8.2.0-2+b1 [6,184 kB]
Get:142 http://deb.debian.org/debian unstable/main amd64 libgdal-grass amd64
1:1.0.2-3 [31.1 kB]
This job succeeded, but failed to use both libgdal-grass and grass from
unstable:
https://ci.debian.net/user/sebastic/retry/28928134
Package name: libgdal-grass
Suite and Arch: testing/amd64
Trigger: libgdal-grass/1:1.0.2-3 grass/8.2.0-3
Pinned packages: ["src:libgdal-grass", "src:grass", "unstable"]
Extra APT Sources: —
From the log:
https://ci.debian.net/data/autopkgtest/testing/amd64/libg/libgdal-grass/28928134/log.gz
Get:132 http://deb.debian.org/debian testing/main amd64 grass-core amd64
8.2.0-2+b1 [6,184 kB]
Get:133 http://deb.debian.org/debian testing/main amd64 libgdal-grass amd64
1:1.0.2-2+b1 [31.3 kB]
This job succeeded and used both libgdal-grass and grass from unstable, because
the JSON was manually crafted:
https://ci.debian.net/user/sebastic/retry/28930518
Package name: libgdal-grass
Suite and Arch: testing/amd64
Trigger: grass/8.2.0-3 libgdal-grass/1:1.0.2-3
Pinned packages: ["src:grass,src:libgdal-grass", "unstable"]
Extra APT Sources: —
From the log:
https://ci.debian.net/data/autopkgtest/testing/amd64/libg/libgdal-grass/28930518/log.gz
Get:133 http://deb.debian.org/debian unstable/main amd64 grass-core amd64
8.2.0-3 [6,183 kB]
Get:134 http://deb.debian.org/debian unstable/main amd64 libgdal-grass amd64
1:1.0.2-3 [31.1 kB]
Note the single string for both packages from unstable.
The following patch might fix the issue:
diff --git a/lib/debci/self_service.rb b/lib/debci/self_service.rb
index 62a706e..26bfc0a 100644
--- a/lib/debci/self_service.rb
+++ b/lib/debci/self_service.rb
@@ -109,7 +109,7 @@ module Debci
}
test_obj['pin-packages'] = []
pin_packages.each do |pin_package|
- pin_package = pin_package.split(/,\s*/)
+ pin_package = pin_package.split(/,\s+/)
test_obj['pin-packages'].push(pin_package)
end
test_request = {
diff --git a/spec/debci/self_service_spec.rb b/spec/debci/self_service_spec.rb
index 5a4c62f..16a844f 100644
--- a/spec/debci/self_service_spec.rb
+++ b/spec/debci/self_service_spec.rb
@@ -194,7 +194,7 @@ describe Debci::SelfService do
{
"trigger": "testing",
"package": "autodep8",
- "pin-packages": [["src:bar", "unstable"], ["foo", "src:bar",
"stable"]],
+ "pin-packages": [["src:bar", "unstable"], ["foo,src:bar",
"stable"]],
"is_private": true,
"extra_apt_sources": ["bullseye-fasttrack"]
}
@@ -226,7 +226,7 @@ describe Debci::SelfService do
{
"trigger": "testing",
"package": "autodep8",
- "pin-packages": [["src:bar", "unstable"], ["foo", "src:bar",
"stable"]]
+ "pin-packages": [["src:bar", "unstable"], ["foo,src:bar",
"stable"]]
}
]
}
@@ -248,7 +248,7 @@ describe Debci::SelfService do
{
"trigger": "testing",
"package": "autodep8",
- "pin-packages": [["src:bar", "unstable"], ["foo", "src:bar",
"stable"]]
+ "pin-packages": [["src:bar", "unstable"], ["foo,src:bar",
"stable"]]
}
]
}
@@ -268,7 +268,7 @@ describe Debci::SelfService do
{
"trigger": "testing",
"package": "autodep8",
- "pin-packages": [["src:bar", "unstable"], ["foo", "src:bar",
"stable"]]
+ "pin-packages": [["src:bar", "unstable"], ["foo,src:bar",
"stable"]]
}
]
}
@@ -289,7 +289,7 @@ describe Debci::SelfService do
{
"trigger": "testing",
"package": "autodep8",
- "pin-packages": [["src:bar", "unstable"], ["foo", "src:bar",
"stable"]],
+ "pin-packages": [["src:bar", "unstable"], ["foo,src:bar",
"stable"]],
}
]
}
Kind Regards,
Bas
--- End Message ---
--- Begin Message ---
Source: debci
Source-Version: 3.6
Done: Antonio Terceiro <[email protected]>
We believe that the bug you reported is fixed in the latest version of
debci, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Antonio Terceiro <[email protected]> (supplier of updated debci package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 26 Feb 2023 12:08:48 -0300
Source: debci
Architecture: source
Version: 3.6
Distribution: unstable
Urgency: medium
Maintainer: Debian CI team <[email protected]>
Changed-By: Antonio Terceiro <[email protected]>
Closes: 1025369 1030883 1031238
Changes:
debci (3.6) unstable; urgency=medium
.
[ Louis-Philippe Véronneau ]
* docs: more precise info on how to get an API key
* docs: remove mention of deprecated getkey endpoint
.
[ Antonio Terceiro ]
* RejectList: pre-expand wildcards when reading the data
* Debci::Status: make code backwards compatible with ruby2.5
* web frontend: rework user authentication
* web frontend: add simple admin interface
* self_service: make auth config forward-compatible with omniauth-gitlab 4.0
* Debci::Job: store file sizes for log and artifacts
* usage: fix help message for backend option
* debci-worker: fix running alternative architectures and backends on the
same host
* admin: add support for stable ordering of records
* admin: add Package.backend and support for select fields in general
* admin: search packages by backend; fix searching on more than one field
* Backend: use package preferred backend if available
* debci-worker: mention backend in the logs
* Debci::AMQP: don't cache queue name per architecture
* api: add entry point to retry tests via a POST request
* Apply suggestions by rubocop 1.39.0
* tools/server.sh: use puma explicitly instead of rackup
* test/test_helper.sh: setup custom management plugin port
* test/bin/wait_for_results: simplify getting timestamp of last test job
* Acknowledge NMU by Michael Biebl
* Debci::Job: avoid artifact filenames being interpreted as tar options
(Closes: #1030883)
* Debci::Job: produce one single pin-package parameter with multiple
packages (Closes: #1025369)
* debci generate-apt-sources: add support for non-free-firmware
(Closes: #1031238)
.
[ Pavit Kaur ]
* Handle signing-keys for extra-apt-sources
.
[ Bas Couwenberg ]
* Fix architecture list in JSON export.
Checksums-Sha1:
bf316679e135fc8053b7617d3c607c849b663990 2897 debci_3.6.dsc
be57005a3aa348949758c4a520cb38dd270ebb7c 131912 debci_3.6.tar.xz
e1d98b77544b34612fbfa0c054e847a1f844888d 13292 debci_3.6_amd64.buildinfo
Checksums-Sha256:
660b90200438481fa1abd5c7938a80ef51f4309314a53a9f96baa350c2ebaa8e 2897
debci_3.6.dsc
197ea1cfbca31f35b1445d4492481fbec0f891f5384362a9ef6846a736486c30 131912
debci_3.6.tar.xz
0f42bcbb8874f531e51328ea192704e0210018decea8473d64ee11fe55a72045 13292
debci_3.6_amd64.buildinfo
Files:
4ecf7203260a72864347d1911cc34691 2897 devel optional debci_3.6.dsc
0df23356bbc62f3a3c35afea64a40a5b 131912 devel optional debci_3.6.tar.xz
904f0785afeb4e09d42ae07c1ce5196a 13292 devel optional debci_3.6_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEst7mYDbECCn80PEM/A2xu81GC94FAmP7ezMACgkQ/A2xu81G
C95WaQ//ZaRePfv0cFB384RS/L1qfXIapjvw++GqnzqUmAPq7bIfKfv1rPOAwCZ0
BnWsz9oubD68cG1MXiH1+h1hGkHufLqAPmjLo8vVjMWgb35cx6oZXmcDcNZQcGrs
XBTes6WvUSrcdwOCmS7nHPx0nTWn3AolyDyuAoGFLjhauMhPWgdxsM0jxleBxpzu
XYL/928Rj1B+9KRWeJtxo8DA7Pz5DBHgAtnoIZ73U4vtQdMlM6RHVT7Lod0APu7k
sScw2fOI5kmle9CdtAnZa9dGh2MkMArevEw/U4h7cP0WQLLCKG8JlZIMx/wyzNHK
FaV4fpZUVI3+UIEn6Omfa4tQMwESF0Wrd3XIrjSh3szkJTK1YXhh0V+KhT8HU7HB
V2NZt7guV+68KMMKgdIVP7iubx2WDxyVjBnlmPSM2wULSgYo7OkaK4iOuColRUgH
dZkurRKoHstSkPYftuym8fODdBnx1TyWzzH0XBeJoFqDQzA58ICSZi1Du4roMXWY
ffMqHwr7sl2LBSWJZkqqsc1+a7sTQ6VldZUuJgKJPt3SdQOo1BBpmFjyGQbn+zVj
ooFQh4VnhtMlo8MVXkMXbBNjG3PddfCnUryMJAgDHuRc06ZMwnP6aZV1+JmrNSL2
INVUnqo4pC5Hl04xD/go3UoyZkimn8x1zMEFxy/wHnRMiM+1JGo=
=TGyF
-----END PGP SIGNATURE-----
--- End Message ---
