Your message dated Tue, 28 Feb 2023 16:04:28 +0000
with message-id <[email protected]>
and subject line Bug#1030305: fixed in django-rich 1.5.0-1
has caused the Debian Bug report #1030305,
regarding django-rich: FTBFS when building with TERM=unknown
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1030305: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1030305
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: django-rich
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu lunar ubuntu-patch
Dear Maintainer,
When building on Ubuntu, the build-time test suite fails with the
following error:
self = <tests.test_management.RichCommandTests
testMethod=test_output_force_color>
def test_output_force_color(self):
stdout = StringIO()
call_command("example", "--force-color", stdout=stdout)
> assert stdout.getvalue() == "\x1b[1;31mAlert!\x1b[0m\n"
E AssertionError: assert 'Alert!\n' == '\x1b[1;31mAlert!\x1b[0m\n'
E - [1;31mAlert![0m
E + Alert!
This happens because the underlying python rich library disables
color/style when the TERM variable is set to unknown (which is what the
Ubuntu builders have):
> Setting the environment variable TERM to "dumb" or "unknown" will
> disable color/style and some features that require moving the cursor,
> such as progress bars.
https://rich.readthedocs.io/en/stable/console.html?highlight=unknown#environment-variables
Although currently Debian is not affected (I believe builders have a
different value for TERM), it feels wrong that the build-time test-suite
would depend on the TERM environment variable. Therefore, I think the
patch still makes sense.
In Ubuntu, the attached patch was applied to achieve the following:
* clear TERM variable when running build test suite since python-rich
disables color/style when TERM=unknown (LP: #2004553)
Thanks for considering the patch.
-- System Information:
Debian Release: bookworm/sid
APT prefers kinetic-updates
APT policy: (500, 'kinetic-updates'), (500, 'kinetic-security'), (500,
'kinetic'), (100, 'kinetic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.19.0-29-generic (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru django-rich-1.4.0/debian/rules django-rich-1.4.0/debian/rules
--- django-rich-1.4.0/debian/rules 2023-01-15 08:19:23.000000000 +0100
+++ django-rich-1.4.0/debian/rules 2023-02-02 12:05:10.000000000 +0100
@@ -12,4 +12,4 @@
# Upstream uses a more agressive call, wont work here
# as at least the package we build isn't installed so
# using a modified pytest call.
- dh_auto_test -- --system=custom --test-args="{interpreter} -m coverage
run -m pytest tests"
+ TERM= dh_auto_test -- --system=custom --test-args="{interpreter} -m
coverage run -m pytest tests"
--- End Message ---
--- Begin Message ---
Source: django-rich
Source-Version: 1.5.0-1
Done: Carsten Schoenert <[email protected]>
We believe that the bug you reported is fixed in the latest version of
django-rich, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Carsten Schoenert <[email protected]> (supplier of updated django-rich
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 28 Feb 2023 16:36:26 +0100
Source: django-rich
Architecture: source
Version: 1.5.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Team <[email protected]>
Changed-By: Carsten Schoenert <[email protected]>
Closes: 1030305
Changes:
django-rich (1.5.0-1) unstable; urgency=medium
.
* [4f7a7a7] New upstream version 1.5.0
(Closes: #1030305)
* [e506213] Rebuild patch queue from patch-queue branch
Just refreshing the patches.
Checksums-Sha1:
7dd3b8cf1ad5a43d6062eefb7a032ed7d2b22beb 2408 django-rich_1.5.0-1.dsc
bcf50d8b070be53ff7272f74115d2b005f02f332 70305 django-rich_1.5.0.orig.tar.gz
0a9b8bc2e00eca9fb938932e835a1d08362227f0 5932 django-rich_1.5.0-1.debian.tar.xz
6885aef91934f5fb1083c1a33d651a9b9abd44a6 7182
django-rich_1.5.0-1_amd64.buildinfo
Checksums-Sha256:
dedbbf00f82a2d5404a2f994445450901cee4b21267909ebad36d651d166fd3b 2408
django-rich_1.5.0-1.dsc
b2b1e78248f26c9fbbfef248a0335be2ca26d590a342df9b5ff8ad581c092891 70305
django-rich_1.5.0.orig.tar.gz
06548f7b846af6c05688fb58617cd3341823a7cf3fe141cbce163385ec65b3cd 5932
django-rich_1.5.0-1.debian.tar.xz
5ef96aae1a564eb469b25d1f479f6ce347f83c960595fbf8bd932d8031c5edf5 7182
django-rich_1.5.0-1_amd64.buildinfo
Files:
3dea45df344e567954a130247157c439 2408 python optional django-rich_1.5.0-1.dsc
b559ccb200ec7028495de499cd2ffc75 70305 python optional
django-rich_1.5.0.orig.tar.gz
5ca65d464737989cb5972f6e7acdf72e 5932 python optional
django-rich_1.5.0-1.debian.tar.xz
82d6967ad3037aecc10fd53a5170571e 7182 python optional
django-rich_1.5.0-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJMBAEBCgA2FiEEtw38bxNP7PwBHmKqgwFgFCUdHbAFAmP+IXUYHGMuc2Nob2Vu
ZXJ0QHQtb25saW5lLmRlAAoJEIMBYBQlHR2wqa0QAJ9Q5lRwbUJizSF1RMmweXzN
KEkQSNnmqVE0iW/vA7OUGl0hzxyTVdtjODKetBqdSt+8GYhnJPVdfzMPoQPj32Z7
NfO3Xj+wFXSbeFA7l09WYthKX13SQo3F/27p2BbuPasA72LghVYfi9Hnfx1hixw/
noXbuspfr4s7R56mCiB4SREnnoR8Cgaq5rNTH2zfo8xcAGCYfmAej2FgVOwz0ftz
RJ+3MCcSZroDO+zjyK/3DHBueAAMsZRn5FxmRF2fyLYTiLx0bOoCSaNb46KJYOxD
GC/YTJ0p7loLcQb2lJQCes7J0Hfny83YjvpYDgJoodTbPUGsxUSqJDnTPP4trIHB
S3k5wVKdsfCUX7mkH1CcF9MMzMnnJMgOCtL2PDJ8TnLGH67/6zxrE7MOePuDF59G
rulIZPubn7ZIapb0vZrfL9nuvY2d8G8OW7akcLs2Xtym22FW7Xxy18EHSqd7jeTF
TqSGcRVz7Pp02pqert35GAUlUpw5rSPLtFizMnR5WQm9OFXrP8hNXpLl//oF4/dO
SJYzxsJ/VyFiVWFLJzm+7Mv0sEx1kUk5TBpr9Yzw62clglIs/KiT7DoEjg5p4VlR
ne+xbM2WUb5bBKqqxY8ibcbDsE68ets6+B5ihEvfE9UnIKJ4YdrDXCGB1FS8F+Bz
xOBHFsar1y0DeelMaZcy
=kBHl
-----END PGP SIGNATURE-----
--- End Message ---
