Your message dated Wed, 08 Mar 2023 11:49:45 +0000
with message-id <[email protected]>
and subject line Bug#966443: fixed in plantuml 1:1.2020.2+ds-3
has caused the Debian Bug report #966443,
regarding plantuml depends on ditaa but uses embedded version of ditaa instead
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
966443: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=966443
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: plantuml
Version: 1:1.2020.2+ds-1
Severity: normal
X-Debbugs-Cc:
I was a bit confused how could ditaa work in plantuml as the usage in there
doesn't match the API in ditaa:
https://sources.debian.org/src/plantuml/1:1.2020.2+ds-1/src/net/sourceforge/plantuml/ditaa/PSystemDitaa.java/#L121
vs
https://sources.debian.org/src/ditaa/0.10+ds1-1.2/src/org/stathissideris/ascii2image/graphics/Diagram.java/#L113
Turns out it only works because plantuml includes its own (patched) version of
ditaa:
https://sources.debian.org/src/plantuml/1:1.2020.2+ds-1/src/org/stathissideris/ascii2image/graphics/Diagram.java/#L109
Therefore I find it confusing and unnecessary to depend on ditaa and patch the
full path to ditaa.jar into classpath in
https://sources.debian.org/src/plantuml/1:1.2020.2+ds-1/debian/patches/pdf.patch/
(Depending on ditaa pulled in the jarwrapper dependency, which seems to
duplicate functionality already provided by
/usr/lib/jvm/java-11-openjdk-amd64/lib/jar.binfmt)
It's also worth noting that the included (patched) version of ditaa is, if I
remember correctly, a bit older than the 0.10 we have in Debian. So you may
want to drop the included ditaa and use the one shipped in Debian instead
(but that one also seems unmaintained and behind upstream, unfortunately). In
that case it'll be helpful to know that the patching done in plantuml is
unnecessary and PSystemDitaa.java can be made to work with vanilla ditaa:
https://salsa.debian.org/liskin/plantuml/-/commit/5ee7fe82b098fa1402eb43acfff0fcc1bd19dbc4#96bdf10a122277d146e589cf010af72842d73ddd
Alternatively you may just drop the dependency and let plantuml use its own
copy of ditaa as it does upstream. Or you can also update the embedded ditaa
in plantuml, which is what I do in https://salsa.debian.org/liskin/plantuml/
(I'm now in the process of rebasing onto current Debian version).
-- System Information:
Debian Release: bullseye/sid
APT prefers testing
APT policy: (990, 'testing'), (990, 'stable'), (500, 'unstable-debug'), (500,
'testing-debug'), (500, 'stable-debug'), (500, 'unstable'), (500, 'stable'),
(1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.7.0-1-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_USER, TAINT_WARN,
TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=cs_CZ.UTF-8, LC_CTYPE=cs_CZ.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages plantuml depends on:
ii default-jre-headless 2:1.11-72
pn ditaa <none>
ii libavalon-framework-java 4.2.0-10
ii libbatik-java 1.12-1.1
ii libcommons-io-java 2.6-2
ii libcommons-logging-java 1.2-2
ii libfop-java 1:2.5-1
ii libjlatexmath-java 1.0.7-3
ii libxml-commons-external-java 1.4.01-5
ii libxmlgraphics-commons-java 2.4-1
Versions of packages plantuml recommends:
ii graphviz 2.42.2-4
plantuml suggests no packages.
-- no debconf information
--
Tomáš Janoušek, a.k.a. Pivník, a.k.a. Liskni_si, https://work.lisk.in/
--- End Message ---
--- Begin Message ---
Source: plantuml
Source-Version: 1:1.2020.2+ds-3
Done: Andrej Shadura <[email protected]>
We believe that the bug you reported is fixed in the latest version of
plantuml, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andrej Shadura <[email protected]> (supplier of updated plantuml package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 08 Mar 2023 12:22:25 +0100
Source: plantuml
Architecture: source
Version: 1:1.2020.2+ds-3
Distribution: unstable
Urgency: medium
Maintainer: Andrej Shadura <[email protected]>
Changed-By: Andrej Shadura <[email protected]>
Closes: 966443 1032506
Changes:
plantuml (1:1.2020.2+ds-3) unstable; urgency=medium
.
[ Tomas Janousek ]
* Update ditaa (Closes: #966443).
* Support SVG export in ditaa.
* ditaa: Force String.format locale to fix decimal separator.
* ditaa: Do not fill dashed shapes, especially not open ones.
.
[ Victor Westerhuis ]
* Use headless mode if default-jre is not installed (Closes: #1032506).
.
[ Adrian Friedli ]
* Improve launcher script.
.
[ Andrej Shadura ]
* Add autopkgtests.
Checksums-Sha1:
5666a023a0406f0289fe72dab35bd789195bab90 1568 plantuml_1.2020.2+ds-3.dsc
5e69ddf242d14605a5451b9a90c7cde0bf8a37ac 45664
plantuml_1.2020.2+ds-3.debian.tar.xz
Checksums-Sha256:
8a8803c6b148c3c733f39b550e418f0be3f776014cd3017abf331ef0da33e3e7 1568
plantuml_1.2020.2+ds-3.dsc
c1de0a39e290050b2ca311c77f1244605704186ae131f0912a6abb9fda2c4ab9 45664
plantuml_1.2020.2+ds-3.debian.tar.xz
Files:
b11e65075d3000997839188b49ab3641 1568 graphics optional
plantuml_1.2020.2+ds-3.dsc
d03ec478a30e26ad1c21e416a8989121 45664 graphics optional
plantuml_1.2020.2+ds-3.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iHUEARYIAB0WIQSD3NF/RLIsyDZW7aHoRGtKyMdyYQUCZAh0yQAKCRDoRGtKyMdy
YZaXAP4vHf69pqccxhV2ZbujFcXNWE73lKPYOCdZQrQyWuLt4AD/X87ukOdurEeW
GftBsN7MZ2pHAp+lI7anDkSfeAKUWAY=
=3qZY
-----END PGP SIGNATURE-----
--- End Message ---
