Your message dated Tue, 14 Mar 2023 19:11:07 +0100
with message-id <[email protected]>
and subject line _GNU_SOURCE defined in open-vm-tools/lib/misc/hostinfoPosix.c
has caused the Debian Bug report #749889,
regarding open-vm-tools: Inconsistent use of _GNU_SOURCE
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
749889: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749889
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: open-vm-tools
Version: 2:9.4.0-1280544-8
Severity: wishlist
Usertags: goto-cc
During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder
and pbuilder) the build failed with the following error. Please note that we
use our research compiler tool-chain (using tools from the cbmc package), which
permits extended reporting on type inconsistencies at link time.
[...]
libtool: link: gcc -shared -fPIC -DPIC .libs/libvmtools_la-i18n.o
.libs/libvmtools_la-monotonicTimer.o .libs/libvmtools_la-signalSource.o
.libs/libvmtools_la-vmtools.o .libs/libvmtools_la-vmtoolsConfig.o
.libs/libvmtools_la-vmtoolsLog.o .libs/libvmtools_la-vmxLogger.o
.libs/libvmtools_la-stub-log.o -Wl,--whole-archive ../lib/lock/.libs/libLock.a
../lib/backdoor/.libs/libBackdoor.a ../lib/dict/.libs/libDict.a
../lib/dynxdr/.libs/libDynxdr.a ../lib/err/.libs/libErr.a
../lib/file/.libs/libFile.a ../lib/glibUtils/.libs/libGlibUtils.a
../lib/guestApp/.libs/libGuestApp.a ../lib/guestRpc/.libs/libGuestRpc.a
../lib/message/.libs/libMessage.a ../lib/netUtil/.libs/libNetUtil.a
../lib/panic/.libs/libPanic.a ../lib/procMgr/.libs/libProcMgr.a
../lib/rpcChannel/.libs/libRpcChannel.a ../lib/rpcIn/.libs/libRpcIn.a
../lib/rpcOut/.libs/libRpcOut.a ../lib/rpcVmx/.libs/libRpcVmx.a
../lib/string/.libs/libString.a ../lib/syncDriver/.libs/libSyncDriver.a
../lib/system/.libs/libSystem.a ../lib/stubs/.libs/libStubsCS.a
../lib/unicode/.libs/libUnicode.a ../lib/user/.libs/libUser.a
../lib/vmCheck/.libs/libVmCheck.a ../lib/vmSignal/.libs/libVmSignal.a
../lib/wiper/.libs/libWiper.a ../lib/misc/.libs/libMisc.a
-Wl,--no-whole-archive -lrt -lcrypt -lpthread -lglib-2.0
-L/usr/lib/x86_64-linux-gnu -licui18n -licuuc -licudata -ldl -lm -O2 -Wl,-z
-Wl,defs -Wl,-lc -Wl,-z -Wl,relro -Wl,-z -Wl,relro -Wl,-soname
-Wl,libvmtools.so.0 -o .libs/libvmtools.so.0.0.0
error: conflicting function declarations "getrlimit"
old definition in module vmtoolsLog file
/usr/include/x86_64-linux-gnu/sys/resource.h line 54
signed int (signed int, struct rlimit *)
new definition in module hostinfoPosix file
/usr/include/x86_64-linux-gnu/sys/resource.h line 54
signed int (enum __rlimit_resource, struct rlimit *)
Makefile:517: recipe for target 'libvmtools.la' failed
make[2]: *** [libvmtools.la] Error 64
make[2]: Leaving directory
'/srv/jenkins-slave/workspace/sid-goto-cc-open-vm-tools/open-vm-tools-9.4.0-1280544/libvmtools'
Makefile:483: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
This is likely safe in practice, but may point out a maintenance issue as
_GNU_SOURCE should rather be set on the compiler command line or in a common
header file than on a per-file basis. The latter, however, is the case here:
http://sources.debian.net/src/open-vm-tools/2:9.4.0-1280544-8/lib/misc/hostinfoPosix.c
does define _GNU_SOURCE, while
http://sources.debian.net/src/open-vm-tools/2:9.4.0-1280544-8/libvmtools/vmtoolsLog.c
doesn't.
Best,
Michael
pgpUJyBwvKVjY.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
Hi,
I think the bug you've reported was fixed in the meantime, as _GNU_SOURCE is
defined in open-vm-tools/lib/misc/hostinfoPosix.c now. Feel free to rebuild
using your tools and reopen (+ maybe suggest a fix/patch).
Thanks,
Bernd
--
Bernd Zeimetz Debian GNU/Linux Developer
http://bzed.de http://www.debian.org
GPG Fingerprint: ECA1 E3F2 8E11 2432 D485 DD95 EB36 171A 6FF9 435F
--- End Message ---
