Your message dated Thu, 27 Apr 2023 10:21:17 +0000
with message-id <e1prykx-008m9h...@fasolo.debian.org>
and subject line Bug#1034892: fixed in php8.2 8.2.5-2
has caused the Debian Bug report #1034892,
regarding php8.2: reproducible-builds: Timestamps in phar files
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1034892: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1034892
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: php8.2
Severity: normal
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org, Jelle van der Waa
<je...@vdwaa.nl>
Somehow the build time affects or is embedded in the generation of
/usr/bin/phar*.phar:
https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/php8.2.html
The attached patch fixes this by setting the timestamp embedded to "0".
I have not tested that the resulting phar8.2.phar functions correctly,
but it does build, so it would be good for someone who knows how to use
phar to test that before applying!
According to my local tests, with this patch applied (and the one for
usrmerge) php8.2 should become reproducible once it transitions to
bookworm/testing!
Other outstanding issues (e.g. build paths) which are tested only on
unstable and experimental, and still need further investigation.
Thanks for maintaining php8.2!
live well,
vagrant
From 743402aceee59da001af1e522290cda561111484 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Tue, 25 Apr 2023 11:20:24 -0700
Subject: [PATCH 4/6] Remove timestamps from "phar".
Thanks to Jelle van der Waa!
https://gist.github.com/jelly/96847934239aac19c512c54ca65d6baa
---
ext/phar/phar.c | 2 +-
ext/phar/util.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ext/phar/phar.c b/ext/phar/phar.c
index f60b0d6a..12cc7b63 100644
--- a/ext/phar/phar.c
+++ b/ext/phar/phar.c
@@ -2999,7 +2999,7 @@ int phar_flush(phar_archive_data *phar, char *user_stub, zend_long len, int conv
4: metadata-len
+: metadata
*/
- mytime = time(NULL);
+ mytime = 0;
phar_set_32(entry_buffer, entry->uncompressed_filesize);
phar_set_32(entry_buffer+4, mytime);
phar_set_32(entry_buffer+8, entry->compressed_filesize);
diff --git a/ext/phar/util.c b/ext/phar/util.c
index 72e633a5..d126d392 100644
--- a/ext/phar/util.c
+++ b/ext/phar/util.c
@@ -574,7 +574,7 @@ phar_entry_data *phar_get_or_create_entry_data(char *fname, size_t fname_len, ch
phar_add_virtual_dirs(phar, path, path_len);
etemp.is_modified = 1;
- etemp.timestamp = time(0);
+ etemp.timestamp = 0;
etemp.is_crc_checked = 1;
etemp.phar = phar;
etemp.filename = estrndup(path, path_len);
--
2.39.2
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: php8.2
Source-Version: 8.2.5-2
Done: Ondřej Surý <ond...@debian.org>
We believe that the bug you reported is fixed in the latest version of
php8.2, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1034...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Ondřej Surý <ond...@debian.org> (supplier of updated php8.2 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 27 Apr 2023 10:13:47 +0200
Source: php8.2
Architecture: source
Version: 8.2.5-2
Distribution: unstable
Urgency: medium
Maintainer: Debian PHP Maintainers <team+pkg-...@tracker.debian.org>
Changed-By: Ondřej Surý <ond...@debian.org>
Closes: 1034423 1034892
Changes:
php8.2 (8.2.5-2) unstable; urgency=medium
.
* Hard code sed path to /bin/sed (Closes: #1034423)
* Remove timestamps from phar (Closes: #1034892)
Checksums-Sha1:
68fb17e920ae91cb68de27ee690110d5c72e90a5 5684 php8.2_8.2.5-2.dsc
5ed87998075c4793f4a9cda0c930004a07c86b8d 69324 php8.2_8.2.5-2.debian.tar.xz
29b57be5d6ec978297a7cf8a2e128362f5709d7c 32494 php8.2_8.2.5-2_amd64.buildinfo
Checksums-Sha256:
d2e91cc90ed5e43cd1995bdf44aa7e86a4b30fd9323b948558b178d25b62a907 5684
php8.2_8.2.5-2.dsc
fa1a9d7c27d7625db7d4e22783681a19d685682c9499fdbd42b4b291836458ff 69324
php8.2_8.2.5-2.debian.tar.xz
c80a675b694cf5830e103bbf5dd48c6c7942bfefbfb3d3e4ef6eb13781f3af41 32494
php8.2_8.2.5-2_amd64.buildinfo
Files:
c8bd56536b06eeb41e90699f6a72998f 5684 php optional php8.2_8.2.5-2.dsc
dc8bda29cf9899e76953dbfdbff6c828 69324 php optional
php8.2_8.2.5-2.debian.tar.xz
3e8fc9dc0f74f95726d6b39e3b51b2a4 32494 php optional
php8.2_8.2.5-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEEw2Gx4wKVQ+vGJel9g3Kkd++uWcIFAmRKSOpfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEMz
NjFCMUUzMDI5NTQzRUJDNjI1RTk3RDgzNzJBNDc3RUZBRTU5QzIACgkQg3Kkd++u
WcJlZBAAiZKNXXE4lkks1covja61GDZZ80BqzIfjR7inLR1v1/Bo5UZbv12t1qNB
fz4livV/8BGQMkAFtAfhLRFkNJs1Mr0FVex95YXHWr0j9AfjT7cy+Lk5kUpyqPv1
JLj4QCddUeyFWxGzvZb7x1LxJQt33S5wWK4lmuXmlw4/GPgO7wdYayn5IrS0vp9/
5Z2oeoL9E/ELtfZKkx9vRoRfz61ywdp4KYt6U14bHM9Sj3xRvk3eENCJW3ZrJp7l
7l5Rva1soKd5evvo4FOKOZEN8+Z4+NFwBk09wf66Fg4oHPrOo+vhOX+fHJcQyOV7
2Sgm69LczoAup+MCrIcZD93/Ms5k24FQcD7E2VuuhrKqZMygBlPyio2iVPZxy9mU
fXlX5ino9eiS2rAdIkzPhK0UrmBoiR2kxPayqMqzh45wLLK35Ok/lpzeI8QNam4k
qZbyx34Eo8c3KXBz7+I19BLd72k6oZTq+xWTrQYpzP6gad+u0tOGGab6REZhbesn
HZp0hCYwS75pPruAbFY5IwftdSme6x2Mthq1o0m0iTlpG4iaaLqeTAPKqJDndYeT
27Hju68Fm/8KJo5l3EWdloKzg3SGo9Rh9g11WLqVI75BYTwXLRp0ihF6B2XUjDjp
jB15H/9a7au77ZUoSQjfNFUBTaDedsJJU6b3uYaOiufW0T5JvVc=
=/0HO
-----END PGP SIGNATURE-----
--- End Message ---
